Skip to content

devlink: Add SF add/delete devlink ops

Parav Pandit netdev oe-kbuild-all 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 32 repliesIn review
  2. v18 patches 1 replySuperseded

Changes in v2 from the cover letter

- Fixed extra semicolon at end of switch case reportec by coccinelle

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8devlink: Introduce PCI SF port flavour and port attributeinclude/net/devlink.h include/uapi/linux/devlink.h net/core/devlink.c+61 -08 replies
2/8devlink: Support add and delete devlink portinclude/net/devlink.h net/core/devlink.c+105 -03 replies
3/8devlink: Prepare code to fill multiple port function attributesnet/core/devlink.c+29 -243 replies
4/8devlink: Support get and set state of port functioninclude/net/devlink.h include/uapi/linux/devlink.h net/core/devlink.c+101 -22 replies
5/8netdevsim: Add support for add and delete of a PCI PF portdrivers/net/netdevsim/Makefile drivers/net/netdevsim/dev.c drivers/net/netdevsim/netdevsim.h +1 more+368 -10 replies
6/8netdevsim: Simulate get/set hardware address of a PCI portdrivers/net/netdevsim/dev.c drivers/net/netdevsim/netdevsim.h drivers/net/netdevsim/port_function.c+52 -00 replies
7/8netdevsim: Simulate port function state for a PCI portdrivers/net/netdevsim/dev.c drivers/net/netdevsim/netdevsim.h drivers/net/netdevsim/port_function.c+38 -00 replies
8/8netdevsim: Add support for add and delete PCI SF portdrivers/net/netdevsim/netdevsim.h drivers/net/netdevsim/port_function.c+92 -48 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchJiri Pirko
1/8R-b
2/8R-b
3/8R-b
4/8R-b
5/8R-b
6/8R-b
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH net-next v2 0/8] devlink: Add SF add/delete devlink ops

Hi Dave, Jakub,

Similar to PCI VF, PCI SF represents portion of the device. PCI SF is represented using a new devlink port flavour.

This short series implements small part of the RFC described in detail at [1] and [2].

It extends
(a) devlink core to expose new devlink port flavour 'pcisf'.
(b) Expose new user interface to add/delete devlink port.
(c) Extends netdevsim driver to simulate PCI PF and SF ports
(d) Add port function state attribute

Patch summary:
Patch-1 Extends devlink to expose new PCI SF port flavour Patch-2 Extends devlink to let user add, delete devlink Port Patch-3 Prepare code to handle multiple port attributes Patch-4 Extends devlink to let user get, set function state Patch-5 Extends netdevsim driver to simulate PCI PF ports Patch-6 Extends netdevsim driver to simulate hw_addr get/set Patch-7 Extends netdevsim driver to simulate function state get/set Patch-8 Extends netdevsim driver to simulate PCI SF ports

[1] https://lore.kernel.org/netdev/20200519092258.GF4655@nanopsycho/
[2] https://marc.info/?l=linux-netdev&m=158555928517777&w=2

---
Changelog:
v1->v2:
- Fixed extra semicolon at end of switch case reportec by coccinelle

Parav Pandit (8):
devlink: Introduce PCI SF port flavour and port attribute
devlink: Support add and delete devlink port
devlink: Prepare code to fill multiple port function attributes
devlink: Support get and set state of port function
netdevsim: Add support for add and delete of a PCI PF port
netdevsim: Simulate get/set hardware address of a PCI port
netdevsim: Simulate port function state for a PCI port
netdevsim: Add support for add and delete PCI SF port

 drivers/net/netdevsim/Makefile        |   3 +-
 drivers/net/netdevsim/dev.c           |  14 +
 drivers/net/netdevsim/netdevsim.h     |  32 ++
 drivers/net/netdevsim/port_function.c | 498 ++++++++++++++++++++++++++
 include/net/devlink.h                 |  75 ++++
 include/uapi/linux/devlink.h          |  13 +
 net/core/devlink.c                    | 230 ++++++++++--
 7 files changed, 840 insertions(+), 25 deletions(-)
 create mode 100644 drivers/net/netdevsim/port_function.c
Signature · 1 line
2.26.2