Skip to content

Improve ODP by using HMM API

Leon Romanovsky linux-rdma 3 versions – Applied

Status from this message: Applied to for-next, thanks

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 1 replyApplied
  2. v24 patches 14 repliesSuperseded
  3. v14 patches 8 repliesSuperseded

Changes in v3 from the cover letter

* Improve control flow in ib_umem_odp_map_dma_single_page() to be clearer and safer.
* Replace pr_debug() by ibdev_dbg()
v2: https://lore.kernel.org/lkml/[email protected]
* Patch #1 – Drop redundant mask.
* Patch #4 – Use address and length directly from umem_odp.
v1: https://lore.kernel.org/lkml/[email protected]
* Cleaned code.
* Support a potential valid dma_address of NULL by flags detection, note was added to clarify things as was asked.
* Fix 80 character lines in few places.
v0: https://lore.kernel.org/lkml/[email protected]

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/4IB/core: Improve ODP to use hmm_range_fault()drivers/infiniband/Kconfig drivers/infiniband/core/umem_odp.c drivers/infiniband/hw/mlx5/odp.c +1 more+129 -1970 replies
2/4IB/core: Enable ODP sync without faultingdrivers/infiniband/core/umem_odp.c drivers/infiniband/hw/mlx5/odp.c include/rdma/ib_umem_odp.h+27 -120 replies
3/4RDMA/mlx5: Extend advice MR to support non faulting modedrivers/infiniband/hw/mlx5/mr.c drivers/infiniband/hw/mlx5/odp.c include/uapi/rdma/ib_user_ioctl_verbs.h+9 -20 replies
4/4RDMA/mlx5: Sync device with CPU pages upon ODP MR registrationdrivers/infiniband/hw/mlx5/mlx5_ib.h drivers/infiniband/hw/mlx5/mr.c drivers/infiniband/hw/mlx5/odp.c+32 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH rdma-next v3 0/4] Improve ODP by using HMM API

From: Leon Romanovsky <[email protected]>

Changelog:
v3:
* Improve control flow in ib_umem_odp_map_dma_single_page() to be clearer and safer.
* Replace pr_debug() by ibdev_dbg()
v2: https://lore.kernel.org/lkml/[email protected]
* Patch #1 – Drop redundant mask.
* Patch #4 – Use address and length directly from umem_odp.
v1: https://lore.kernel.org/lkml/[email protected]
* Cleaned code.
* Support a potential valid dma_address of NULL by flags detection, note was added to clarify things as was asked.
* Fix 80 character lines in few places.
v0: https://lore.kernel.org/lkml/[email protected]

Based on:
https://lore.kernel.org/lkml/[email protected]/

---------------------------------------------------------------------------------------
From Yishai:

This series improves ODP performance by moving to use the HMM API as of below.

The get_user_pages_remote() functionality was replaced by HMM:
- No need anymore to allocate and free memory to hold its output per call.
- No need anymore to use the put_page() to unpin the pages.
- The logic to detect contiguous pages is done based on the returned order from HMM, no need to run per page, and evaluate.

Moving to use the HMM enables to reduce page faults in the system by using the snapshot mode. This mode allows existing pages in the CPU to become presented to the device without faulting.

This non-faulting mode may be used explicitly by an application with some new option of advice MR (i.e. PREFETCH_NO_FAULT) and is used upon ODP MR registration internally as part of initiating the device page table.

To achieve the above, internal changes in the ODP data structures were done and some flows were cleaned-up/adapted accordingly.

Thanks

Yishai Hadas (4):
IB/core: Improve ODP to use hmm_range_fault() IB/core: Enable ODP sync without faulting
RDMA/mlx5: Extend advice MR to support non faulting mode RDMA/mlx5: Sync device with CPU pages upon ODP MR registration

 drivers/infiniband/Kconfig              |   1 +
 drivers/infiniband/core/umem_odp.c      | 293 ++++++++++--------------
 drivers/infiniband/hw/mlx5/mlx5_ib.h    |   5 +
 drivers/infiniband/hw/mlx5/mr.c         |  14 +-
 drivers/infiniband/hw/mlx5/odp.c        |  48 ++--
 include/rdma/ib_umem_odp.h              |  21 +-
 include/uapi/rdma/ib_user_ioctl_verbs.h |   1 +
 7 files changed, 182 insertions(+), 201 deletions(-)

--
2.26.2