Skip to content

mm: clean up some lru related pieces

Yu Zhao cgroups linux-mm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest13 patches 16 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13mm: use add_page_to_lru_list()mm/vmscan.c+3 -42 replies
2/13mm: use page_off_lru()mm/vmscan.c+1 -56 replies
3/13mm: move __ClearPageLRU() into page_off_lru()include/linux/mm_inline.h mm/swap.c mm/vmscan.c+1 -31 reply
4/13mm: shuffle lru list addition and deletion functionsinclude/linux/mm_inline.h+21 -210 replies
5/13mm: don't pass enum lru_list to lru list addition functionsinclude/linux/mm_inline.h mm/swap.c mm/vmscan.c+16 -160 replies
6/13mm: don't pass enum lru_list to trace_mm_lru_insertion()include/trace/events/pagemap.h mm/swap.c+5 -110 replies
7/13mm: don't pass enum lru_list to del_page_from_lru_list()include/linux/mm_inline.h mm/compaction.c mm/mlock.c +2 more+19 -240 replies
8/13mm: rename page_off_lru() to __clear_page_lru_flags()include/linux/mm_inline.h mm/swap.c mm/vmscan.c+13 -220 replies
9/13mm: inline page_lru_base_type()include/linux/mm_inline.h+6 -210 replies
10/13mm: VM_BUG_ON lru page flagsinclude/linux/mm_inline.h mm/swap.c mm/vmscan.c+4 -30 replies
11/13mm: inline __update_lru_size()include/linux/mm_inline.h+1 -80 replies
12/13mm: make lruvec_lru_size() staticinclude/linux/mmzone.h mm/vmscan.c+2 -30 replies
13/13mm: enlarge the int parameter of update_lru_size()include/linux/memcontrol.h include/linux/mm_inline.h include/linux/vmstat.h +1 more+14 -140 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/13] mm: clean up some lru related pieces

Hi Andrew,

I see you have taken this:
mm: use add_page_to_lru_list()/page_lru()/page_off_lru()
Do you mind dropping it?

Michal asked to do a bit of additional work. So I thought I probably should create a series to do more cleanups I've been meaning to.

This series contains the change in the patch above and goes a few more steps farther. It's intended to improve readability and should not have any performance impacts. There are minor behavior changes in terms of debugging and error reporting, which I have all highlighted in the individual patches. All patches were properly tested on 5.8 running Chrome OS, with various debug options turned on.

Michal,

Do you mind taking a looking at the entire series?

Thank you.

Yu Zhao (13):
mm: use add_page_to_lru_list()
mm: use page_off_lru()
mm: move __ClearPageLRU() into page_off_lru()
mm: shuffle lru list addition and deletion functions
mm: don't pass enum lru_list to lru list addition functions
mm: don't pass enum lru_list to trace_mm_lru_insertion()
mm: don't pass enum lru_list to del_page_from_lru_list()
mm: rename page_off_lru() to __clear_page_lru_flags()
mm: inline page_lru_base_type()
mm: VM_BUG_ON lru page flags
mm: inline __update_lru_size()
mm: make lruvec_lru_size() static
mm: enlarge the int parameter of update_lru_size()

 include/linux/memcontrol.h     |  14 ++--
 include/linux/mm_inline.h      | 115 ++++++++++++++-------------------
 include/linux/mmzone.h         |   2 -
 include/linux/vmstat.h         |   2 +-
 include/trace/events/pagemap.h |  11 ++--
 mm/compaction.c                |   2 +-
 mm/memcontrol.c                |  10 +--
 mm/mlock.c                     |   2 +-
 mm/swap.c                      |  53 ++++++---------
 mm/vmscan.c                    |  28 +++-----
 10 files changed, 95 insertions(+), 144 deletions(-)
Signature · 1 line
2.28.0.681.g6f77f65b4e-goog