Skip to content

Felix DSA driver cleanup: build Seville separately

Vladimir Oltean netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11net: dsa: felix: use ocelot_field_{read,write} helpers consistentlydrivers/net/dsa/ocelot/felix_vsc9959.c+3 -30 replies
2/11net: dsa: seville: don't write to MEM_ENA twicedrivers/net/dsa/ocelot/seville_vsc9953.c+0 -10 replies
3/11net: dsa: seville: first enable memories, then initialize themdrivers/net/dsa/ocelot/seville_vsc9953.c+1 -10 replies
4/11net: dsa: ocelot: document why reset procedure is different for felix/sevilledrivers/net/dsa/ocelot/felix_vsc9959.c drivers/net/dsa/ocelot/seville_vsc9953.c+7 -00 replies
5/11net: dsa: seville: remove unused defines for the mdio controllerdrivers/net/dsa/ocelot/seville_vsc9953.c+0 -115 replies
6/11net: dsa: seville: reindent defines for MDIO controllerdrivers/net/dsa/ocelot/seville_vsc9953.c+6 -60 replies
7/11net: dsa: felix: replace tabs with spacesdrivers/net/dsa/ocelot/felix.c drivers/net/dsa/ocelot/felix.h drivers/net/dsa/ocelot/felix_vsc9959.c+13 -130 replies
8/11net: dsa: seville: duplicate vsc9959_mdio_bus_freedrivers/net/dsa/ocelot/felix.h drivers/net/dsa/ocelot/felix_vsc9959.c drivers/net/dsa/ocelot/seville_vsc9953.c+19 -40 replies
9/11net: mscc: ocelot: make ocelot_init_timestamp take a const struct ptp_clock_infodrivers/net/ethernet/mscc/ocelot_ptp.c include/soc/mscc/ocelot_ptp.h+4 -21 reply
10/11net: dsa: felix: move the PTP clock structure to felix_vsc9959.cdrivers/net/dsa/ocelot/felix.c drivers/net/dsa/ocelot/felix.h drivers/net/dsa/ocelot/felix_vsc9959.c+20 -180 replies
11/11net: dsa: seville: build as separate moduledrivers/net/dsa/ocelot/Kconfig drivers/net/dsa/ocelot/Makefile drivers/net/dsa/ocelot/felix.c +3 more+29 -390 replies

Reviews trailers per patch

1 of 11 patches has a Reviewed-by or Acked-by.

PatchAlexandre Belloni
1/11
2/11
3/11
4/11
5/11
6/11
7/11
8/11
9/11R-b
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next 00/11] Felix DSA driver cleanup: build Seville separately

From: Vladimir Oltean <[email protected]>

When introducing the Seville switch support to the Felix driver, some technical debt was created. Since both VSC9959 and VSC9953 are embedded switches (one on an arm64 SoC and the other on a powerpc SoC), there is no use case for having the code for both be present in the same module.

This was necessary at the time due to the common SERDES PCS code that they were using, but that has been since refactored into drivers/net/pcs/pcs-lynx.c.

This makes the Seville driver stop uselessly depending upon PCI and FSL_ENETC_MDIO, which were only dependencies of Felix in fact.

Some whitespace/tab conversions are also present in this series as part of the cleanup process.

Vladimir Oltean (11):
net: dsa: felix: use ocelot_field_{read,write} helpers consistently
net: dsa: seville: don't write to MEM_ENA twice
net: dsa: seville: first enable memories, then initialize them
net: dsa: ocelot: document why reset procedure is different for
felix/seville
net: dsa: seville: remove unused defines for the mdio controller
net: dsa: seville: reindent defines for MDIO controller
net: dsa: felix: replace tabs with spaces
net: dsa: seville: duplicate vsc9959_mdio_bus_free
net: mscc: ocelot: make ocelot_init_timestamp take a const struct
ptp_clock_info
net: dsa: felix: move the PTP clock structure to felix_vsc9959.c
net: dsa: seville: build as separate module

 drivers/net/dsa/ocelot/Kconfig           | 22 +++++----
 drivers/net/dsa/ocelot/Makefile          |  6 ++-
 drivers/net/dsa/ocelot/felix.c           | 47 +------------------
 drivers/net/dsa/ocelot/felix.h           |  7 +--
 drivers/net/dsa/ocelot/felix_vsc9959.c   | 57 +++++++++++++++++-------
 drivers/net/dsa/ocelot/seville_vsc9953.c | 55 ++++++++++++++---------
 drivers/net/ethernet/mscc/ocelot_ptp.c   |  3 +-
 include/soc/mscc/ocelot_ptp.h            |  3 +-
 8 files changed, 102 insertions(+), 98 deletions(-)
Signature · 1 line
2.25.1