Actually implement nvmem support for mtd
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest4 patches 2 repliesIn review
- v24 patches 4 repliesSuperseded
- v14 patches 0 repliesSuperseded
Changes in v3 from the cover letter
* Fix const discard warning in of_net.c
* Add some info about overflow/underflow of mac-increment
* Limit mac-increment-bytes to the last 3 bytes v2:
* Fix compile error (missing mtd_node in mtdcore)
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | mtd: Add nvmem support for mtd nvmem-providersdrivers/ drivers/ | +10 | 0 replies | |
| 2/4 | dt-bindings: mtd: partition: Document use of nvmem-providerDocumentation/ | +59 | 0 replies | |
| 3/4 | of_net: add mac-address-increment supportdrivers/ | +44 | 2 replies | |
| 4/4 | dt-bindings: net: Document use of mac-address-incrementDocumentation/ | +21 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.
Cover letter [PATCH v3 0/4] Actually implement nvmem support for mtd
The mtd support for the nvmem api has been stalled from 2018 with a patch half pushed hoping that a scheme is found for the mtd name later. This pathset try to address this and add a very needed feature for the mac-address.
My solution to the already discussed problem here [1] is to keep it simple. A mtd subpartition can be set as a nvmem-provider with a specific tag and each direct subnode is treat by the nvmem api as a nvmem-cell and gets correctly registred. The mtd driver will treat a direct subnode of the subpartition as a legacy subpartition of the subpartition using the 'fixed-partition' parser. To fix this every nvmem-cell has to have the 'nvmem-cell' tag and the fixed-partition parser will skip these node if this tag is detected. Simple as that. The subpartition with the tag 'nvmem-provider' will then be set by the config to not skip the of registration in the config and the nvmem-cells are correctly registred and can be used to set mac-address of the devices on the system.
The last 2 patch try to address a problem in the embedded devices (mostly routers) that have the mac-address saved in a dedicated partition and is a ""master"" mac-address. Each device increment or decrement the extracted mac-address based on the device number. The increment function is implemented in the of_net function to get the mac-address that every net driver should allready use if they don't have a trusty mac-address source. (One example of this implementation are many ath10k device that gets the mac-address from the art mtd partition assigned to the network driver and increments it 1 for the wifi 2.4ghz and 2 for the wifi 5ghz).
I really hope my mtd nvmem implementation doesn't conflicts with others and can be used, since this would remove many patch used to get mac-address and other nvmem data.
[1] https://lore.kernel.org/patchwork/patch/765435/
Changes:
v3:
* Fix const discard warning in of_net.c
* Add some info about overflow/underflow of mac-increment
* Limit mac-increment-bytes to the last 3 bytes v2:
* Fix compile error (missing mtd_node in mtdcore)
Ansuel Smith (4):
mtd: Add nvmem support for mtd nvmem-providers
dt-bindings: mtd: partition: Document use of nvmem-provider
of_net: add mac-address-increment support
dt-bindings: net: Document use of mac-address-increment
.../devicetree/bindings/mtd/partition.txt | 59 +++++++++++++++++++ .../bindings/net/ethernet-controller.yaml | 21 +++++++ drivers/mtd/mtdcore.c | 3 +- drivers/mtd/parsers/ofpart.c | 8 +++ drivers/of/of_net.c | 57 ++++++++++++++---- 5 files changed, 134 insertions(+), 14 deletions(-)
Signature · 1 line
2.27.0