Skip to content

net: wireless: rtw88: Fix oops on probe errors

Andreas Färber linux-arm-kernel linux-wireless lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2rtw88: Fix probe error handling race with firmware loadingdrivers/net/wireless/realtek/rtw88/main.c+2 -02 replies
2/2rtw88: Fix potential probe error handling race with wow firmware loadingdrivers/net/wireless/realtek/rtw88/main.c+3 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] net: wireless: rtw88: Fix oops on probe errors

Hello,

This mini-series fixes oopses in rtw88 device probe error handling, resulting from asynchronous firmware loading.

Since there does not appear to be a public kernel API for canceling scheduled or ongoing firmware loads, it seems we need to wait with teardown until rtw88's callback was invoked and signals completion.

Found on RTD1296 arm64 SoC with experimental PCI host bridge driver
(https://github.com/afaerber/linux/commits/rtd1295-next) with a 4K physical bar window, resulting in rtw_pci_setup_resource() failing, or with non-implemented 4K remapping resulting in rtw_pci_read32() returning 0xffffffff values and causing rtw_mac_power_on() to fail.

Cheers,
Andreas

Andreas Färber (2):
rtw88: Fix probe error handling race with firmware loading
rtw88: Fix potential probe error handling race with wow firmware
loading

 drivers/net/wireless/realtek/rtw88/main.c | 5 +++++
 1 file changed, 5 insertions(+)
Signature · 1 line
2.28.0