Skip to content

RFC rcu/nocb: De-offload and re-offload support v2

Frederic Weisbecker lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest12 patches 19 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12rcu: Implement rcu_segcblist_is_offloaded() config dependentkernel/rcu/rcu_segcblist.h kernel/rcu/tree.c+8 -154 replies
2/12rcu: Turn enabled/offload states into a common flaginclude/linux/rcu_segcblist.h kernel/rcu/rcu_segcblist.c kernel/rcu/rcu_segcblist.h+28 -70 replies
3/12rcu: Provide basic callback offloading state machine bitsinclude/linux/rcu_segcblist.h kernel/rcu/rcu_segcblist.c kernel/rcu/rcu_segcblist.h +1 more+128 -31 reply
4/12rcu: De-offloading CB kthreadinclude/linux/rcupdate.h kernel/rcu/rcu_segcblist.c kernel/rcu/rcu_segcblist.h +2 more+119 -201 reply
5/12rcu: De-offloading GP kthreadkernel/rcu/tree_plugin.h+51 -23 replies
6/12rcu: Re-offload supportinclude/linux/rcupdate.h kernel/rcu/tree_plugin.h+113 -120 replies
7/12rcu: Shutdown nocb timer on de-offloadingkernel/rcu/tree.h kernel/rcu/tree_plugin.h+12 -13 replies
8/12rcu: Flush bypass before setting SEGCBLIST_SOFTIRQ_ONLYkernel/rcu/tree_plugin.h+8 -20 replies
9/12rcu: Set SEGCBLIST_SOFTIRQ_ONLY at the very last stage of de-offloadingkernel/rcu/tree_plugin.h+8 -10 replies
10/12rcu: Process batch locally as long as offloading isn't completekernel/rcu/rcu_segcblist.h kernel/rcu/tree.c+14 -11 reply
11/12rcu: Locally accelerate callbacks as long as offloading isn't completekernel/rcu/tree.c+3 -41 reply
12/12rcu: Nocb (de)activate through sysfskernel/cpu.c+23 -05 replies

Reviews trailers per patch

None of the 12 patches has a Reviewed-by or Acked-by.

PatchPaul E. McKenneyFrederic Weisbecker
1/12
2/12Inspired-by
3/12Inspired-by
4/12Inspired-by
5/12Inspired-by
6/12Inspired-by
7/12Inspired-by
8/12Inspired-by
9/12Inspired-by
10/12Inspired-by
11/12Inspired-by
12/12Not-Signed-off-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC PATCH 00/12] rcu/nocb: De-offload and re-offload support v2

Hi,

This is the second attempt to make rcu-nocb mutable at runtime. See v1 there: https://lwn.net/Articles/820544/

This time a new approach, as per Paul's suggestion, is to ensure that callbacks are still served locally until nocb kthreads are fully ready or fully asleep. This is using a state machine implemented with a mask (see patch 3/12 for details).

There is still some small polishing to do, as can be seen in the last patches, to make sure that local callbacks processing is correctly handled outside of strict softirq (or rcuc) mode.

Thanks.

git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git
rcu/nocb

HEAD: 6abe8408307eaeb03b4a0470945943c1decbc4b3

Thanks,
Frederic
---

Frederic Weisbecker (12):
rcu: Implement rcu_segcblist_is_offloaded() config dependent
rcu: Turn enabled/offload states into a common flag
rcu: Provide basic callback offloading state machine bits
rcu: De-offloading CB kthread
rcu: De-offloading GP kthread
rcu: Re-offload support
rcu: Shutdown nocb timer on de-offloading
rcu: Flush bypass before setting SEGCBLIST_SOFTIRQ_ONLY
rcu: Set SEGCBLIST_SOFTIRQ_ONLY at the very last stage of de-offloading
rcu: Process batch locally as long as offloading isn't complete
rcu: Locally accelerate callbacks as long as offloading isn't complete
rcu: Nocb (de)activate through sysfs

 include/linux/rcu_segcblist.h | 119 ++++++++++++++++-
 include/linux/rcupdate.h      |   4 +
 kernel/cpu.c                  |  23 ++++
 kernel/rcu/rcu_segcblist.c    |  13 +-
 kernel/rcu/rcu_segcblist.h    |  45 ++++++-
 kernel/rcu/tree.c             |  32 ++---
 kernel/rcu/tree.h             |   2 +
 kernel/rcu/tree_plugin.h      | 297 +++++++++++++++++++++++++++++++++++++++---
 8 files changed, 491 insertions(+), 44 deletions(-)