Skip to content

block/nvme: Map doorbells pages write-only, remove magic from nvme_init

Philippe Mathieu-Daudé qemu-devel 2 versions – Applied

Status from this message: Thanks, applied to my block tree:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 3 repliesApplied
  2. v16 patches 5 repliesSuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/6util/vfio-helpers: Pass page protections to qemu_vfio_pci_map_bar()block/nvme.c include/qemu/vfio-helpers.h util/vfio-helpers.c+5 -40 replies
2/6block/nvme: Map doorbells pages write-onlyblock/nvme.c+19 -100 replies
3/6block/nvme: Reduce I/O registers scopeblock/nvme.c+16 -131 reply
4/6block/nvme: Drop NVMeRegs structure, directly use NvmeBarblock/nvme.c+9 -140 replies
5/6block/nvme: Use register definitions from 'block/nvme.h'block/nvme.c+11 -100 replies
6/6block/nvme: Replace magic value by SCALE_MS definitionblock/nvme.c+1 -10 replies

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchFam Zheng
SeriesR-b
1/6
2/6
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/6] block/nvme: Map doorbells pages write-only, remove magic from nvme_init

Instead of mapping 8K of I/O + doorbells as RW during the whole execution, maps I/O temporarly at init, and map doorbells WO.

Replace various magic values by slighly more explicit macros from "block/nvme.h".

Since v1: Fix uninitialized regs* (patchew)

Philippe Mathieu-Daudé (6):
util/vfio-helpers: Pass page protections to qemu_vfio_pci_map_bar() block/nvme: Map doorbells pages write-only
block/nvme: Reduce I/O registers scope
block/nvme: Drop NVMeRegs structure, directly use NvmeBar block/nvme: Use register definitions from 'block/nvme.h' block/nvme: Replace magic value by SCALE_MS definition

 include/qemu/vfio-helpers.h |  2 +-
 block/nvme.c                | 73 +++++++++++++++++++++----------------
 util/vfio-helpers.c         |  4 +-
 3 files changed, 44 insertions(+), 35 deletions(-)
Signature · 1 line
2.26.2