Skip to content

s390x/tcg: Implement some z14 facilities

David Hildenbrand qemu-devel 2 versions – Applied

Status from this message: Thanks, applied.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 8 repliesApplied
  2. v18 patches 18 repliesSuperseded

Changes in v2 from the cover letter

- "s390x/cpu_model: S390_FEAT_MISC_INSTRUCTION_EXT -> S390_FEAT_MISC_INSTRUCTION_EXT2"
-- Added
- "s390x/tcg: Implement BRANCH INDIRECT ON CONDITION (BIC)" -- Use new helper instead
- "s390x/tcg: Implement MULTIPLY SINGLE (MSC, MSGC, MSGRKC, MSRKC)" -- Tune comparisons in CC computation

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/9s390x/cpu_model: S390_FEAT_MISC_INSTRUCTION_EXT -> S390_FEAT_MISC_INSTRUCTION_EXT2target/s390x/cpu_features_def.h.inc target/s390x/gen-features.c+2 -22 replies
2/9s390x/tcg: Implement ADD HALFWORD (AGH)target/s390x/insn-data.def target/s390x/translate.c+2 -00 replies
3/9s390x/tcg: Implement SUBTRACT HALFWORD (SGH)target/s390x/insn-data.def+1 -00 replies
4/9s390x/tcg: Implement MULTIPLY (MG, MGRK)target/s390x/insn-data.def target/s390x/translate.c+15 -00 replies
5/9s390x/tcg: Implement MULTIPLY HALFWORD (MGH)target/s390x/insn-data.def+1 -00 replies
6/9s390x/tcg: Implement BRANCH INDIRECT ON CONDITION (BIC)target/s390x/insn-data.def target/s390x/translate.c+10 -01 reply
7/9s390x/tcg: Implement MULTIPLY SINGLE (MSC, MSGC, MSGRKC, MSRKC)target/s390x/cc_helper.c target/s390x/helper.c target/s390x/insn-data.def +2 more+59 -01 reply
8/9s390x/tcg: We support Miscellaneous-Instruction-Extensions Facility 2target/s390x/gen-features.c+1 -00 replies
9/9s390x/tcg: Implement CIPHER MESSAGE WITH AUTHENTICATION (KMA)target/s390x/gen-features.c target/s390x/insn-data.def target/s390x/translate.c+9 -00 replies

Reviews trailers per patch

8 of 9 patches have a Reviewed-by or Acked-by.

PatchThomas HuthRichard Henderson
1/9
2/9R-b R-b
3/9R-b R-b
4/9R-b
5/9R-b
6/9R-b
7/9R-b
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/9] s390x/tcg: Implement some z14 facilities

With this patchset, I can boot a kernel compiled for z14 (requiring Miscellaneous-Instruction-Extensions Facility 2) (using -cpu max).

I am currently working on "vector-enhancements facility 1", I have most stuff in place except:
- VECTOR FP (MAXIMUM|MINIMUM): needs some manual work to cover all types of comparisons.

Once we have that in place, we can convert the QEMU machine to a stripped-down z14.

v1 -> v2:
- "s390x/cpu_model: S390_FEAT_MISC_INSTRUCTION_EXT -> S390_FEAT_MISC_INSTRUCTION_EXT2"
-- Added
- "s390x/tcg: Implement BRANCH INDIRECT ON CONDITION (BIC)" -- Use new helper instead
- "s390x/tcg: Implement MULTIPLY SINGLE (MSC, MSGC, MSGRKC, MSRKC)" -- Tune comparisons in CC computation

David Hildenbrand (9):
s390x/cpu_model: S390_FEAT_MISC_INSTRUCTION_EXT ->

    S390_FEAT_MISC_INSTRUCTION_EXT2

s390x/tcg: Implement ADD HALFWORD (AGH)
s390x/tcg: Implement SUBTRACT HALFWORD (SGH)
s390x/tcg: Implement MULTIPLY (MG, MGRK)
s390x/tcg: Implement MULTIPLY HALFWORD (MGH)
s390x/tcg: Implement BRANCH INDIRECT ON CONDITION (BIC) s390x/tcg: Implement MULTIPLY SINGLE (MSC, MSGC, MSGRKC, MSRKC) s390x/tcg: We support Miscellaneous-Instruction-Extensions Facility 2 s390x/tcg: Implement CIPHER MESSAGE WITH AUTHENTICATION (KMA)

 target/s390x/cc_helper.c            | 32 +++++++++++++++++++
 target/s390x/cpu_features_def.h.inc |  2 +-
 target/s390x/gen-features.c         |  4 ++-
 target/s390x/helper.c               |  2 ++
 target/s390x/insn-data.def          | 12 ++++++++
 target/s390x/internal.h             |  2 ++
 target/s390x/translate.c            | 48 +++++++++++++++++++++++++++++
 7 files changed, 100 insertions(+), 2 deletions(-)
Signature · 1 line
2.26.2