Skip to content

nvme-fcloop: fix shutdown and improve logging

Hannes Reinecke linux-nvme 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7nvme-fcloop: flush workqueue before calling nvme_fc_unregister_remoteport()drivers/nvme/target/fcloop.c+1 -11 reply
2/7nvmet-fc: use per-target workqueue when removing associationsdrivers/nvme/target/fc.c+23 -61 reply
3/7nvme-fcloop: use IDA for port idsdrivers/nvme/target/fcloop.c+43 -82 replies
4/7nvmet-fc: use feature flag for virtual LLDDdrivers/nvme/target/fc.c drivers/nvme/target/fcloop.c include/linux/nvme-fc-driver.h+55 -421 reply
5/7nvme-fc: use feature flag for virtual LLDDdrivers/nvme/host/fc.c drivers/nvme/target/fcloop.c include/linux/nvme-fc-driver.h+64 -411 reply
6/7nvme-fcloop: use a device for nportdrivers/nvme/target/fcloop.c+21 -101 reply
7/7nvme-fcloop: use a device for lportdrivers/nvme/target/fcloop.c+39 -141 reply

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchJames Smart
1/7R-b
2/7R-b
3/7R-b
4/7R-b
5/7R-b
6/7R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/7] nvme-fcloop: fix shutdown and improve logging

Hi all,

there's a long-standing issue with fcloop that it triggers a use-after-free when removing ports as the disconnect I/O is still running while the ports are being removed.
This patchset fixes up this issue and also creates a device for each localport and each nport; with that the logging is vastly improved as we now have readable device names in the logging output and not "(NULL devuce *)".

Blocktests will be send separately.

As usual, comments and reviews are welcome.

Hannes Reinecke (7):
nvme-fcloop: flush workqueue before calling
nvme_fc_unregister_remoteport()
nvmet-fc: use per-target workqueue when removing associations
nvme-fcloop: use IDA for port ids
nvmet-fc: use feature flag for virtual LLDD
nvme-fc: use feature flag for virtual LLDD
nvme-fcloop: use a device for nport
nvme-fcloop: use a device for lport

 drivers/nvme/host/fc.c         |  93 ++++++++++++++++-------------
 drivers/nvme/target/fc.c       | 122 +++++++++++++++++++++++---------------
 drivers/nvme/target/fcloop.c   | 131 ++++++++++++++++++++++++++++++++---------
 include/linux/nvme-fc-driver.h |  12 ++++
 4 files changed, 241 insertions(+), 117 deletions(-)
Signature · 7 lines
2.16.4


_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme