Skip to content

drivers/mfd: Constify static struct resource

Rikard Falkeborn linux-arm-kernel linux-omap lkml 1 version Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 13 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/8mfd: da: Constify static struct resourcedrivers/mfd/da9055-core.c drivers/mfd/da9062-core.c drivers/mfd/da9063-core.c +1 more+23 -232 replies
2/8mfd: intel: Constify static struct resourcedrivers/mfd/intel_msic.c drivers/mfd/intel_soc_pmic_bxtwc.c drivers/mfd/intel_soc_pmic_chtdc_ti.c +2 more+28 -284 replies
3/8mfd: Constify static struct resource in OMAP2+ driversdrivers/mfd/tps65217.c drivers/mfd/tps65910.c+3 -31 reply
4/8mfd: wm: Constify static struct resourcedrivers/mfd/wm831x-core.c drivers/mfd/wm8994-core.c+28 -282 replies
5/8mfd: lp8788: Constify static struct resourcedrivers/mfd/lp8788.c+2 -21 reply
6/8mfd: stmpe: Constify static struct resourcedrivers/mfd/stmpe.c+5 -51 reply
7/8mfd: sun4i-gpadc: Constify static struct resourcedrivers/mfd/sun4i-gpadc.c+1 -11 reply
8/8mfd: Constify static struct resourcedrivers/mfd/88pm800.c drivers/mfd/88pm860x-core.c drivers/mfd/hi655x-pmic.c +12 more+82 -821 reply

Reviews trailers per patch

3 of 8 patches have a Reviewed-by or Acked-by.

PatchAndy ShevchenkoAdam ThomsonCharles Keepax
1/8A-b
2/8R-b
3/8
4/8A-b
5/8
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/8] drivers/mfd: Constify static struct resource

Constify a number of static struct resource to allow the compiler to put them in read-only memory. Typically, the only usage of these is to assign their address to the resources field in the mfd_cell struct, which is a const pointer (a few drivers also read the value of the start field).

I went through the rest of the static instances of struct resource in drivers/mfd and all of them are either directly modified by the driver or has its address passed to mfd_add_devices() which takes a non-const pointer.

The series is compile-tested only.

I split this into patches per maintainer, I'll happily split it (or squash it) some other way if that's preferable.

Rikard Falkeborn (8):
mfd: da: Constify static struct resource
mfd: intel: Constify static struct resource
mfd: Constify static struct resource in OMAP2+ drivers
mfd: wm: Constify static struct resource
mfd: lp8788: Constify static struct resource
mfd: stmpe: Constify static struct resource
mfd: sun4i-gpadc: Constify static struct resource
mfd: Constify static struct resource

 drivers/mfd/88pm800.c                 |  2 +-
 drivers/mfd/88pm860x-core.c           | 50 ++++++++++++------------
 drivers/mfd/da9055-core.c             |  8 ++--
 drivers/mfd/da9062-core.c             | 24 ++++++------
 drivers/mfd/da9063-core.c             |  8 ++--
 drivers/mfd/da9150-core.c             |  6 +--
 drivers/mfd/hi655x-pmic.c             |  2 +-
 drivers/mfd/intel_msic.c              | 18 ++++-----
 drivers/mfd/intel_quark_i2c_gpio.c    |  4 +-
 drivers/mfd/intel_soc_pmic_bxtwc.c    | 14 +++----
 drivers/mfd/intel_soc_pmic_chtdc_ti.c | 10 ++---
 drivers/mfd/intel_soc_pmic_chtwc.c    |  4 +-
 drivers/mfd/intel_soc_pmic_crc.c      | 10 ++---
 drivers/mfd/ioc3.c                    | 16 ++++----
 drivers/mfd/lp8788.c                  |  4 +-
 drivers/mfd/max8925-core.c            | 56 +++++++++++++--------------
 drivers/mfd/rdc321x-southbridge.c     |  4 +-
 drivers/mfd/retu-mfd.c                |  4 +-
 drivers/mfd/rk808.c                   |  8 ++--
 drivers/mfd/stmpe.c                   | 10 ++---
 drivers/mfd/sun4i-gpadc.c             |  2 +-
 drivers/mfd/tc3589x.c                 |  4 +-
 drivers/mfd/tc6387xb.c                |  2 +-
 drivers/mfd/tc6393xb.c                |  6 +--
 drivers/mfd/tps65090.c                |  2 +-
 drivers/mfd/tps65217.c                |  4 +-
 drivers/mfd/tps6586x.c                |  2 +-
 drivers/mfd/tps65910.c                |  2 +-
 drivers/mfd/tps80031.c                |  2 +-
 drivers/mfd/wm831x-core.c             | 52 ++++++++++++-------------
 drivers/mfd/wm8994-core.c             |  4 +-
 31 files changed, 172 insertions(+), 172 deletions(-)
Signature · 1 line
2.28.0