Skip to content

qapi: static typing conversion, pt5

John Snow qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest26 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/26qapi/parser.py: refactor parsing routine into methodscripts/qapi/parser.py+18 -120 replies
2/26qapi/parser.py: group variable declarations in __init__scripts/qapi/parser.py+7 -00 replies
3/26qapi/parser.py: use 'with' statement for opening filesscripts/qapi/parser.py+2 -20 replies
4/26qapi/source.py: Add default arguments to QAPISourceInfoscripts/qapi/parser.py scripts/qapi/source.py+6 -30 replies
5/26qapi/parser.py: start source info at line 0scripts/qapi/parser.py+2 -10 replies
6/26qapi/parser.py: raise QAPIParseError during file openingscripts/qapi/parser.py+7 -50 replies
7/26qapi/parser.py: fully remove 'null' constantscripts/qapi/parser.py tests/qapi-schema/leading-comma-list.err tests/qapi-schema/trailing-comma-list.err+6 -60 replies
8/26qapi/parser.py: Assert lexer value is a stringscripts/qapi/parser.py+1 -00 replies
9/26qapi/parser.py: assert get_expr returns object in outer loopscripts/qapi/parser.py+3 -00 replies
10/26qapi/parser.py: assert object keys are stringsscripts/qapi/parser.py+2 -00 replies
11/26qapi/parser.py: Convert several methods to @classmethodscripts/qapi/parser.py+6 -40 replies
12/26qapi/parser.py: add casts to pragma checksscripts/qapi/parser.py+3 -30 replies
13/26qapi/parser.py: add type hint annotationsscripts/qapi/parser.py+49 -200 replies
14/26qapi/parser.py: add docstringsscripts/qapi/parser.py+38 -00 replies
15/26qapi/parser.py: add ParsedExpression typescripts/qapi/expr.py scripts/qapi/parser.py scripts/qapi/schema.py+41 -530 replies
16/26qapi/pragma.py: Move QAPISchemaPragma into its own modulescripts/qapi/pragma.py scripts/qapi/source.py+27 -130 replies
17/26qapi/pragma.py: Move pragma parsing out of parser.pyscripts/qapi/error.py scripts/qapi/parser.py scripts/qapi/pragma.py+59 -450 replies
18/26qapi/parser.py: Modify _include() to use parser statescripts/qapi/parser.py+8 -130 replies
19/26qapi/parser.py: add parent argumentscripts/qapi/parser.py+11 -140 replies
20/26qapi/parser.py: remove unused check_args_section argumentsscripts/qapi/parser.py+3 -30 replies
21/26qapi/parser.py: QAPIDoc: convert @staticmethod to @classmethodscripts/qapi/parser.py+2 -20 replies
22/26qapi/parser.py: add type hint annotations (QAPIDoc)scripts/qapi/parser.py+38 -300 replies
23/26qapi/parser.py: enable mypy checksscripts/qapi/mypy.ini+0 -50 replies
24/26qapi/parser.py: remove one and two-letter variablesscripts/qapi/parser.py+15 -130 replies
25/26qapi/parser.py: Silence too-few-public-methods warningscripts/qapi/parser.py+2 -00 replies
26/26qapi/parser.py: enable pylint checksscripts/qapi/pylintrc+1 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/26] qapi: static typing conversion, pt5

based-on: <[email protected]>
[PATCH 0/6] qapi: static typing conversion, pt4

Hi, this series adds static type hints to the QAPI module. This is part five!

Part 5: https://gitlab.com/jsnow/qemu/-/tree/python-qapi-cleanup-pt5
Everything: https://gitlab.com/jsnow/qemu/-/tree/python-qapi-cleanup-pt6

- Requires Python 3.6+
- Requires mypy 0.770 or newer (for type analysis only)
- Requires pylint 2.6.0 or newer (for lint checking only)

This part of the series focuses on just parser.py.

Type hints are added in patches that add *only* type hints and change no other behavior. Any necessary changes to behavior to accommodate typing are split out into their own tiny patches.

Every commit should pass with:
- flake8 qapi/
- pylint --rcfile=qapi/pylintrc qapi/
- mypy --config-file=qapi/mypy.ini qapi/

John Snow (26):
qapi/parser.py: refactor parsing routine into method qapi/parser.py: group variable declarations in __init__ qapi/parser.py: use 'with' statement for opening files qapi/source.py: Add default arguments to QAPISourceInfo qapi/parser.py: start source info at line 0 qapi/parser.py: raise QAPIParseError during file opening qapi/parser.py: fully remove 'null' constant qapi/parser.py: Assert lexer value is a string qapi/parser.py: assert get_expr returns object in outer loop qapi/parser.py: assert object keys are strings qapi/parser.py: Convert several methods to @classmethod qapi/parser.py: add casts to pragma checks qapi/parser.py: add type hint annotations qapi/parser.py: add docstrings
qapi/parser.py: add ParsedExpression type qapi/pragma.py: Move QAPISchemaPragma into its own module qapi/pragma.py: Move pragma parsing out of parser.py qapi/parser.py: Modify _include() to use parser state qapi/parser.py: add parent argument
qapi/parser.py: remove unused check_args_section arguments qapi/parser.py: QAPIDoc: convert @staticmethod to @classmethod qapi/parser.py: add type hint annotations (QAPIDoc) qapi/parser.py: enable mypy checks
qapi/parser.py: remove one and two-letter variables qapi/parser.py: Silence too-few-public-methods warning qapi/parser.py: enable pylint checks

 scripts/qapi/error.py                     |   8 +-
 scripts/qapi/expr.py                      |  56 ++--
 scripts/qapi/mypy.ini                     |   5 -
 scripts/qapi/parser.py                    | 322 +++++++++++++---------
 scripts/qapi/pragma.py                    |  68 +++++
 scripts/qapi/pylintrc                     |   3 +-
 scripts/qapi/schema.py                    |   6 +-
 scripts/qapi/source.py                    |  22 +-
 tests/qapi-schema/leading-comma-list.err  |   2 +-
 tests/qapi-schema/trailing-comma-list.err |   2 +-
 10 files changed, 301 insertions(+), 193 deletions(-)
 create mode 100644 scripts/qapi/pragma.py
Signature · 1 line
2.26.2