Skip to content

net: dsa: b53: Configure VLANs while not filtering

Florian Fainelli lkml netdev 3 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 13 repliesIn review
  2. v22 patches 5 repliesSuperseded
  3. v12 patches 2 repliesSuperseded

Changes in v3 from the cover letter

- added Vladimir's Acked-by tag to patch #2
- removed unnecessary if_vlan.h inclusion in patch #2
- reworded commit message to be accurate with the code changes

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2net: dsa: untag the bridge pvid from rx skbsnet/dsa/dsa_priv.h+66 -012 replies
2/2net: dsa: b53: Configure VLANs while not filteringdrivers/net/dsa/b53/b53_common.c drivers/net/dsa/b53/b53_priv.h net/dsa/tag_brcm.c+15 -200 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchVladimir Oltean
1/2
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH net-next v3 0/2] net: dsa: b53: Configure VLANs while not filtering

Hi David, Jakub,

These two patches allow the b53 driver which always configures its CPU port as egress tagged to behave correctly with VLANs being always configured whenever a port is added to a bridge.

Vladimir provides a patch that aligns the bridge with vlan_filtering=0 receive path to behave the same as vlan_filtering=1. Per discussion with Nikolay, this behavior is deemed to be too DSA specific to be done in the bridge proper.

This is a preliminary series for Vladimir to make configure_vlan_while_filtering the default behavior for all DSA drivers in the future.

Thanks!

Changes in v3:

- added Vladimir's Acked-by tag to patch #2
- removed unnecessary if_vlan.h inclusion in patch #2
- reworded commit message to be accurate with the code changes

Changes in v2:

- moved the call to dsa_untag_bridge_pvid() into net/dsa/tag_brcm.c since we have a single user for now

Florian Fainelli (1):
net: dsa: b53: Configure VLANs while not filtering

Vladimir Oltean (1):
net: dsa: untag the bridge pvid from rx skbs

 drivers/net/dsa/b53/b53_common.c | 19 +--------
 drivers/net/dsa/b53/b53_priv.h   |  1 -
 net/dsa/dsa_priv.h               | 66 ++++++++++++++++++++++++++++++++
 net/dsa/tag_brcm.c               | 15 +++++++-
 4 files changed, 81 insertions(+), 20 deletions(-)
Signature · 1 line
2.25.1