Skip to content

qemu/bswap: Use compiler __builtin_bswap()

Philippe Mathieu-Daudé qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 14 repliesIn review
  2. v14 patches 10 repliesSuperseded

Changes in v2 from the cover letter

- Remove the Haiku/BSD ifdef'ry (Peter)
- Include the Haiku VM image from Alexander

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8qemu/bswap: Remove unused qemu_bswap_len()include/qemu/bswap.h+0 -60 replies
2/8qemu/bswap: Replace bswapXX() by compiler __builtin_bswap()include/qemu/bswap.h+7 -260 replies
3/8qemu/bswap: Replace bswapXXs() by compiler __builtin_bswap()include/qemu/bswap.h+9 -71 reply
4/8qemu/bswap: Remove <byteswap.h> dependencyconfigure include/qemu/bswap.h+0 -300 replies
5/8qemu/bswap: Use compiler __builtin_bswap() on Haikuinclude/qemu/bswap.h+0 -26 replies
6/8qemu/bswap: Use compiler __builtin_bswap() on FreeBSDinclude/qemu/bswap.h+0 -24 replies
7/8qemu/bswap: Use compiler __builtin_bswap() on NetBSDconfigure include/qemu/bswap.h+0 -203 replies
8/8tests/vm: Add Haiku test based on their vagrant imagestests/keys/vagrant tests/keys/vagrant.pub tests/vm/Makefile.include +2 more+149 -30 replies

Reviews trailers per patch

5 of 8 patches have a Reviewed-by or Acked-by.

PatchRichard HendersonEd Maste
1/8R-b
2/8R-b
3/8R-b
4/8R-b
5/8
6/8R-b
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/8] qemu/bswap: Use compiler __builtin_bswap()

Implement Richard's suggestion to use __builtin_bswap().

const_XX() not updated. We could use le_bswap() definitions but they are undefined, not sure yet what is the best way. Meanwhile I figure this out, these patches are ready for review.

Since v1:
- Remove the Haiku/BSD ifdef'ry (Peter)
- Include the Haiku VM image from Alexander

Alexander von Gluck IV (1):
tests/vm: Add Haiku test based on their vagrant images

Philippe Mathieu-Daudé (7):
qemu/bswap: Remove unused qemu_bswap_len() qemu/bswap: Replace bswapXX() by compiler __builtin_bswap() qemu/bswap: Replace bswapXXs() by compiler __builtin_bswap() qemu/bswap: Remove <byteswap.h> dependency qemu/bswap: Use compiler __builtin_bswap() on Haiku qemu/bswap: Use compiler __builtin_bswap() on FreeBSD qemu/bswap: Use compiler __builtin_bswap() on NetBSD

 configure                 |  28 ---------
 include/qemu/bswap.h      |  79 +++++---------------------
 tests/keys/vagrant        |  27 +++++++++
 tests/keys/vagrant.pub    |   1 +
 tests/vm/Makefile.include |   3 +-
 tests/vm/basevm.py        |   5 +-
 tests/vm/haiku.x86_64     | 116 ++++++++++++++++++++++++++++++++++++++
 7 files changed, 164 insertions(+), 95 deletions(-)
 create mode 100644 tests/keys/vagrant
 create mode 100644 tests/keys/vagrant.pub
 create mode 100755 tests/vm/haiku.x86_64
Signature · 1 line
2.26.2