Skip to content

virtio-mem: block size and address-assignment optimizations

David Hildenbrand qemu-devel 3 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 3 repliesApplied
  2. v25 patches 3 repliesSuperseded
  3. v15 patches 9 repliesSuperseded

v1 -> v2 from the cover letter

- Reordered patches to have fixes upfront
- Tweaked some patch descriptions
- "virtio-mem: Check that "memaddr" is multiples of the block size" -- Renamed to "virtio-mem: Make sure "addr" is always multiples of the block size"
- "virtio-mem: Make sure "usable_region_size" is always multiples of the block size"
-- Added

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/6virtio-mem: Make sure "addr" is always multiples of the block sizehw/virtio/virtio-mem.c+5 -00 replies
2/6virtio-mem: Make sure "usable_region_size" is always multiples of the block sizehw/virtio/virtio-mem.c+3 -00 replies
3/6virtio-mem: Probe THP size to determine default block sizehw/virtio/virtio-mem.c+101 -40 replies
4/6memory-device: Support big alignment requirementshw/mem/memory-device.c+5 -40 replies
5/6memory-device: Add get_min_alignment() callbackhw/mem/memory-device.c include/hw/mem/memory-device.h+19 -20 replies
6/6virito-mem: Implement get_min_alignment()hw/virtio/virtio-mem-pci.c+7 -00 replies

Reviews trailers per patch

5 of 6 patches have a Reviewed-by or Acked-by.

PatchPankaj Gupta
1/6R-b
2/6
3/6R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/6] virtio-mem: block size and address-assignment optimizations

Let's try to detect the actual THP size and use it as default block size (unless the page size of the backend indicates that THP don't apply). Always allow to set a block size of 1 MiB, but warn if the configured block size is smaller than the default. Handle large block sizes better, avoiding a virtio-spec violation and optimizing address auto-detection.

For existing setups (x86-64), the default block size won't change (was, and will be 2 MiB on anonymous memory). For existing x86-64 setups, the address auto-detection won't change in relevant setups (esp., anonymous memory and hugetlbfs with 2 MiB pages and no manual configuration of the block size). I don't see the need for compatibility handling (especially, as virtio-mem is still not considered production-ready).

Most of this is a preparation for future architectures, using hugetlbfs to full extend, and using manually configured, larger block sizes (relevant for vfio in the future).

v1 -> v2:
- Reordered patches to have fixes upfront
- Tweaked some patch descriptions
- "virtio-mem: Check that "memaddr" is multiples of the block size" -- Renamed to "virtio-mem: Make sure "addr" is always multiples of the block size"
- "virtio-mem: Make sure "usable_region_size" is always multiples of the block size"
-- Added

v1 -> v2:
- Tweak some patch descriptions
- "virtio-mem: Probe THP size to determine default block size"
-- Beautify THP detection a bit.
-- Assume THP might only get used if the memory backend page size corresponds
to the real hostpage size.
-- Use virtio_mem_default_block_size(RAMBlock *rb) to handle selection
of the default block size for a RAMBlock.
-- Implement virtio_mem_get_block_size() as preparation for patch #5
- "memory-device: Add get_min_alignment() callback"
-- Simplify documentation.
- "virito-mem: Implement get_min_alignment()"
-- Simplify due to changes in patch #1.

David Hildenbrand (6):
virtio-mem: Make sure "addr" is always multiples of the block size
virtio-mem: Make sure "usable_region_size" is always multiples of the
block size
virtio-mem: Probe THP size to determine default block size
memory-device: Support big alignment requirements
memory-device: Add get_min_alignment() callback
virito-mem: Implement get_min_alignment()

 hw/mem/memory-device.c         |  20 ++++--
 hw/virtio/virtio-mem-pci.c     |   7 ++
 hw/virtio/virtio-mem.c         | 113 +++++++++++++++++++++++++++++++--
 include/hw/mem/memory-device.h |  10 +++
 4 files changed, 140 insertions(+), 10 deletions(-)
Signature · 1 line
2.26.2