Skip to content

efi: deprecate/remove efivars sysfs interface

Ard Biesheuvel linux-efi lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7efi: pstore: disentangle from deprecated efivars moduledrivers/firmware/efi/Kconfig drivers/firmware/efi/efi-pstore.c drivers/firmware/efi/efivars.c +1 more+74 -495 replies
2/7efi: pstore: move workqueue handling out of efivarsdrivers/firmware/efi/efi-pstore.c drivers/firmware/efi/vars.c include/linux/efi.h+5 -260 replies
3/7efi: efivars: un-export efivars_sysfs_init()drivers/firmware/efi/efivars.c include/linux/efi.h+1 -60 replies
4/7efi: gsmi: fix false dependency on CONFIG_EFI_VARSdrivers/firmware/google/Kconfig drivers/firmware/google/gsmi.c+5 -50 replies
5/7efi: remove some false dependencies on CONFIG_EFI_VARSdrivers/firmware/efi/Kconfig+1 -20 replies
6/7efi: efivars: limit availability to X86 buildsDocumentation/arm/uefi.rst drivers/firmware/efi/Kconfig+5 -100 replies
7/7efi: efivars: remove deprecated sysfs interfaceDocumentation/ABI/stable/sysfs-firmware-efi-vars drivers/firmware/efi/Kconfig drivers/firmware/efi/Makefile +2 more+0 -7660 replies

Reviews trailers per patch

1 of 7 patches has a Reviewed-by or Acked-by.

PatchKees Cook
1/7A-b
2/7
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/7] efi: deprecate/remove efivars sysfs interface

This series implements the deprecation and ultimate removal of the sysfs interface that exposes the contents of the EFI variable store.

I am fully aware that removing this sysfs interface entirely may be premature, and so patch #7 is included for reference only, and not proposed for inclusion right away.

Instead, patch #6 limits availability of the efivars module to X86 and IA64, which is reasonable, given that the efivars module was superseded by the efivarfs filesystem interface before EFI support for ARM architectures was even available in Linux.

Patches #1 to #5 remove all dependencies [true or false] on the efivars.c code and its CONFIG_EFI_VARS Kconfig symbol, so it can be disabled [or dropped] cleanly.

Cc Matthew Garrett <[email protected]>
Cc Peter Jones <[email protected]>
Cc Kees Cook <[email protected]>
Cc Anton Vorontsov <[email protected]>
Cc Colin Cross <[email protected]>
Cc Tony Luck <[email protected]>

Ard Biesheuvel (7):
efi: pstore: disentangle from deprecated efivars module
efi: pstore: move workqueue handling out of efivars
efi: efivars: un-export efivars_sysfs_init()
efi: gsmi: fix false dependency on CONFIG_EFI_VARS
efi: remove some false dependencies on CONFIG_EFI_VARS
efi: efivars: limit availability to X86 builds
efi: efivars: remove deprecated sysfs interface

 .../ABI/stable/sysfs-firmware-efi-vars        |  75 --
 Documentation/arm/uefi.rst                    |   2 +-
 drivers/firmware/efi/Kconfig                  |  22 +-
 drivers/firmware/efi/Makefile                 |   1 -
 drivers/firmware/efi/efi-pstore.c             |  83 +-
 drivers/firmware/efi/efivars.c                | 711 ------------------
 drivers/firmware/efi/vars.c                   |  21 -
 drivers/firmware/google/Kconfig               |   2 +-
 drivers/firmware/google/gsmi.c                |   8 +-
 include/linux/efi.h                           |  18 -
 10 files changed, 85 insertions(+), 858 deletions(-)
 delete mode 100644 Documentation/ABI/stable/sysfs-firmware-efi-vars
 delete mode 100644 drivers/firmware/efi/efivars.c
Signature · 1 line
2.17.1