Skip to content

TTM move refactoring

Dave Airlie dri-devel 1 version NAK

Status from this message: NAK, completely unnecessary.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest45 patches 33 repliesNAK

Patches in v1

#Subject and filesSizeRepliesApplied
1/45drm/qxl: drop unused codedrivers/gpu/drm/qxl/qxl_ttm.c+0 -81 reply
2/45drm/ttm: handle the SYSTEM->TT path in same place as others.drivers/gpu/drm/ttm/ttm_bo.c+7 -101 reply
3/45drm/amdgpu/ttm: handle tt moves properly.drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c+7 -51 reply
4/45drm/radeon/ttm: handle ttm moves properlydrivers/gpu/drm/radeon/radeon_ttm.c+7 -51 reply
5/45drm/nouveau/ttm: handle ttm moves properly.drivers/gpu/drm/nouveau/nouveau_bo.c+12 -01 reply
6/45drm/vmwgfx: move null mem checks outside move notifiesdrivers/gpu/drm/vmwgfx/vmwgfx_bo.c drivers/gpu/drm/vmwgfx/vmwgfx_resource.c drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c+3 -41 reply
7/45drm/vmwgfx: add a move callback.drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c+18 -11 reply
8/45drm/vram_helper: implement a ttm move callback.drivers/gpu/drm/drm_gem_vram_helper.c+21 -01 reply
9/45drm/ttm: make move callback compulstorydrivers/gpu/drm/ttm/ttm_bo.c+1 -121 reply
10/45drm/ttm: refactor out common code to setup a new tt backed resourcedrivers/gpu/drm/ttm/ttm_bo.c drivers/gpu/drm/ttm/ttm_bo_util.c include/drm/ttm/ttm_bo_driver.h+29 -261 reply
11/45drm/ttm: split out the move to system from move ttm codedrivers/gpu/drm/ttm/ttm_bo_util.c+25 -141 reply
12/45drm/ttm: drop free old node wrapper.drivers/gpu/drm/ttm/ttm_bo_util.c include/drm/ttm/ttm_bo_driver.h+3 -171 reply
13/45drm/ttm: use new move interface for known system->ttm movesdrivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c drivers/gpu/drm/nouveau/nouveau_bo.c drivers/gpu/drm/radeon/radeon_ttm.c +1 more+7 -41 reply
14/45drm/ttm: add move old to system to drivers.drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c drivers/gpu/drm/nouveau/nouveau_bo.c drivers/gpu/drm/radeon/radeon_ttm.c +2 more+30 -51 reply
15/45drm/ttm: push copy unbind into drivers.drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c drivers/gpu/drm/nouveau/nouveau_bo.c drivers/gpu/drm/radeon/radeon_ttm.c+17 -41 reply
16/45drm/radeon/ttm: do move notify actions inside move.drivers/gpu/drm/radeon/radeon_object.c drivers/gpu/drm/radeon/radeon_object.h drivers/gpu/drm/radeon/radeon_ttm.c+30 -100 replies
17/45drm/amdgpu/ttm: handle invalidation in move callback.drivers/gpu/drm/amd/amdgpu/amdgpu_object.c drivers/gpu/drm/amd/amdgpu/amdgpu_object.h drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c+28 -220 replies
18/45drm/nouveau: handle move notify inside move callback.drivers/gpu/drm/nouveau/nouveau_bo.c+44 -181 reply
19/45drm/qxl/ttm: handle move notify inside move callbackdrivers/gpu/drm/qxl/qxl_ttm.c+7 -20 replies
20/45drm/vmwgfx/ttm: handle move notify inside move.drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c+8 -60 replies
21/45drm/vram_helper: call move notify from the move callback.drivers/gpu/drm/drm_gem_vram_helper.c+1 -00 replies
22/45drm/ttm: don't call move notify around movedrivers/gpu/drm/ttm/ttm_bo.c+1 -110 replies
23/45drm/ttm: move bind out of move_to_new_tt_memdrivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c drivers/gpu/drm/nouveau/nouveau_bo.c drivers/gpu/drm/radeon/radeon_ttm.c +2 more+26 -50 replies
24/45drm/ttm: handle binding in move callbackdrivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c drivers/gpu/drm/nouveau/nouveau_bo.c drivers/gpu/drm/radeon/radeon_ttm.c +2 more+29 -60 replies
25/45drm/ttm: don't call ttm_bo_move_ttm from driversdrivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c drivers/gpu/drm/nouveau/nouveau_bo.c drivers/gpu/drm/radeon/radeon_ttm.c +3 more+37 -470 replies
26/45drm/ttm: remove bind/unbind callbacks.drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c drivers/gpu/drm/nouveau/nouveau_bo.c drivers/gpu/drm/qxl/qxl_ttm.c +5 more+16 -931 reply
27/45drm/radeon/ttm: cleanup move exit pathsdrivers/gpu/drm/radeon/radeon_ttm.c+9 -100 replies
28/45drm/nouveau/ttm: memcpy waits for bo alreadydrivers/gpu/drm/nouveau/nouveau_bo.c+1 -30 replies
29/45drm/ttm: don't expose move old to system helper to drivers.drivers/gpu/drm/ttm/ttm_bo_util.c include/drm/ttm/ttm_bo_driver.h+0 -240 replies
30/45drm/ttm: add a new invalidate notify callback.drivers/gpu/drm/ttm/ttm_bo.c include/drm/ttm/ttm_bo_driver.h+10 -14 replies
31/45drm/radeon: switch to invalidate notify callbackdrivers/gpu/drm/radeon/radeon_object.c drivers/gpu/drm/radeon/radeon_object.h drivers/gpu/drm/radeon/radeon_ttm.c+3 -100 replies
32/45drm/amdgpu/ttm: switch to invalidate notify callbackdrivers/gpu/drm/amd/amdgpu/amdgpu_object.c drivers/gpu/drm/amd/amdgpu/amdgpu_object.h drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c+4 -100 replies
33/45drm/nouveau/ttm: switch to invalidate notify callbackdrivers/gpu/drm/nouveau/nouveau_bo.c+2 -70 replies
34/45drm/qxl/ttm: move to invalidate notify callbackdrivers/gpu/drm/qxl/qxl_ttm.c+3 -50 replies
35/45drm/vram-helper: move to invalidate callback.drivers/gpu/drm/drm_gem_vram_helper.c+6 -101 reply
36/45drm/ttm: drop move_notify callback.drivers/gpu/drm/ttm/ttm_bo.c include/drm/ttm/ttm_bo_driver.h+0 -130 replies
37/45drm/ttm: add a helper to allocate a temp tt for copies.drivers/gpu/drm/ttm/ttm_bo.c include/drm/ttm/ttm_bo_driver.h+33 -09 replies
38/45drm/nouveau/ttm: use helper to allocate tt tempdrivers/gpu/drm/nouveau/nouveau_bo.c+3 -270 replies
39/45drm/radeon/ttm: use new helper to create tmp ttdrivers/gpu/drm/radeon/radeon_ttm.c+2 -260 replies
40/45drm/amdgpu/ttm: use new ttm helper to create temp ttdrivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c+2 -270 replies
41/45drm/amdgpu/ttm: use helper function for caching/populatedrivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c+1 -60 replies
42/45drm/radeon/ttm: use helper function for caching/populatedrivers/gpu/drm/radeon/radeon_ttm.c+1 -70 replies
43/45drm/nouveau/ttm: use helper for placement + populaatedrivers/gpu/drm/nouveau/nouveau_bo.c+1 -10 replies
44/45drm/ttm: move more functionality into helper function.drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c drivers/gpu/drm/nouveau/nouveau_bo.c drivers/gpu/drm/radeon/radeon_ttm.c +1 more+4 -250 replies
45/45drm/ttm: add a new helper for a cleaning up after a ram movedrivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c drivers/gpu/drm/nouveau/nouveau_bo.c drivers/gpu/drm/radeon/radeon_ttm.c +2 more+25 -330 replies

Reviews trailers per patch

11 of 45 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchChristian KönigBen Skeggs
SeriesR-b
1/45
2/45
3/45R-b
4/45R-b
5/45A-b
6/45A-b
7/45
8/45A-b
9/45R-b
10/45R-b
11/45
12/45R-b
13/45
14/45R-b
15/45R-b
16/45
17/45
18/45
19/45
20/45
21/45
22/45
23/45
24/45
25/45
26/45R-b
27/45
28/45
29/45
30/45
31/45
32/45
33/45
34/45
35/45
36/45
37/45
38/45
39/45
40/45
41/45
42/45
43/45
44/45
45/45

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/45] TTM move refactoring

This refactors how TTM moves get called between core and drivers.

1) puts the driver in charge of all moves, and enforces drivers have a move callback.
2) moves move_notify actions around moves to the driver side
3) moves binding/unbinding completely into move and driver side
4) add a new invalidate callback to replace the last use of move_notify
5) add some helpers to cleanup the resulting move code

There's a bit of internal churn to try and make each patch logical, so don't get too caught up in each patches changes unless the end result is a problem.

Dave.

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel