Skip to content

multipath-tools: add linker version scripts

[email protected] dm-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest12 patches 2 repliesIn review
  2. v111 patches 11 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12libmultipath: find_mpe(): don't match with empty WWIDlibmultipath/config.c+1 -10 replies
2/12libmultipath: copy mpp->hwe from pp->hwelibmultipath/configure.c libmultipath/propsel.c libmultipath/structs.c +3 more+46 -450 replies
3/12libmultipath: dm_map_present_by_uuid(): fix dm_task_create() calllibmultipath/devmapper.c+1 -10 replies
4/12libdmmp tests: fix compilationlibdmmp/test/libdmmp_speed_test.c libdmmp/test/libdmmp_test.c+2 -20 replies
5/12libmultipath: prio: constify some function parameterslibmultipath/prio.c libmultipath/prio.h+4 -40 replies
6/12libmultipath: checkers/prio: allow non-lazy .so loadinglibmultipath/checkers.c libmultipath/prio.c+39 -00 replies
7/12multipath-tools Makefiles: separate rules for .so and man pageslibmpathcmd/Makefile libmpathpersist/Makefile libmultipath/Makefile+17 -90 replies
8/12libmultipath: create separate .so for unit testslibmultipath/Makefile tests/Makefile+13 -41 reply
9/12libmultipath: add linker version scriptlibmultipath/Makefile libmultipath/libmultipath.version+253 -20 replies
10/12libmpathpersist: add linker version scriptlibmpathpersist/Makefile libmpathpersist/libmpathpersist.version+36 -20 replies
11/12libmpathcmd: add linker version scriptlibmpathcmd/Makefile libmpathcmd/libmpathcmd.version+29 -20 replies
12/12libmpathpersist: initialize mpp->hwe in get_mpvec()libmpathpersist/mpath_persist.c+4 -21 reply

Reviews trailers per patch

All 12 patches have a Reviewed-by or Acked-by.

PatchBenjamin Marzinski
1/12R-b
2/12R-b
3/12R-b
4/12R-b
5/12R-b
6/12R-b
7/12R-b
8/12R-b
9/12R-b
10/12R-b
11/12R-b
12/12R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [dm-devel] [PATCH v2 00/12] multipath-tools: add linker version scripts

From: Martin Wilck <[email protected]>

Hi Christophe, hi Ben,

Patch 1-5 are small fixes, the first two resent from an earlier submission. Patch 6ff. add version scripts for the linker to libmultipath, libmpathpersist, and libmpathcmd.
(new in v2: versions start at 1.0.0 for all 3 libraries).

Is it useful to do this for libmultipath? We have always said that this is not a public, stable ABI. However, I still believe it has merits. First of all, it's a description of the ABI we use. It turns out that it cuts the size of the exported symbol list of libmultipath roughly in half, which is better than I'd expected. It leads to ld.so-time failure rather than weird crashes in the unlikely case that non-matching binaries are used together. It allows packaging scripts to check compatibility of binaries and libraries without resorting to version and release. It will help us stabilize the ABI, albeit only in the long run. Finally, it's a step towards modernizing our code base in general.

To avoid misunderstanding, my intention is not to provide a stable or even backward-compatible ABI in libmultipath.so.0. We're still allowed to make changes to globally visible data structures like "struct config", and to remove symbols from the ABI, like no serious shared library would do. We just need to bump the ABI version when we do so.

Changes v1->v2:

08/12: "libmultipath: create separate .so for unit tests"
fix test_clean rule (Ben)
9/12-11/12: Changed library versions from 0.8.4 to 1.0.0 as discussed with Ben,
kept Reviewed-by: trailer
12/12 "libmpathpersist: initialize mpp->hwe in get_mpvec()"
Fix for the issue mentioned by Ben in his review for 02/12 "libmultipath: copy mpp->hwe from pp->hwe"

Regards
Martin

Martin Wilck (12):
libmultipath: find_mpe(): don't match with empty WWID
libmultipath: copy mpp->hwe from pp->hwe
libmultipath: dm_map_present_by_uuid(): fix dm_task_create() call libdmmp tests: fix compilation
libmultipath: prio: constify some function parameters
libmultipath: checkers/prio: allow non-lazy .so loading multipath-tools Makefiles: separate rules for .so and man pages
libmultipath: create separate .so for unit tests
libmultipath: add linker version script
libmpathpersist: add linker version script
libmpathcmd: add linker version script
libmpathpersist: initialize mpp->hwe in get_mpvec()

 libdmmp/test/libdmmp_speed_test.c       |   2 +-
 libdmmp/test/libdmmp_test.c             |   2 +-
 libmpathcmd/Makefile                    |  14 +-
 libmpathcmd/libmpathcmd.version         |  25 +++
 libmpathpersist/Makefile                |  16 +-
 libmpathpersist/libmpathpersist.version |  32 +++
 libmpathpersist/mpath_persist.c         |   6 +-
 libmultipath/Makefile                   |  22 ++-
 libmultipath/checkers.c                 |  17 ++
 libmultipath/config.c                   |   2 +-
 libmultipath/configure.c                |   7 +
 libmultipath/devmapper.c                |   2 +-
 libmultipath/libmultipath.version       | 248 ++++++++++++++++++++++++
 libmultipath/prio.c                     |  26 ++-
 libmultipath/prio.h                     |   4 +-
 libmultipath/propsel.c                  |   4 +-
 libmultipath/structs.c                  |  15 ++
 libmultipath/structs.h                  |   1 +
 libmultipath/structs_vec.c              |  54 +++---
 multipathd/main.c                       |  10 -
 tests/Makefile                          |  10 +-
 21 files changed, 445 insertions(+), 74 deletions(-)
 create mode 100644 libmpathcmd/libmpathcmd.version
 create mode 100644 libmpathpersist/libmpathpersist.version
 create mode 100644 libmultipath/libmultipath.version
Signature · 7 lines
2.28.0


--
dm-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/dm-devel