Skip to content

PCI: dwc: improve msi handling

Jisheng Zhang linux-amlogic linux-arm-kernel linux-arm-msm linux-omap linux-pci linux-samsung-soc linux-tegra lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest5 patches 23 repliesIn review

Changes in v2 from the cover letter

- add proper error handling patches.
- solve the msi page leakage by moving dw_pcie_msi_init() from each users to designware host

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5PCI: dwc: Call dma_unmap_page() before freeing the msi pagedrivers/pci/controller/dwc/pcie-designware-host.c+5 -11 reply
2/5PCI: dwc: Check alloc_page() return valuedrivers/pci/controller/dwc/pcie-designware-host.c+5 -03 replies
3/5PCI: dwc: Rename dw_pcie_free_msi to dw_pcie_msi_deinitdrivers/pci/controller/dwc/pcie-designware-host.c drivers/pci/controller/dwc/pcie-designware.h+5 -51 reply
4/5PCI: dwc: Skip PCIE_MSI_INTR0* programming if MSI is disableddrivers/pci/controller/dwc/pcie-designware-host.c+1 -11 reply
5/5PCI: dwc: Move dw_pcie_msi_init() from each users to designware hostdrivers/pci/controller/dwc/pci-dra7xx.c drivers/pci/controller/dwc/pci-exynos.c drivers/pci/controller/dwc/pci-imx6.c +11 more+22 -553 replies

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchGustavo Pimentel
1/5A-b
2/5A-b
3/5A-b
4/5A-b
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/5] PCI: dwc: improve msi handling

Improve the msi code:
1. Add proper error handling.
2. Move dw_pcie_msi_init() from each users to designware host to solve msi page leakage in resume path.

Since v1:
- add proper error handling patches.
- solve the msi page leakage by moving dw_pcie_msi_init() from each users to designware host

Jisheng Zhang (5):
PCI: dwc: Call dma_unmap_page() before freeing the msi page
PCI: dwc: Check alloc_page() return value
PCI: dwc: Rename dw_pcie_free_msi to dw_pcie_msi_deinit
PCI: dwc: Skip PCIE_MSI_INTR0* programming if MSI is disabled
PCI: dwc: Move dw_pcie_msi_init() from each users to designware host

 drivers/pci/controller/dwc/pci-dra7xx.c       |  1 +
 drivers/pci/controller/dwc/pci-exynos.c       |  2 -
 drivers/pci/controller/dwc/pci-imx6.c         |  3 --
 drivers/pci/controller/dwc/pci-meson.c        |  8 ----
 drivers/pci/controller/dwc/pcie-artpec6.c     | 10 -----
 .../pci/controller/dwc/pcie-designware-host.c | 43 +++++++++++++------
 .../pci/controller/dwc/pcie-designware-plat.c |  3 --
 drivers/pci/controller/dwc/pcie-designware.h  |  9 +++-
 drivers/pci/controller/dwc/pcie-histb.c       |  3 --
 drivers/pci/controller/dwc/pcie-kirin.c       |  3 --
 drivers/pci/controller/dwc/pcie-qcom.c        |  3 --
 drivers/pci/controller/dwc/pcie-spear13xx.c   |  1 -
 drivers/pci/controller/dwc/pcie-tegra194.c    |  2 -
 drivers/pci/controller/dwc/pcie-uniphier.c    |  9 +---
 14 files changed, 38 insertions(+), 62 deletions(-)
Signature · 1 line
2.28.0