Clean-up around get_x_ish()
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 8 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | t8013: minimum preparatory clean-upt/ | +11 | 0 replies | |
| 2/4 | blame: validate and peel the object names on the ignore listbuiltin/ oidset.c oidset.h +1 more | +69 | 8 replies | |
| 3/4 | t1506: rev-parse A..B and A...Bt/ | +18 | 0 replies | |
| 4/4 | sequencer: stop abbreviating stopped-sha filesequencer.c | +6 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/4] Clean-up around get_x_ish()
Here is to clean some code I noticed while auditing the use of get_committish() and get_treeish() API functions.
The main topic is to tighten error checking of "blame --ignore-rev" and "blame --ignore-revs-list" arguments, which were not checked all that much. We make sure the ignore revs are committish objects, and also peel tags pointing at commits down to commits before using them. The breakage in the original is demonstrated by the tests added and/or tweaked in the second patch.
The last two patches are icing on the cake.
Junio C Hamano (4):
t8013: minimum preparatory clean-up
blame: validate and peel the object names on the ignore list
t1506: rev-parse A..B and A...B
sequencer: stop abbreviating stopped-sha file
builtin/blame.c | 27 +++++++++++++-- oidset.c | 9 ++++- oidset.h | 9 +++++ sequencer.c | 11 +++--- t/t1506-rev-parse-diagnosis.sh | 18 ++++++++++ t/t8013-blame-ignore-revs.sh | 61 ++++++++++++++++++++++------------ 6 files changed, 105 insertions(+), 30 deletions(-)
Signature · 1 line
2.28.0-718-gd8d5e3da39