Skip to content

PCI: dwc: fix two MSI issues

Jisheng Zhang linux-arm-kernel linux-omap linux-pci lkml 5 versions – Applied

Status from this message: Applied to pci/dwc, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest2 patches 7 repliesApplied
  2. v62 patches 0 repliesSuperseded
  3. v52 patches 3 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v42 patches0 repliesSuperseded
v32 patches3 repliesSuperseded

Changes in v7 from the cover letter

- Keep the IS_ENABLED(CONFIG_PCI_MSI) check in dw_pcie_msi_init().

Patches in v7 Applied

#Subject and filesSizeRepliesApplied
1/2PCI: dwc: Skip PCIE_MSI_INTR0* programming if MSI is disableddrivers/pci/controller/dwc/pcie-designware-host.c+1 -10 replies
2/2PCI: dwc: Fix MSI page leakage in suspend/resumedrivers/pci/controller/dwc/pci-dra7xx.c drivers/pci/controller/dwc/pcie-designware-host.c drivers/pci/controller/dwc/pcie-designware.h+36 -176 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchRob HerringGustavo Pimentel
1/2R-b A-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 0/2] PCI: dwc: fix two MSI issues

Fix two MSI issues. One to skip PCIE_MSI_INTR0* programming if MSI is disabled, another to use an address in the driver data for MSI address, to fix the MSI page leakage during suspend/resume.

Since v6:
- Keep the IS_ENABLED(CONFIG_PCI_MSI) check in dw_pcie_msi_init().

Since v5:
- rebase on pci/dwc branch
- add Acked-by tag

Since v4:
- fix pci-dra7xx.c

Since v3:
- add Acked-by tag
- change patch2 commit msg to make it clear
- map the MSI msg with dma_map_single_attrs() for some platforms which either has separate addrs for dma and phy or has mem access limitation for the PCIe.

Since v2:
- add Acked-by tag
- use an address in the driver data for MSI address. Thank Ard and Rob for pointing out this correct direction.
- Since the MSI page has gone, the leak issue doesn't exist anymore, remove unnecessary patches.
- Remove dw_pcie_free_msi rename and the last patch. They could be targeted to next. So will send out patches in a separate series.

Since v1:
- add proper error handling patches.
- solve the msi page leakage by moving dw_pcie_msi_init() from each users to designware host

Jisheng Zhang (2):
PCI: dwc: Skip PCIE_MSI_INTR0* programming if MSI is disabled
PCI: dwc: Fix MSI page leakage in suspend/resume

 drivers/pci/controller/dwc/pci-dra7xx.c       | 18 +++++++++-
 .../pci/controller/dwc/pcie-designware-host.c | 35 ++++++++++---------
 drivers/pci/controller/dwc/pcie-designware.h  |  2 +-
 3 files changed, 37 insertions(+), 18 deletions(-)
Signature · 1 line
2.28.0