Skip to content

simplify TCP loss marking code

Yuchung Cheng netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4tcp: consistently check retransmit hintnet/ipv4/tcp_input.c net/ipv4/tcp_recovery.c+3 -80 replies
2/4tcp: move tcp_mark_skb_lostnet/ipv4/tcp_input.c net/ipv4/tcp_recovery.c+14 -140 replies
3/4tcp: simplify tcp_mark_skb_lostnet/ipv4/tcp_input.c+22 -370 replies
4/4tcp: consolidate tcp_mark_skb_lost and tcp_skb_mark_lostnet/ipv4/tcp_input.c+2 -120 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/4] simplify TCP loss marking code

The TCP loss marking is implemented by a set of intertwined subroutines. TCP has several loss detection algorithms (RACK, RFC6675/FACK, NewReno, etc) each calls a subset of these routines to mark a packet lost. This has led to various bugs (and fixes and fixes of fixes).

This patch set is to consolidate the loss marking code so all detection algorithms call the same routine tcp_mark_skb_lost().

Yuchung Cheng (4):
tcp: consistently check retransmit hint
tcp: move tcp_mark_skb_lost
tcp: simplify tcp_mark_skb_lost
tcp: consolidate tcp_mark_skb_lost and tcp_skb_mark_lost

 net/ipv4/tcp_input.c    | 60 +++++++++++++++--------------------------
 net/ipv4/tcp_recovery.c | 16 +----------
 2 files changed, 23 insertions(+), 53 deletions(-)
Signature · 1 line
2.28.0.681.g6f77f65b4e-goog