Skip to content

net: core: fix a lockdep splat in the dev_addr_list.

Taehee Yoo netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3net: core: add __netdev_upper_dev_unlink()net/core/dev.c+16 -100 replies
2/3net: core: introduce struct netdev_nested_priv for nested interface infrastructuredrivers/infiniband/core/cache.c drivers/infiniband/core/cma.c drivers/infiniband/core/roce_gid_mgmt.c +13 more+183 -950 replies
3/3net: core: add nested_level variable in net_deviceinclude/linux/netdevice.h net/core/dev.c net/core/dev_addr_lists.c+122 -270 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net 0/3] net: core: fix a lockdep splat in the dev_addr_list.

This patchset is to avoid lockdep splat.

When a stacked interface graph is changed, netif_addr_lock() is called recursively and it internally calls spin_lock_nested().
The parameter of spin_lock_nested() is 'dev->lower_level', this is called subclass.
The problem of 'dev->lower_level' is that while 'dev->lower_level' is being used as a subclass of spin_lock_nested(), its value can be changed. So, spin_lock_nested() would be called recursively with the same subclass value, the lockdep understands a deadlock.
In order to avoid this, a new variable is needed and it is going to be used as a parameter of spin_lock_nested().
The first and second patch is a preparation patch for the third patch. In the third patch, the problem will be fixed.

The first patch is to add __netdev_upper_dev_unlink(). An existed netdev_upper_dev_unlink() is renamed to __netdev_upper_dev_unlink(). and netdev_upper_dev_unlink() is added as an wrapper of this function.

The second patch is to add the netdev_nested_priv structure. netdev_walk_all_{ upper | lower }_dev() pass both private functions and "data" pointer to handle their own things.
At this point, the data pointer type is void *.
In order to make it easier to expand common variables and functions, this new netdev_nested_priv structure is added.

The third patch is to add a new variable 'nested_level' into the net_device structure.
This variable will be used as a parameter of spin_lock_nested() of dev->addr_list_lock.
Due to this variable, it can avoid lockdep splat.

Taehee Yoo (3):
net: core: add __netdev_upper_dev_unlink()
net: core: introduce struct netdev_nested_priv for nested interface
infrastructure
net: core: add nested_level variable in net_device

 drivers/infiniband/core/cache.c               |  10 +-
 drivers/infiniband/core/cma.c                 |   9 +-
 drivers/infiniband/core/roce_gid_mgmt.c       |   9 +-
 drivers/infiniband/ulp/ipoib/ipoib_main.c     |   9 +-
 drivers/net/bonding/bond_alb.c                |   9 +-
 drivers/net/bonding/bond_main.c               |  10 +-
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |  37 ++--
 .../net/ethernet/mellanox/mlxsw/spectrum.c    |  24 +--
 .../ethernet/mellanox/mlxsw/spectrum_router.c |  11 +-
 .../mellanox/mlxsw/spectrum_switchdev.c       |  10 +-
 drivers/net/ethernet/rocker/rocker_main.c     |   9 +-
 drivers/net/wireless/quantenna/qtnfmac/core.c |  10 +-
 include/linux/netdevice.h                     |  68 ++++++--
 net/bridge/br_arp_nd_proxy.c                  |  26 ++-
 net/bridge/br_vlan.c                          |  20 ++-
 net/core/dev.c                                | 164 +++++++++++++-----
 net/core/dev_addr_lists.c                     |  12 +-
 17 files changed, 318 insertions(+), 129 deletions(-)
Signature · 1 line
2.17.1