Skip to content

RFC tracing: support dynamic string field types for synthetic events

Axel Rasmussen lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest1 patch 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1tracing: support dynamic string field types for synthetic eventskernel/trace/trace_events_hist.c+12 -31 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/1] tracing: support dynamic string field types for synthetic events

Hi Steven and Tom,

In this thread: https://lkml.org/lkml/2020/9/17/1015 we discussed how to plumb dynamic strings into synthetic events. Tom, you proposed adding a new dynamic string type to synthetic event definition like "char foo[]".

I'm sending this patch because it may be simpler than implementing that (I'm not too familiar with the tracing infrastructure, apologies if this is not true), and in my testing it seems sufficient to address my use case. I tested both setting up a synthetic event as Steven described in the other thread, as well as doing an analogous thing with a small bpftrace program, and both work as expected with this patch.

This is because I happen to know there's an upper bound on the length of the string in question, so I can just define a "char memcg_path[256]" in the synthetic event, and I can be sure the string won't be truncated.

Let me know what you think. Happy to drop this and wait for Tom's suggested approach instead.

Axel Rasmussen (1):
tracing: support dynamic string field types for synthetic events

 kernel/trace/trace_events_hist.c | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

--
2.28.0.681.g6f77f65b4e-goog