Exposing backing-chain allocation over NBD
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest11 patches 16 repliesIn review
- v512 patches 18 repliesSuperseded
- v47 patches 15 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 6 patches | 3 replies | Superseded | |
| v2 | 5 patches | 10 replies | Superseded | |
| v1 | 3 patches | 10 replies | Superseded |
Changes in v6 from the cover letter
- rebase to master (mostly affects 8/11) [Vladimir]
- drop v5 1/12, and replace with new v6 1/11 [Markus]
- rearrange series to complete 'bitmaps' before 'allocation-depth'
- don't alter 'nbd-server-add' [Peter]
- simplify qemu:allocation-depth to just be an integer [Vladimir]
Patches in v6 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | block: Simplify QAPI_LIST_ADDblock.c | +1 | 2 replies | |
| 2/11 | qapi: Make QAPI_LIST_ADD() publicblock.c include/ | +10 | 0 replies | |
| 3/11 | nbd: Utilize QAPI_CLONE for type conversionblockdev-nbd.c | +6 | 0 replies | |
| 4/11 | nbd: Update qapi to support exporting multiple bitmapsblockdev-nbd.c docs/ nbd/ +2 more | +58 | 2 replies | |
| 5/11 | nbd: Simplify qemu bitmap context namenbd/ | +9 | 0 replies | |
| 6/11 | nbd: Refactor counting of metadata contextsnbd/ | +15 | 1 reply | |
| 7/11 | nbd: Allow export of multiple bitmaps for one devicenbd/ tests/ | +72 | 0 replies | |
| 8/11 | block: Return depth level during bdrv_is_allocated_aboveblock/ block/ block/ +2 more | +29 | 1 reply | |
| 9/11 | nbd: Add new qemu:allocation-depth metadata contextdocs/ include/ nbd/ | +89 | 1 reply | |
| 10/11 | nbd: Add 'qemu-nbd -A' to expose allocation depthblock/ docs/ nbd/ +6 more | +151 | 1 reply | |
| 11/11 | qapi: Use QAPI_LIST_ADD() where possibleblock/ chardev/ docs/ +25 more | +119 | 8 replies |
Reviews trailers per patch
All 11 patches have a Reviewed-by or Acked-by.
| Patch | Vladimir Sementsov-Ogievskiy | Markus Armbruster | David Gibson | Dr. David Alan Gilbert | Peter Krempa |
|---|---|---|---|---|---|
| 1/11 | R-b | R-b | |||
| 2/11 | R-b | R-b | |||
| 3/11 | R-b | R-b | |||
| 4/11 | R-b | R-b | |||
| 5/11 | R-b | ||||
| 6/11 | R-b | ||||
| 7/11 | R-b | ||||
| 8/11 | R-b | ||||
| 9/11 | R-b | ||||
| 10/11 | R-b | ||||
| 11/11 | A-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [PATCH v6 00/11] Exposing backing-chain allocation over NBD
v5 was here:
https://lists.gnu.org/archive/html/qemu-devel/2020-10/msg07124.html
Also available at:
https://repo.or.cz/qemu/ericb.git/shortlog/refs/tags/nbd-alloc-depth-v6
Since v5:
- rebase to master (mostly affects 8/11) [Vladimir]
- drop v5 1/12, and replace with new v6 1/11 [Markus]
- rearrange series to complete 'bitmaps' before 'allocation-depth'
- don't alter 'nbd-server-add' [Peter]
- simplify qemu:allocation-depth to just be an integer [Vladimir]
I want at least 1-7/11 in a pull request this week for 5.2 soft freeze, but it would also be nice to get the feature of 8-10/11 in as well. 11/11 is less important, but a nice followup to 2/11.
(Oh, and my KVM Forum presentation this Friday uses these patches ;)
Eric Blake (11):
block: Simplify QAPI_LIST_ADD
qapi: Make QAPI_LIST_ADD() public
nbd: Utilize QAPI_CLONE for type conversion
nbd: Update qapi to support exporting multiple bitmaps
nbd: Simplify qemu bitmap context name
nbd: Refactor counting of metadata contexts
nbd: Allow export of multiple bitmaps for one device
block: Return depth level during bdrv_is_allocated_above
nbd: Add new qemu:allocation-depth metadata context
nbd: Add 'qemu-nbd -A' to expose allocation depth
qapi: Use QAPI_LIST_ADD() where possible
docs/devel/writing-qmp-commands.txt | 13 +- docs/interop/nbd.txt | 23 ++- docs/system/deprecated.rst | 3 +- docs/tools/qemu-nbd.rst | 8 +- qapi/block-core.json | 7 +- qapi/block-export.json | 46 ++++-- block/coroutines.h | 6 +- hw/net/rocker/rocker_fp.h | 2 +- include/block/nbd.h | 8 +- include/qapi/util.h | 8 ++ block/io.c | 29 +++- block.c | 14 +- block/commit.c | 2 +- block/gluster.c | 19 +-- block/mirror.c | 2 +- block/nbd.c | 26 +++- block/stream.c | 2 +- blockdev-nbd.c | 19 +-- chardev/char.c | 21 ++- hw/core/machine.c | 6 +- hw/net/rocker/rocker.c | 8 +- hw/net/rocker/rocker_fp.c | 14 +- hw/net/virtio-net.c | 21 +-- migration/migration.c | 7 +- migration/postcopy-ram.c | 7 +- monitor/hmp-cmds.c | 11 +- nbd/server.c | 208 +++++++++++++++++++++------- qemu-img.c | 5 +- qemu-nbd.c | 30 ++-- qga/commands-posix.c | 13 +- qga/commands-win32.c | 17 +-- qga/commands.c | 6 +- qom/qom-qmp-cmds.c | 29 ++-- target/arm/helper.c | 6 +- target/arm/monitor.c | 13 +- target/i386/cpu.c | 6 +- target/mips/helper.c | 6 +- target/s390x/cpu_models.c | 12 +- tests/test-clone-visitor.c | 7 +- tests/test-qobject-output-visitor.c | 42 +++--- tests/test-visitor-serialization.c | 5 +- trace/qmp.c | 22 ++- ui/vnc.c | 21 +-- util/qemu-config.c | 14 +- target/ppc/translate_init.c.inc | 12 +- tests/qemu-iotests/291 | 6 +- tests/qemu-iotests/309 | 77 ++++++++++ tests/qemu-iotests/309.out | 22 +++ tests/qemu-iotests/group | 1 + 49 files changed, 542 insertions(+), 370 deletions(-) create mode 100755 tests/qemu-iotests/309 create mode 100644 tests/qemu-iotests/309.out
Signature · 1 line
2.29.0