Skip to content

Exposing backing-chain allocation over NBD

Eric Blake qemu-arm qemu-devel 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest11 patches 16 repliesIn review
  2. v512 patches 18 repliesSuperseded
  3. v47 patches 15 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v36 patches3 repliesSuperseded
v25 patches10 repliesSuperseded
v13 patches10 repliesSuperseded

Changes in v6 from the cover letter

- rebase to master (mostly affects 8/11) [Vladimir]
- drop v5 1/12, and replace with new v6 1/11 [Markus]
- rearrange series to complete 'bitmaps' before 'allocation-depth'
- don't alter 'nbd-server-add' [Peter]
- simplify qemu:allocation-depth to just be an integer [Vladimir]

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11block: Simplify QAPI_LIST_ADDblock.c+1 -12 replies
2/11qapi: Make QAPI_LIST_ADD() publicblock.c include/qapi/util.h+10 -120 replies
3/11nbd: Utilize QAPI_CLONE for type conversionblockdev-nbd.c+6 -90 replies
4/11nbd: Update qapi to support exporting multiple bitmapsblockdev-nbd.c docs/system/deprecated.rst nbd/server.c +2 more+58 -292 replies
5/11nbd: Simplify qemu bitmap context namenbd/server.c+9 -100 replies
6/11nbd: Refactor counting of metadata contextsnbd/server.c+15 -111 reply
7/11nbd: Allow export of multiple bitmaps for one devicenbd/server.c tests/qemu-iotests/291+72 -340 replies
8/11block: Return depth level during bdrv_is_allocated_aboveblock/commit.c block/coroutines.h block/io.c +2 more+29 -121 reply
9/11nbd: Add new qemu:allocation-depth metadata contextdocs/interop/nbd.txt include/block/nbd.h nbd/server.c+89 -121 reply
10/11nbd: Add 'qemu-nbd -A' to expose allocation depthblock/nbd.c docs/tools/qemu-nbd.rst nbd/server.c +6 more+151 -111 reply
11/11qapi: Use QAPI_LIST_ADD() where possibleblock/gluster.c chardev/char.c docs/devel/writing-qmp-commands.txt +25 more+119 -2468 replies

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by.

PatchVladimir Sementsov-OgievskiyMarkus ArmbrusterDavid GibsonDr. David Alan GilbertPeter Krempa
1/11R-b R-b
2/11R-b R-b
3/11R-b R-b
4/11R-b R-b
5/11R-b
6/11R-b
7/11R-b
8/11R-b
9/11R-b
10/11R-b
11/11A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v6 thread

Cover letter [PATCH v6 00/11] Exposing backing-chain allocation over NBD

v5 was here:
https://lists.gnu.org/archive/html/qemu-devel/2020-10/msg07124.html

Also available at:
https://repo.or.cz/qemu/ericb.git/shortlog/refs/tags/nbd-alloc-depth-v6

Since v5:
- rebase to master (mostly affects 8/11) [Vladimir]
- drop v5 1/12, and replace with new v6 1/11 [Markus]
- rearrange series to complete 'bitmaps' before 'allocation-depth'
- don't alter 'nbd-server-add' [Peter]
- simplify qemu:allocation-depth to just be an integer [Vladimir]

I want at least 1-7/11 in a pull request this week for 5.2 soft freeze, but it would also be nice to get the feature of 8-10/11 in as well. 11/11 is less important, but a nice followup to 2/11.

(Oh, and my KVM Forum presentation this Friday uses these patches ;)

Eric Blake (11):
block: Simplify QAPI_LIST_ADD
qapi: Make QAPI_LIST_ADD() public
nbd: Utilize QAPI_CLONE for type conversion
nbd: Update qapi to support exporting multiple bitmaps
nbd: Simplify qemu bitmap context name
nbd: Refactor counting of metadata contexts
nbd: Allow export of multiple bitmaps for one device
block: Return depth level during bdrv_is_allocated_above
nbd: Add new qemu:allocation-depth metadata context
nbd: Add 'qemu-nbd -A' to expose allocation depth
qapi: Use QAPI_LIST_ADD() where possible

 docs/devel/writing-qmp-commands.txt |  13 +-
 docs/interop/nbd.txt                |  23 ++-
 docs/system/deprecated.rst          |   3 +-
 docs/tools/qemu-nbd.rst             |   8 +-
 qapi/block-core.json                |   7 +-
 qapi/block-export.json              |  46 ++++--
 block/coroutines.h                  |   6 +-
 hw/net/rocker/rocker_fp.h           |   2 +-
 include/block/nbd.h                 |   8 +-
 include/qapi/util.h                 |   8 ++
 block/io.c                          |  29 +++-
 block.c                             |  14 +-
 block/commit.c                      |   2 +-
 block/gluster.c                     |  19 +--
 block/mirror.c                      |   2 +-
 block/nbd.c                         |  26 +++-
 block/stream.c                      |   2 +-
 blockdev-nbd.c                      |  19 +--
 chardev/char.c                      |  21 ++-
 hw/core/machine.c                   |   6 +-
 hw/net/rocker/rocker.c              |   8 +-
 hw/net/rocker/rocker_fp.c           |  14 +-
 hw/net/virtio-net.c                 |  21 +--
 migration/migration.c               |   7 +-
 migration/postcopy-ram.c            |   7 +-
 monitor/hmp-cmds.c                  |  11 +-
 nbd/server.c                        | 208 +++++++++++++++++++++-------
 qemu-img.c                          |   5 +-
 qemu-nbd.c                          |  30 ++--
 qga/commands-posix.c                |  13 +-
 qga/commands-win32.c                |  17 +--
 qga/commands.c                      |   6 +-
 qom/qom-qmp-cmds.c                  |  29 ++--
 target/arm/helper.c                 |   6 +-
 target/arm/monitor.c                |  13 +-
 target/i386/cpu.c                   |   6 +-
 target/mips/helper.c                |   6 +-
 target/s390x/cpu_models.c           |  12 +-
 tests/test-clone-visitor.c          |   7 +-
 tests/test-qobject-output-visitor.c |  42 +++---
 tests/test-visitor-serialization.c  |   5 +-
 trace/qmp.c                         |  22 ++-
 ui/vnc.c                            |  21 +--
 util/qemu-config.c                  |  14 +-
 target/ppc/translate_init.c.inc     |  12 +-
 tests/qemu-iotests/291              |   6 +-
 tests/qemu-iotests/309              |  77 ++++++++++
 tests/qemu-iotests/309.out          |  22 +++
 tests/qemu-iotests/group            |   1 +
 49 files changed, 542 insertions(+), 370 deletions(-)
 create mode 100755 tests/qemu-iotests/309
 create mode 100644 tests/qemu-iotests/309.out
Signature · 1 line
2.29.0