net: in_interrupt() cleanup and fixes
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest36 patches 7 repliesIn review
- v135 patches 18 repliesSuperseded
Changes in v2 from the cover letter
- Rebased to net-next
- Fixed the half done rename sillyness in the ENIC patch.
- Fixed the IONIC driver fallout.
- Picked up the SFC fix from Edward and adjusted the GFP_KERNEL change accordingly.
- Addressed the review comments vs. BCRFMAC.
- Collected Reviewed/Acked-by tags as appropriate.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/36 | net: enic: Cure the enic api locking trainwreckdrivers/ drivers/ drivers/ | +28 | 0 replies | |
| 2/36 | net: caif: Remove unused caif SPI driverDocumentation/ Documentation/ drivers/ +4 more | +0 | 0 replies | |
| 3/36 | net: Add netif_rx_any_context()include/ net/ | +16 | 0 replies | |
| 4/36 | net: caif: Use netif_rx_any_context()drivers/ | +2 | 0 replies | |
| 5/36 | net: atheros: Remove WARN_ON(in_interrupt())drivers/ drivers/ drivers/ | +0 | 0 replies | |
| 6/36 | net: cxgb3: Cleanup in_interrupt() usagedrivers/ drivers/ drivers/ | +29 | 0 replies | |
| 7/36 | net: cxbg4: Remove pointless in_interrupt() checkdrivers/ | +0 | 0 replies | |
| 8/36 | net: e100: Remove in_interrupt() usage and pointless GFP_ATOMIC allocationdrivers/ | +2 | 0 replies | |
| 9/36 | net: fec_mpc52xx: Replace in_interrupt() usagedrivers/ | +5 | 0 replies | |
| 10/36 | net: intel: Remove in_interrupt() warningsdrivers/ drivers/ drivers/ +5 more | +0 | 0 replies | |
| 11/36 | net: ionic: Replace in_interrupt() usage.drivers/ drivers/ drivers/ | +47 | 1 reply | |
| 12/36 | net: ionic: Remove WARN_ON(in_interrupt()).drivers/ | +0 | 0 replies | |
| 13/36 | net: mdiobus: Remove WARN_ON_ONCE(in_interrupt())drivers/ | +0 | 0 replies | |
| 14/36 | net: natsemi: Replace in_interrupt() usage.drivers/ drivers/ | +13 | 0 replies | |
| 15/36 | net: sfc: Replace in_interrupt() usagedrivers/ drivers/ drivers/ +1 more | +26 | 0 replies | |
| 16/36 | net: sfc: Use GFP_KERNEL in efx_ef10_try_update_nic_stats()drivers/ | +1 | 1 reply | |
| 17/36 | net: sunbmac: Replace in_interrupt() usagedrivers/ | +9 | 0 replies | |
| 18/36 | net: sun3lance: Remove redundant checks in interrupt handlerdrivers/ | +0 | 0 replies | |
| 19/36 | net: vxge: Remove in_interrupt() conditionalsdrivers/ drivers/ | +2 | 0 replies | |
| 20/36 | net: zd1211rw: Remove ZD_ASSERT(in_interrupt())drivers/ | +0 | 0 replies | |
| 21/36 | net: usb: kaweth: Replace kaweth_control() with usb_control_msg()drivers/ | +30 | 1 reply | |
| 22/36 | net: usb: kaweth: Remove last user of kaweth_control()drivers/ | +17 | 0 replies | |
| 23/36 | net: usb: net1080: Remove in_interrupt() commentdrivers/ | +0 | 0 replies | |
| 24/36 | net: wan/lmc: Remove lmc_trace()drivers/ drivers/ drivers/ +2 more | +8 | 0 replies | |
| 25/36 | net: brcmfmac: Replace in_interrupt()drivers/ drivers/ drivers/ | +5 | 0 replies | |
| 26/36 | net: brcmfmac: Convey execution context via argument to brcmf_netif_rx()drivers/ drivers/ drivers/ +7 more | +29 | 1 reply | |
| 27/36 | net: brcmfmac: Convey allocation mode as argumentdrivers/ drivers/ drivers/ +1 more | +13 | 1 reply | |
| 28/36 | net: ipw2x00,iwlegacy,iwlwifi: Remove in_interrupt() from debug macrosdrivers/ drivers/ drivers/ +2 more | +7 | 0 replies | |
| 29/36 | net: iwlwifi: Remove in_interrupt() from tracing macro.drivers/ drivers/ | +3 | 0 replies | |
| 30/36 | net: hostap: Remove in_interrupt() usagedrivers/ | +0 | 0 replies | |
| 31/36 | net: mwifiex: Use netif_rx_any_context().drivers/ drivers/ | +2 | 0 replies | |
| 32/36 | net: libertas libertas_tf: Remove in_interrupt() from debug macro.drivers/ drivers/ | +2 | 0 replies | |
| 33/36 | net: libertas: Use netif_rx_any_context()drivers/ | +2 | 1 reply | |
| 34/36 | net: rtlwifi: Remove void* casts related to delayed workdrivers/ drivers/ drivers/ +2 more | +31 | 0 replies | |
| 35/36 | net: rtlwifi: Remove in_interrupt() from debug macrodrivers/ drivers/ | +2 | 0 replies | |
| 36/36 | net: rtlwifi: Replace in_interrupt() for context detectiondrivers/ drivers/ drivers/ +3 more | +23 | 0 replies |
Reviews trailers per patch
21 of 36 patches have a Reviewed-by or Acked-by.
| Patch | Alexander Duyck | Shannon Nelson | Andrew Lunn | Martin Habets | Kalle Valo | Greg Kroah-Hartman | Arend van Spriel | Luca Coelho | James Cameron |
|---|---|---|---|---|---|---|---|---|---|
| 1/36 | |||||||||
| 2/36 | |||||||||
| 3/36 | |||||||||
| 4/36 | |||||||||
| 5/36 | |||||||||
| 6/36 | |||||||||
| 7/36 | |||||||||
| 8/36 | |||||||||
| 9/36 | |||||||||
| 10/36 | R-b | ||||||||
| 11/36 | A-b | ||||||||
| 12/36 | A-b | ||||||||
| 13/36 | R-b | ||||||||
| 14/36 | |||||||||
| 15/36 | R-b | ||||||||
| 16/36 | A-b | ||||||||
| 17/36 | |||||||||
| 18/36 | |||||||||
| 19/36 | |||||||||
| 20/36 | A-b | ||||||||
| 21/36 | R-b | ||||||||
| 22/36 | R-b | ||||||||
| 23/36 | |||||||||
| 24/36 | |||||||||
| 25/36 | A-b | R-b | |||||||
| 26/36 | R-b | ||||||||
| 27/36 | R-b | ||||||||
| 28/36 | A-b | ||||||||
| 29/36 | A-b | A-b | |||||||
| 30/36 | A-b | ||||||||
| 31/36 | A-b | ||||||||
| 32/36 | A-b | ||||||||
| 33/36 | A-b | R-b | |||||||
| 34/36 | A-b | ||||||||
| 35/36 | A-b | ||||||||
| 36/36 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 9 reviewers.
Cover letter [patch V2 00/36] net: in_interrupt() cleanup and fixes
Folks,
in the discussion about preempt count consistency accross kernel configurations:
https://lore.kernel.org/r/20200914204209.256266093 at linutronix.de/
Linus clearly requested that code in drivers and libraries which changes behaviour based on execution context should either be split up so that e.g. task context invocations and BH invocations have different interfaces or if that's not possible the context information has to be provided by the caller which knows in which context it is executing.
This includes conditional locking, allocation mode (GFP_*) decisions and avoidance of code paths which might sleep.
In the long run, usage of 'preemptible, in_*irq etc.' should be banned from driver code completely.
This is the second version of the first batch of related changes. V1 can be found here:
https://lore.kernel.org/r/20200927194846.045411263 at linutronix.de
Changes vs. V1:
- Rebased to net-next
- Fixed the half done rename sillyness in the ENIC patch.
- Fixed the IONIC driver fallout.
- Picked up the SFC fix from Edward and adjusted the GFP_KERNEL change accordingly.
- Addressed the review comments vs. BCRFMAC.
- Collected Reviewed/Acked-by tags as appropriate.
The pile is also available from:
git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git net/cleanup
Thanks,
tglx
--- Documentation/networking/caif/spi_porting.rst | 229 -- b/Documentation/networking/caif/index.rst | 1 b/drivers/net/caif/Kconfig | 19 b/drivers/net/caif/Makefile | 4 b/drivers/net/caif/caif_hsi.c | 19 b/drivers/net/ethernet/amd/sun3lance.c | 11 b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 1 b/drivers/net/ethernet/atheros/atl1e/atl1e_main.c | 2 b/drivers/net/ethernet/atheros/atlx/atl2.c | 1 b/drivers/net/ethernet/chelsio/cxgb3/adapter.h | 1 b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c | 2 b/drivers/net/ethernet/chelsio/cxgb3/sge.c | 44 b/drivers/net/ethernet/chelsio/cxgb4/sge.c | 3 b/drivers/net/ethernet/cisco/enic/enic.h | 1 b/drivers/net/ethernet/cisco/enic/enic_api.c | 6 b/drivers/net/ethernet/cisco/enic/enic_main.c | 27 b/drivers/net/ethernet/freescale/fec_mpc52xx.c | 10 b/drivers/net/ethernet/intel/e100.c | 4 b/drivers/net/ethernet/intel/e1000/e1000_main.c | 1 b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 2 b/drivers/net/ethernet/intel/i40e/i40e_main.c | 4 b/drivers/net/ethernet/intel/ice/ice_main.c | 1 b/drivers/net/ethernet/intel/igb/igb_main.c | 1 b/drivers/net/ethernet/intel/igc/igc_main.c | 1 b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 1 b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 2 b/drivers/net/ethernet/natsemi/sonic.c | 24 b/drivers/net/ethernet/natsemi/sonic.h | 2 b/drivers/net/ethernet/neterion/vxge/vxge-config.c | 9 b/drivers/net/ethernet/neterion/vxge/vxge-config.h | 7 b/drivers/net/ethernet/pensando/ionic/ionic_dev.c | 2 b/drivers/net/ethernet/pensando/ionic/ionic_lif.c | 64 b/drivers/net/ethernet/pensando/ionic/ionic_lif.h | 2 b/drivers/net/ethernet/pensando/ionic/ionic_main.c | 4 b/drivers/net/ethernet/sfc/ef10.c | 24 b/drivers/net/ethernet/sfc/efx_common.c | 2 b/drivers/net/ethernet/sfc/net_driver.h | 5 b/drivers/net/ethernet/sfc/nic_common.h | 7 b/drivers/net/ethernet/sun/sunbmac.c | 18 b/drivers/net/phy/mdio_bus.c | 15 b/drivers/net/usb/kaweth.c | 261 -- b/drivers/net/usb/net1080.c | 1 b/drivers/net/wan/lmc/lmc_debug.c | 18 b/drivers/net/wan/lmc/lmc_debug.h | 1 b/drivers/net/wan/lmc/lmc_main.c | 105 - b/drivers/net/wan/lmc/lmc_media.c | 4 b/drivers/net/wan/lmc/lmc_proto.c | 16 b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcdc.c | 4 b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 4 b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bus.h | 3 b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 26 b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.h | 2 b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c | 8 b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.h | 7 b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c | 10 b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.h | 2 b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c | 7 b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/proto.h | 6 b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 8 b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.h | 2 b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 2 b/drivers/net/wireless/intel/ipw2x00/ipw2100.c | 3 b/drivers/net/wireless/intel/ipw2x00/ipw2200.h | 6 b/drivers/net/wireless/intel/ipw2x00/libipw.h | 3 b/drivers/net/wireless/intel/iwlegacy/common.h | 4 b/drivers/net/wireless/intel/iwlwifi/iwl-debug.c | 5 b/drivers/net/wireless/intel/iwlwifi/iwl-devtrace-msg.h | 6 b/drivers/net/wireless/intersil/hostap/hostap_hw.c | 12 b/drivers/net/wireless/marvell/libertas/defs.h | 3 b/drivers/net/wireless/marvell/libertas/rx.c | 11 b/drivers/net/wireless/marvell/libertas_tf/deb_defs.h | 3 b/drivers/net/wireless/marvell/mwifiex/uap_txrx.c | 6 b/drivers/net/wireless/marvell/mwifiex/util.c | 6 b/drivers/net/wireless/realtek/rtlwifi/base.c | 47 b/drivers/net/wireless/realtek/rtlwifi/base.h | 3 b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 12 b/drivers/net/wireless/realtek/rtlwifi/core.c | 6 b/drivers/net/wireless/realtek/rtlwifi/debug.c | 20 b/drivers/net/wireless/realtek/rtlwifi/debug.h | 8 b/drivers/net/wireless/realtek/rtlwifi/pci.c | 4 b/drivers/net/wireless/realtek/rtlwifi/ps.c | 27 b/drivers/net/wireless/realtek/rtlwifi/ps.h | 10 b/drivers/net/wireless/realtek/rtlwifi/wifi.h | 3 b/drivers/net/wireless/zydas/zd1211rw/zd_usb.c | 1 b/include/linux/netdevice.h | 1 b/net/core/dev.c | 15 drivers/net/caif/caif_spi.c | 874 ---------- drivers/net/caif/caif_spi_slave.c | 254 -- include/net/caif/caif_spi.h | 155 - 89 files changed, 354 insertions(+), 2234 deletions(-)