Skip to content

Start KernelShark v2 transformation

Yordan Karadzhov (VMware) linux-trace-devel 9 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest44 patches 1 replyIn review
  2. v7 posting 2/232 patches 2 repliesSuperseded
  3. v7 posting 1/211 of 32 patches 1 replySuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v627 patches4 repliesSuperseded
v520 patches0 repliesSuperseded
v420 patches14 repliesSuperseded
v320 patches9 repliesSuperseded
v220 patches26 repliesSuperseded
v115 patches5 repliesSuperseded

Changes in v8 from the cover letter

* In particular patch 6 splits the installation of the project in two components. This can be used to create two packages. One for the GUI and one "devel" package installing the headers. This patch are inspired by the talk "Deep CMake For Library Authors" presented at CppCon 2019 by Craig Scott.
https://crascit.com/2019/10/16/cppcon-2019-deep-cmake-for-library-authors/

* Patches 35-44 has been sent already, but as part of a separated patch-set.

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/44kernel-shark: Adopt trace-cmd API changessrc/libkshark.c src/plugins/sched_events.c+12 -120 replies
2/44kernel-shark: Use libtraceevent and libtracefsCMakeLists.txt build/FindTraceCmd.cmake build/FindTraceEvent.cmake +5 more+286 -950 replies
3/44kernel-shark: Add license informationLICENSES/GPL-2.0 LICENSES/LGPL-2.1+862 -00 replies
4/44kernel-shark: Change the CMake minimum version requiredCMakeLists.txt+1 -10 replies
5/44kernel-shark: Change default libraries install locationCMakeLists.txt src/CMakeLists.txt+25 -90 replies
6/44kernel-shark: Split the installation in two componentsCMakeLists.txt build/cmake_uninstall.sh build/install_gui.sh +3 more+65 -180 replies
7/44kernel-shark: Update READMEREADME+67 -620 replies
8/44kernel-shark: Define build target for JSONCCMakeLists.txt build/FindJSONC.cmake src/CMakeLists.txt+57 -180 replies
9/44kernel-shark: Use only signed types in kshark_entrysrc/libkshark.h+2 -20 replies
10/44kernel-shark: Add stream_id to kshark_entrysrc/libkshark.h+7 -40 replies
11/44kernel-shark: Introduce libkshark-hashsrc/CMakeLists.txt src/libkshark-hash.c src/libkshark.h+286 -00 replies
12/44kernel-shark: Introduce Data streamssrc/libkshark.h+199 -00 replies
13/44kernel-shark: Rename static methods in libksharksrc/libkshark.c+7 -70 replies
14/44kernel-shark: Add basic methods for Data streamssrc/libkshark.c src/libkshark.h+820 -00 replies
15/44kernel-shark: Housekeeping before implementing stream interfacesrc/libkshark.c src/libkshark.h+40 -1090 replies
16/44kernel-shark: Add stream interface for trace-cmd datasrc/CMakeLists.txt src/libkshark-tepdata.c src/libkshark-tepdata.h+1576 -00 replies
17/44kernel-shark: Start introducing KernelShark 2.0CMakeLists.txt build/deff.h.cmake examples/CMakeLists.txt +1 more+37 -470 replies
18/44kernel-shark: Start using data streamsexamples/dataload.c src/libkshark.c src/libkshark.h+166 -2210 replies
19/44kernel-shark: Remove dead codesrc/libkshark.c src/libkshark.h+8 -8870 replies
20/44kernel-shark: Redesign the plugin interfacesrc/libkshark-plugin.c src/libkshark-plugin.h src/libkshark.c +1 more+866 -1620 replies
21/44kernel-shark: Complete the stream integrationexamples/CMakeLists.txt examples/datafilter.c src/CMakeLists.txt +6 more+959 -3290 replies
22/44kernel-shark: Provide merging of multiple data streamsexamples/CMakeLists.txt examples/multibufferload.c src/libkshark.c +1 more+359 -00 replies
23/44kernel-shark: Integrate the stream definitions with data modelexamples/CMakeLists.txt examples/datahisto.c src/CMakeLists.txt +2 more+102 -820 replies
24/44kernel-shark: Use only signed types for model defssrc/libkshark-model.c src/libkshark-model.h+15 -150 replies
25/44kernel-shark: Add ksmodel_get_bin()src/libkshark-model.c src/libkshark-model.h+30 -00 replies
26/44kernel-shark: Protect ksmodel_set_in_range_bining()src/libkshark-model.c+12 -10 replies
27/44kernel-shark: Add methods for time calibrationsrc/libkshark-tepdata.c src/libkshark.c src/libkshark.h+138 -10 replies
28/44kernel-shark: Integrate streams with libkshark-configioexamples/CMakeLists.txt examples/configio.c src/CMakeLists.txt +2 more+1093 -2180 replies
29/44kernel-shark: Add support for drawing textCMakeLists.txt Documentation/doxygen/dox_config src/CMakeLists.txt +3 more+5324 -110 replies
30/44kernel-shark: Make GLUT optional dependencybuild/deff.h.cmake src/CMakeLists.txt src/libkshark-plot.c +1 more+23 -150 replies
31/44kernel-shark: Add ksplot_draw_polyline()src/libkshark-plot.c src/libkshark-plot.h+31 -60 replies
32/44kernel-shark: Optimize ksplot_draw_polygon()src/libkshark-plot.c+1 -100 replies
33/44kernel-shark: Add basic infrastructure for testingCMakeLists.txt build/cmake_clean.sh tests/CMakeLists.txt +1 more+75 -00 replies
34/44kernel-shark: Add "github Actions" workflow.github/workflows/main.yml+63 -00 replies
35/44kernel-shark: Integrate streams with KsPlotToolssrc/CMakeLists.txt src/KsPlotTools.cpp src/KsPlotTools.hpp+71 -310 replies
36/44kernel-shark: Add getStreamColorTable()src/KsPlotTools.cpp src/KsPlotTools.hpp+54 -00 replies
37/44kernel-shark: Redefine the args of KsPlot::getColor()src/KsPlotTools.cpp src/KsPlotTools.hpp+6 -60 replies
38/44kernel-shark: Add TextBox class to KsPlot namespacesrc/KsPlotTools.cpp src/KsPlotTools.hpp+139 -00 replies
39/44kernel-shark: Consistent method naming in KsPlotToolssrc/KsPlotTools.cpp src/KsPlotTools.hpp+32 -320 replies
40/44kernel-shark: Make the label part of the graphsrc/KsPlotTools.cpp src/KsPlotTools.hpp+40 -120 replies
41/44kernel-shark: Remove the hard-coded Idle PIDsrc/KsPlotTools.cpp src/KsPlotTools.hpp+44 -260 replies
42/44kernel-shark: Add class Polyline to KsPlot namespacesrc/KsPlotTools.cpp src/KsPlotTools.hpp+30 -00 replies
43/44kernel-shark: Add VirtBridge and VirtGap classessrc/KsPlotTools.cpp src/KsPlotTools.hpp+69 -00 replies
44/44kernel-shark: Add double click interface to PlotObjectsrc/KsPlotTools.cpp src/KsPlotTools.hpp+45 -00 replies

Reviews trailers per patch

None of the 44 patches has a Reviewed-by or Acked-by.

PatchYordan Karadzhov (VMware)
1/44
2/44
3/44
4/44
5/44
6/44
7/44
8/44
9/44
10/44
11/44
12/44
13/44
14/44
15/44
16/44
17/44
18/44
19/44
20/44
21/44
22/44
23/44Signen-off-by
24/44
25/44
26/44
27/44
28/44
29/44
30/44Signen-off-by
31/44
32/44
33/44
34/44
35/44
36/44
37/44
38/44
39/44
40/44
41/44
42/44
43/44
44/44

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v8 thread

Cover letter [PATCH v8 00/44] Start KernelShark v2 transformation

In this patch-set we are starting the introduction of the changes in the C API of libkshark. The goal of this transformation is to turn KernelShark into a general purpose toolkit for analysis of tracing data that is no longer strongly coupled to the Ftrace/trace-cmd data format. At the end of the transformation KernelShark will be able to merge and simultaneously visualize data from different tracers, recorded in different data formats. It will also significantly extend the possibilities for user customization.

This patch-set transforms the way KernelShark processes the raw tracing data. Later, in a consecutive patch-sets we will introduce the changes in the visualization instruments and in the KernelShark GUI itself.

Changes in v8:
* In particular patch 6 splits the installation of the project in two components. This can be used to create two packages. One for the GUI and one "devel" package installing the headers. This patch are inspired by the talk "Deep CMake For Library Authors" presented at CppCon 2019 by Craig Scott.
https://crascit.com/2019/10/16/cppcon-2019-deep-cmake-for-library-authors/

* Patches 35-44 has been sent already, but as part of a separated patch-set.

Changes in v7:
* Patches 1-5 are new, but these are only infrastructureal changes that have no functional effects on the API.
- License info is added.
- README is updated.
- KernelShark now builds and links against the stand-alone versions of libtraceevent and libtracefs.

Changes in v6:
* The patches from the "OpenGL wrapper" patch-set (already reviewed by Steven) have been added here (patches 21-24).

* Patches 25-27 are new, but these are only infrastructureal changes that have no functional effects on the API.

Changes in v5:
* Only minor modifications addressing issues pointed out by Steven in his reviews of v4.

Changes in v4:
* The integer data format identifier is replaced with a string value that gets registered by the readout plugin.

* Plus several small modifications addressing the issues pointed out by Steven.

Changes in v3.
This version contains number of small modifications addressing the issues pointed out by Steven in his review. However, it also contains the following major changes:

* The session context (kshark_context) holds a pointer to unspecified data processing interface (void *interface). This will allow to easily introduce new versions of this interface in the future, while keeping the interface that we have now for backward compatibility. The necessary type checking when using the interface made the helper functions wrapping the corresponding methods of the interface relatively complicated, so the implementations have been moved from the header to the source file.

* A more sophisticated management of the Data stream descriptors that can handle the case when Data streams are constantly added and removed has been implemented. The design for this change was suggested by Steven in his review.

Changes in v2:
* Tried to address review comments for "kernel-shark: Introduce libkshark-hash"

* The huge patch "kernel-shark: Integrate the stream definitions with
the C API" in the previous version is now split into 8 smaller patches. The last of these 8 new patches (kernel-shark: Complete the stream integration) is still a bit entangled. I can try to further break this patch in future versions of the patch-set, if this is needed.

Yordan Karadzhov (1):
kernel-shark: Add "github Actions" workflow

Yordan Karadzhov (VMware) (43):
kernel-shark: Adopt trace-cmd API changes
kernel-shark: Use libtraceevent and libtracefs
kernel-shark: Add license information
kernel-shark: Change the CMake minimum version required
kernel-shark: Change default libraries install location
kernel-shark: Split the installation in two components
kernel-shark: Update README
kernel-shark: Define build target for JSONC
kernel-shark: Use only signed types in kshark_entry
kernel-shark: Add stream_id to kshark_entry
kernel-shark: Introduce libkshark-hash
kernel-shark: Introduce Data streams
kernel-shark: Rename static methods in libkshark
kernel-shark: Add basic methods for Data streams
kernel-shark: Housekeeping before implementing stream interface
kernel-shark: Add stream interface for trace-cmd data
kernel-shark: Start introducing KernelShark 2.0
kernel-shark: Start using data streams
kernel-shark: Remove dead code
kernel-shark: Redesign the plugin interface
kernel-shark: Complete the stream integration
kernel-shark: Provide merging of multiple data streams
kernel-shark: Integrate the stream definitions with data model
kernel-shark: Use only signed types for model defs
kernel-shark: Add ksmodel_get_bin()
kernel-shark: Protect ksmodel_set_in_range_bining()
kernel-shark: Add methods for time calibration
kernel-shark: Integrate streams with libkshark-configio
kernel-shark: Add support for drawing text
kernel-shark: Make GLUT optional dependency
kernel-shark: Add ksplot_draw_polyline()
kernel-shark: Optimize ksplot_draw_polygon()
kernel-shark: Add basic infrastructure for testing
kernel-shark: Integrate streams with KsPlotTools
kernel-shark: Add getStreamColorTable()
kernel-shark: Redefine the args of KsPlot::getColor()
kernel-shark: Add TextBox class to KsPlot namespace
kernel-shark: Consistent method naming in KsPlotTools
kernel-shark: Make the label part of the graph
kernel-shark: Remove the hard-coded Idle PID
kernel-shark: Add class Polyline to KsPlot namespace
kernel-shark: Add VirtBridge and VirtGap classes
kernel-shark: Add double click interface to PlotObject

 .github/workflows/main.yml       |   63 +
 CMakeLists.txt                   |   55 +-
 Documentation/doxygen/dox_config |    1 +
 LICENSES/GPL-2.0                 |  359 +++
 LICENSES/LGPL-2.1                |  503 +++
 README                           |  129 +-
 build/FindJSONC.cmake            |   70 +-
 build/FindTraceCmd.cmake         |  138 +-
 build/FindTraceEvent.cmake       |   76 +
 build/FindTraceFS.cmake          |   76 +
 build/cmake_clean.sh             |    4 +
 build/cmake_uninstall.sh         |   23 +-
 build/deff.h.cmake               |   15 +-
 build/install_gui.sh             |    1 +
 build/install_libkshark-devel.sh |    1 +
 examples/CMakeLists.txt          |   34 +-
 examples/configio.c              |   20 +-
 examples/datafilter.c            |   67 +-
 examples/datahisto.c             |   38 +-
 examples/dataload.c              |   28 +-
 examples/multibufferload.c       |   53 +
 src/CMakeLists.txt               |   70 +-
 src/KsPlotTools.cpp              |  412 ++-
 src/KsPlotTools.hpp              |  199 +-
 src/libkshark-collection.c       |  121 +-
 src/libkshark-configio.c         | 1208 +++++--
 src/libkshark-hash.c             |  239 ++
 src/libkshark-model.c            |  154 +-
 src/libkshark-model.h            |   55 +-
 src/libkshark-plot.c             |  317 +-
 src/libkshark-plot.h             |   73 +
 src/libkshark-plugin.c           |  658 +++-
 src/libkshark-plugin.h           |  294 +-
 src/libkshark-tepdata.c          | 1914 ++++++++++++
 src/libkshark-tepdata.h          |  112 +
 src/libkshark.c                  | 2619 +++++++++-------
 src/libkshark.h                  |  704 ++++-
 src/plugins/CMakeLists.txt       |    3 +-
 src/plugins/sched_events.c       |    4 +-
 src/stb_truetype.h               | 5011 ++++++++++++++++++++++++++++++
 tests/CMakeLists.txt             |   14 +
 tests/libkshark-tests.cpp        |   48 +
 42 files changed, 13839 insertions(+), 2144 deletions(-)
 create mode 100644 .github/workflows/main.yml
 create mode 100644 LICENSES/GPL-2.0
 create mode 100644 LICENSES/LGPL-2.1
 create mode 100644 build/FindTraceEvent.cmake
 create mode 100644 build/FindTraceFS.cmake
 create mode 100755 build/install_gui.sh
 create mode 100755 build/install_libkshark-devel.sh
 create mode 100644 examples/multibufferload.c
 create mode 100644 src/libkshark-hash.c
 create mode 100644 src/libkshark-tepdata.c
 create mode 100644 src/libkshark-tepdata.h
 create mode 100644 src/stb_truetype.h
 create mode 100644 tests/CMakeLists.txt
 create mode 100644 tests/libkshark-tests.cpp
Signature · 1 line
2.25.1