qemu-storage-daemon: Remove QemuOpts from --object parser
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest4 patches 4 repliesIn review
- v24 patches 13 repliesSuperseded
- v14 patches 8 repliesSuperseded
Changes in v3 from the cover letter
- Always parse help options, no matter if the caller implements help or not. If it doesn't, return an error. [Markus]
- Document changes to the keyval parser grammar [Markus]
- Support both 'help' and '?' [Eric]
- Test case fixes [Eric]
- Improved documentation of user_creatable_print_help(_from_qdict) [Markus]
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | keyval: Parse help optionsinclude/ include/ qapi/ +3 more | +198 | 4 replies | |
| 2/4 | qom: Factor out helpers from user_creatable_print_help()qom/ | +52 | 0 replies | |
| 3/4 | qom: Add user_creatable_print_help_from_qdict()include/ qom/ | +27 | 0 replies | |
| 4/4 | qemu-storage-daemon: Remove QemuOpts from --object parserstorage-daemon/ | +4 | 0 replies |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | Eric Blake | Markus Armbruster |
|---|---|---|
| 1/4 | R-b | |
| 2/4 | R-b | R-b |
| 3/4 | R-b | R-b |
| 4/4 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/4] qemu-storage-daemon: Remove QemuOpts from --object parser
This replaces the QemuOpts-based help code for --object in the storage daemon with code based on the keyval parser.
v3:
- Always parse help options, no matter if the caller implements help or not. If it doesn't, return an error. [Markus]
- Document changes to the keyval parser grammar [Markus]
- Support both 'help' and '?' [Eric]
- Test case fixes [Eric]
- Improved documentation of user_creatable_print_help(_from_qdict) [Markus]
v2:
- Fixed double comma by reusing the existing key and value parsers [Eric]
- More tests to cover the additional cases
Kevin Wolf (4):
keyval: Parse help options
qom: Factor out helpers from user_creatable_print_help()
qom: Add user_creatable_print_help_from_qdict()
qemu-storage-daemon: Remove QemuOpts from --object parser
include/qemu/help_option.h | 5 + include/qemu/option.h | 2 +- include/qom/object_interfaces.h | 21 ++- qapi/qobject-input-visitor.c | 2 +- qom/object_interfaces.c | 99 ++++++++----- storage-daemon/qemu-storage-daemon.c | 15 +- tests/test-keyval.c | 205 +++++++++++++++++++-------- util/keyval.c | 54 ++++++- 8 files changed, 280 insertions(+), 123 deletions(-)
Signature · 1 line
2.25.4