Skip to content

qemu-storage-daemon: Remove QemuOpts from --object parser

Kevin Wolf qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 4 repliesIn review
  2. v24 patches 13 repliesSuperseded
  3. v14 patches 8 repliesSuperseded

Changes in v3 from the cover letter

- Always parse help options, no matter if the caller implements help or not. If it doesn't, return an error. [Markus]
- Document changes to the keyval parser grammar [Markus]
- Support both 'help' and '?' [Eric]
- Test case fixes [Eric]
- Improved documentation of user_creatable_print_help(_from_qdict) [Markus]

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4keyval: Parse help optionsinclude/qemu/help_option.h include/qemu/option.h qapi/qobject-input-visitor.c +3 more+198 -724 replies
2/4qom: Factor out helpers from user_creatable_print_help()qom/object_interfaces.c+52 -380 replies
3/4qom: Add user_creatable_print_help_from_qdict()include/qom/object_interfaces.h qom/object_interfaces.c+27 -30 replies
4/4qemu-storage-daemon: Remove QemuOpts from --object parserstorage-daemon/qemu-storage-daemon.c+4 -110 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchEric BlakeMarkus Armbruster
1/4R-b
2/4R-b R-b
3/4R-b R-b
4/4R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] qemu-storage-daemon: Remove QemuOpts from --object parser

This replaces the QemuOpts-based help code for --object in the storage daemon with code based on the keyval parser.

v3:
- Always parse help options, no matter if the caller implements help or not. If it doesn't, return an error. [Markus]
- Document changes to the keyval parser grammar [Markus]
- Support both 'help' and '?' [Eric]
- Test case fixes [Eric]
- Improved documentation of user_creatable_print_help(_from_qdict) [Markus]

v2:
- Fixed double comma by reusing the existing key and value parsers [Eric]
- More tests to cover the additional cases

Kevin Wolf (4):
keyval: Parse help options
qom: Factor out helpers from user_creatable_print_help()
qom: Add user_creatable_print_help_from_qdict()
qemu-storage-daemon: Remove QemuOpts from --object parser

 include/qemu/help_option.h           |   5 +
 include/qemu/option.h                |   2 +-
 include/qom/object_interfaces.h      |  21 ++-
 qapi/qobject-input-visitor.c         |   2 +-
 qom/object_interfaces.c              |  99 ++++++++-----
 storage-daemon/qemu-storage-daemon.c |  15 +-
 tests/test-keyval.c                  | 205 +++++++++++++++++++--------
 util/keyval.c                        |  54 ++++++-
 8 files changed, 280 insertions(+), 123 deletions(-)
Signature · 1 line
2.25.4