Skip to content

tpm_tis: fix interrupts (again)

James Bottomley linux-integrity 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 68 repliesIn review
  2. v14 patches 13 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5tpm_tis: Fix check_locality for correct locality acquisitiondrivers/char/tpm/tpm_tis_core.c+2 -16 replies
2/5tpm_tis: Clean up locality releasedrivers/char/tpm/tpm_tis_core.c+1 -469 replies
3/5tpm_tis: Fix interrupts for TIS TPMs without legacy cyclesdrivers/char/tpm/tpm_tis_core.c+101 -2410 replies
4/5tpm_tis: fix IRQ probingdrivers/char/tpm/tpm_tis_core.c+14 -013 replies
5/5Revert "tpm: Revert "tpm_tis_core: Turn on the TPM before probing IRQ's""drivers/char/tpm/tpm_tis_core.c+2 -03 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJames BottomleyJerry SnitselaarJarkko Sakkinen
SeriesR-b
1/5R-b
2/5R-b R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/5] tpm_tis: fix interrupts (again)

The current state of the TIS TPM is that interrupts have been globally disabled by various changes. The problems we got reported the last time they were enabled was interrupt storms. With my own TIS TPM, I've found that this is caused because my TPM doesn't do legacy cycles, The TIS spec (chapter 6.1 "Locality Usage Per Register") requires any TIS TPM without legacy cycles not to act on any write to an interrupt register unless the locality is enabled. This means if an interrupt fires after we relinquish the locality, the TPM_EOI in the interrupt routine is ineffective meaning the same interrupt triggers over and over again. This problem also means we can have trouble setting up interrupts on TIS TPMs because the current init code does the setup before the locality is claimed for the first time.

James

---

James Bottomley (5):
tpm_tis: Fix check_locality for correct locality acquisition
tpm_tis: Clean up locality release
tpm_tis: Fix interrupts for TIS TPMs without legacy cycles
tpm_tis: fix IRQ probing
Revert "tpm: Revert "tpm_tis_core: Turn on the TPM before probing

    IRQ's""
 drivers/char/tpm/tpm_tis_core.c | 185 ++++++++++++++++++++------------
 1 file changed, 117 insertions(+), 68 deletions(-)
Signature · 1 line
2.28.0