Skip to content

MPEG-2 stateless API cleanup and destaging

Ezequiel Garcia linux-media lkml 7 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest10 patches 0 repliesNew
  2. v610 patches 3 repliesSuperseded
  3. v510 patches 3 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v49 patches2 repliesSuperseded
v33 patches3 repliesSuperseded
v23 patches3 repliesSuperseded
v13 patches0 repliesSuperseded

Changes in v7 from the cover letter

* Fix padding in v4l2_ctrl_mpeg2_picture.
* Fix V4L2_MPEG2_SEQ_FLAG_PROGRESSIVE.

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10media: uapi: mpeg2: Rename "quantization" to "quantisation"Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst Documentation/userspace-api/media/v4l/pixfmt-compressed.rst Documentation/userspace-api/media/v4l/vidioc-queryctrl.rst +13 more+58 -630 replies
2/10media: uapi: mpeg2: rework quantisation matrices semanticsDocumentation/userspace-api/media/v4l/ext-ctrls-codec.rst drivers/media/v4l2-core/v4l2-ctrls.c drivers/staging/media/sunxi/cedrus/cedrus_mpeg2.c +1 more+28 -580 replies
3/10media: uapi: mpeg2: Cleanup flagsDocumentation/userspace-api/media/v4l/ext-ctrls-codec.rst drivers/media/v4l2-core/v4l2-ctrls.c drivers/staging/media/hantro/hantro_g1_mpeg2_dec.c +3 more+175 -1420 replies
4/10media: uapi: mpeg2: Split sequence and picture parametersDocumentation/userspace-api/media/v4l/ext-ctrls-codec.rst Documentation/userspace-api/media/v4l/pixfmt-compressed.rst Documentation/userspace-api/media/v4l/vidioc-queryctrl.rst +11 more+237 -750 replies
5/10media: uapi: mpeg2: Move reference buffer fieldsDocumentation/userspace-api/media/v4l/ext-ctrls-codec.rst drivers/staging/media/hantro/hantro_g1_mpeg2_dec.c drivers/staging/media/hantro/rk3399_vpu_hw_mpeg2_dec.c +2 more+28 -320 replies
6/10media: hantro/cedrus: Remove unneeded slice size and slice offsetdrivers/staging/media/hantro/hantro_g1_mpeg2_dec.c drivers/staging/media/hantro/rk3399_vpu_hw_mpeg2_dec.c drivers/staging/media/sunxi/cedrus/cedrus_mpeg2.c+7 -80 replies
7/10media: uapi: mpeg2: Remove V4L2_CID_MPEG_VIDEO_MPEG2_SLICE_PARAMSDocumentation/userspace-api/media/v4l/ext-ctrls-codec.rst Documentation/userspace-api/media/v4l/pixfmt-compressed.rst Documentation/userspace-api/media/v4l/vidioc-queryctrl.rst +11 more+7 -1110 replies
8/10media: uapi: Move the MPEG-2 stateless control type out of staginginclude/media/mpeg2-ctrls.h include/uapi/linux/videodev2.h+4 -40 replies
9/10media: controls: Log MPEG-2 stateless control in .std_logdrivers/media/v4l2-core/v4l2-ctrls.c+9 -00 replies
10/10media: uapi: move MPEG-2 stateless controls out of stagingDocumentation/userspace-api/media/v4l/ext-ctrls-codec-stateless.rst Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst Documentation/userspace-api/media/v4l/pixfmt-compressed.rst +11 more+367 -3690 replies

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchJernej SkrabecDaniel AlmeidaJonas Karlman
1/10T-b R-b T-b
2/10T-b R-b T-b
3/10T-b R-b T-b T-b
4/10T-b R-b T-b T-b
5/10T-b R-b T-b
6/10T-b R-b T-b
7/10T-b R-b T-b
8/10T-b R-b T-b
9/10T-b R-b T-b
10/10T-b R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v7 thread

Cover letter [PATCH v7 00/10] MPEG-2 stateless API cleanup and destaging

Hi,

Seventh round.

v7:
* Fix padding in v4l2_ctrl_mpeg2_picture.
* Fix V4L2_MPEG2_SEQ_FLAG_PROGRESSIVE.

v6:
* Reorder patch "media: controls: Log MPEG-2 stateless control in .std_log" to avoid a new compile warning.
* Remove "reserved" field in mpeg2 sequence control, noted by Hans.
* Reorder "flags" field in mpeg2 picture control, noted by Hans.
* Typos and comments fixes, noted by Hans.

v5:
* Rename "quantization" to "quantisation", so the terminology matches the MPEG-2 specification.
This is the only change in v5, compared to v4.

v4:
* Rework and clarify quantization matrices control semantics.
* Move reference buffer fields to the picture parameter control.
* Remove slice parameters control. This can be added back in the future if needed, but for now it's not used.
See patch 6/9 for details.
* Destage the API.

v3:
* No API changes, just minor boilerplate fixes for the new controls to be properly exposed, initialized and validated.

v2:
* Fixed bad use of boolean negation in a flag, which was fortunately reported by 0day bot.

Ezequiel Garcia (10):
media: uapi: mpeg2: Rename "quantization" to "quantisation"
media: uapi: mpeg2: rework quantisation matrices semantics
media: uapi: mpeg2: Cleanup flags
media: uapi: mpeg2: Split sequence and picture parameters
media: uapi: mpeg2: Move reference buffer fields
media: hantro/cedrus: Remove unneeded slice size and slice offset
media: uapi: mpeg2: Remove V4L2_CID_MPEG_VIDEO_MPEG2_SLICE_PARAMS
media: uapi: Move the MPEG-2 stateless control type out of staging
media: controls: Log MPEG-2 stateless control in .std_log
media: uapi: move MPEG-2 stateless controls out of staging

 .../media/v4l/ext-ctrls-codec-stateless.rst   | 214 +++++++++++++++++
 .../media/v4l/ext-ctrls-codec.rst             | 217 ------------------
 .../media/v4l/pixfmt-compressed.rst           |  11 +-
 .../media/v4l/vidioc-g-ext-ctrls.rst          |  12 +
 .../media/v4l/vidioc-queryctrl.rst            |  18 +-
 .../media/videodev2.h.rst.exceptions          |   5 +-
 drivers/media/v4l2-core/v4l2-ctrls.c          | 122 +++++++---
 drivers/staging/media/hantro/hantro_drv.c     |   9 +-
 .../media/hantro/hantro_g1_mpeg2_dec.c        | 110 ++++-----
 drivers/staging/media/hantro/hantro_hw.h      |   2 +-
 drivers/staging/media/hantro/hantro_mpeg2.c   |   2 +-
 .../media/hantro/rk3399_vpu_hw_mpeg2_dec.c    | 106 ++++-----
 drivers/staging/media/sunxi/cedrus/cedrus.c   |  10 +-
 drivers/staging/media/sunxi/cedrus/cedrus.h   |   5 +-
 .../staging/media/sunxi/cedrus/cedrus_dec.c   |  10 +-
 .../staging/media/sunxi/cedrus/cedrus_mpeg2.c |  97 +++-----
 include/media/mpeg2-ctrls.h                   |  82 -------
 include/media/v4l2-ctrls.h                    |  11 +-
 include/uapi/linux/v4l2-controls.h            | 112 +++++++++
 include/uapi/linux/videodev2.h                |   7 +
 20 files changed, 610 insertions(+), 552 deletions(-)
 delete mode 100644 include/media/mpeg2-ctrls.h
Signature · 1 line
2.30.0