Skip to content

x86: Untangle Nested virt and CPUID interactions

Andrew Cooper xen-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 19 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8tools/libxl: Simplify DOMCTL_CDF_ flags handling in libxl__domain_make()tools/libxl/libxl_create.c+6 -42 replies
2/8xen/domctl: Simplify DOMCTL_CDF_ checking logicxen/arch/x86/domain.c xen/common/domain.c+24 -152 replies
3/8xen/domctl: Introduce and use XEN_DOMCTL_CDF_nested_virttools/libxl/libxl_create.c tools/ocaml/libs/xc/xenctrl.ml tools/ocaml/libs/xc/xenctrl.mli +3 more+20 -76 replies
4/8tools/cpuid: Plumb nested_virt down into xc_cpuid_apply_policy()tools/libs/ctrl/include/xenctrl.h tools/libs/guest/xg_cpuid_x86.c tools/libxl/libxl_cpuid.c+9 -122 replies
5/8x86/hvm: Obsolete the use of HVM_PARAM_NESTEDHVMtools/libxl/libxl_x86.c xen/arch/x86/hvm/hvm.c xen/include/asm-x86/hvm/nestedhvm.h +1 more+7 -402 replies
6/8xen/xsm: Drop xsm_hvm_param_nested()tools/flask/policy/modules/xen.if xen/include/xsm/dummy.h xen/include/xsm/xsm.h +3 more+1 -222 replies
7/8x86/hvm: Drop restore boolean from hvm_cr4_guest_valid_bits()xen/arch/x86/hvm/domain.c xen/arch/x86/hvm/hvm.c xen/arch/x86/hvm/svm/svmdebug.c +3 more+12 -102 replies
8/8x86/cpuid: Move VMX/SVM out of the default policyxen/include/public/arch-x86/cpufeatureset.h+2 -21 reply

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchRoger Pau MonnéWei LiuChristian Lindig
1/8R-b A-b
2/8R-b R-b
3/8R-b A-b A-b
4/8R-b
5/8R-b R-b
6/8A-b A-b
7/8R-b
8/8A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/8] x86: Untangle Nested virt and CPUID interactions

This is the final bit of untangling for existing CPUID handling, as well as the logical next step in nested-virt work to start making it usable.

Patch 4 was previously posted in isolation. It is unchanged in this series.

Andrew Cooper (8):
tools/libxl: Simplify DOMCTL_CDF_ flags handling in libxl__domain_make() xen/domctl: Simplify DOMCTL_CDF_ checking logic
xen/domctl: Introduce and use XEN_DOMCTL_CDF_nested_virt tools/cpuid: Plumb nested_virt down into xc_cpuid_apply_policy() x86/hvm: Obsolete the use of HVM_PARAM_NESTEDHVM
xen/xsm: Drop xsm_hvm_param_nested()
x86/hvm: Drop restore boolean from hvm_cr4_guest_valid_bits() x86/cpuid: Move VMX/SVM out of the default policy

 tools/flask/policy/modules/xen.if           |  2 +-
 tools/libs/ctrl/include/xenctrl.h           |  4 +--
 tools/libs/guest/xg_cpuid_x86.c             | 14 ++++------
 tools/libxl/libxl_cpuid.c                   |  3 +-
 tools/libxl/libxl_create.c                  | 13 ++++++---
 tools/libxl/libxl_x86.c                     |  5 ----
 tools/ocaml/libs/xc/xenctrl.ml              |  1 +
 tools/ocaml/libs/xc/xenctrl.mli             |  1 +
 xen/arch/x86/domain.c                       | 14 ++++++++--
 xen/arch/x86/hvm/domain.c                   |  2 +-
 xen/arch/x86/hvm/hvm.c                      | 41 ++++++---------------------
 xen/arch/x86/hvm/svm/svmdebug.c             |  6 ++--
 xen/arch/x86/hvm/vmx/vmx.c                  |  2 +-
 xen/arch/x86/hvm/vmx/vvmx.c                 |  2 +-
 xen/common/domain.c                         | 43 +++++++++++++++++------------
 xen/include/asm-x86/hvm/hvm.h               |  2 +-
 xen/include/asm-x86/hvm/nestedhvm.h         |  5 ++--
 xen/include/public/arch-x86/cpufeatureset.h |  4 +--
 xen/include/public/domctl.h                 |  4 ++-
 xen/include/public/hvm/params.h             |  4 +--
 xen/include/xsm/dummy.h                     |  6 ----
 xen/include/xsm/xsm.h                       |  6 ----
 xen/xsm/dummy.c                             |  1 -
 xen/xsm/flask/hooks.c                       |  6 ----
 xen/xsm/flask/policy/access_vectors         |  2 --
 25 files changed, 81 insertions(+), 112 deletions(-)
Signature · 1 line
2.11.0