s390x/tcg: Implement Vector enhancements facility and switch to z14
Status from this message: Thanks, applied.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest26 patches 1 replyApplied
- v326 patches 6 repliesSuperseded
- v226 patches 23 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 20 patches | 25 replies | Superseded |
Changes in v4 from the cover letter
- "s390x/tcg: Implement VECTOR FP (MAXIMUM|MINIMUM)"
-- Move "const bool ..." into respective blocks
- "linux-user: elf: s390x: Prepare for Vector enhancements facility" -- Add all currently defined Linux HWCAP.
Patches in v4 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/26 | s390x/tcg: Fix FP CONVERT TO (LOGICAL) FIXED NaN handlingtarget/ target/ | +43 | 0 replies | |
| 2/26 | s390x/tcg: Fix instruction name for VECTOR FP LOAD (LENGTHENED|ROUNDED)target/ | +2 | 0 replies | |
| 3/26 | s390x/tcg: Simplify vop64_3() handlingtarget/ target/ target/ | +30 | 0 replies | |
| 4/26 | s390x/tcg: Simplify vop64_2() handlingtarget/ target/ target/ | +58 | 0 replies | |
| 5/26 | s390x/tcg: Simplify vfc64() handlingtarget/ target/ target/ | +38 | 0 replies | |
| 6/26 | s390x/tcg: Simplify vftci64() handlingtarget/ target/ target/ | +13 | 0 replies | |
| 7/26 | s390x/tcg: Simplify vfma64() handlingtarget/ target/ target/ | +20 | 0 replies | |
| 8/26 | s390x/tcg: Simplify vfll32() handlingtarget/ target/ target/ | +6 | 0 replies | |
| 9/26 | s390x/tcg: Simplify vflr64() handlingtarget/ target/ target/ | +8 | 0 replies | |
| 10/26 | s390x/tcg: Simplify wfc64() handlingtarget/ | +12 | 0 replies | |
| 11/26 | s390x/tcg: Implement VECTOR BIT PERMUTEtarget/ target/ target/ +1 more | +33 | 0 replies | |
| 12/26 | s390x/tcg: Implement VECTOR MULTIPLY SUM LOGICALtarget/ target/ | +52 | 0 replies | |
| 13/26 | s390x/tcg: Implement 32/128 bit for VECTOR FP (ADD|DIVIDE|MULTIPLY|SUBTRACT)target/ target/ target/ | +153 | 0 replies | |
| 14/26 | s390x/tcg: Implement 32/128 bit for VECTOR (LOAD FP INTEGER|FP SQUARE ROOT)target/ target/ target/ | +109 | 0 replies | |
| 15/26 | s390x/tcg: Implement 32/128 bit for VECTOR FP COMPARE *target/ target/ target/ | +121 | 0 replies | |
| 16/26 | s390x/tcg: Implement 32/128 bit for VECTOR FP COMPARE (AND SIGNAL) SCALARtarget/ target/ target/ | +77 | 0 replies | |
| 17/26 | s390x/tcg: Implement 64 bit for VECTOR FP LOAD LENGTHENEDtarget/ target/ target/ | +30 | 0 replies | |
| 18/26 | s390x/tcg: Implement 128 bit for VECTOR FP LOAD ROUNDEDtarget/ target/ target/ | +30 | 0 replies | |
| 19/26 | s390x/tcg: Implement 32/128 bit for VECTOR FP PERFORM SIGN OPERATIONtarget/ | +73 | 0 replies | |
| 20/26 | s390x/tcg: Implement 32/128 bit for VECTOR FP TEST DATA CLASS IMMEDIATEtarget/ target/ target/ | +70 | 0 replies | |
| 21/26 | s390x/tcg: Implement 32/128 bit for VECTOR FP MULTIPLY AND (ADD|SUBTRACT)target/ target/ target/ | +87 | 0 replies | |
| 22/26 | s390x/tcg: Implement VECTOR FP NEGATIVE MULTIPLY AND (ADD|SUBTRACT)target/ target/ target/ +1 more | +49 | 0 replies | |
| 23/26 | s390x/tcg: Implement VECTOR FP (MAXIMUM|MINIMUM)target/ target/ target/ +2 more | +391 | 0 replies | |
| 24/26 | linux-user: elf: s390x: Prepare for Vector enhancements facilityinclude/ linux-user/ | +8 | 0 replies | |
| 25/26 | s390x/tcg: We support Vector enhancements facilitytarget/ | +1 | 0 replies | |
| 26/26 | s390x/cpumodel: Bump up QEMU model to a stripped-down IBM z14 GA2hw/ target/ target/ | +14 | 0 replies |
Reviews trailers per patch
All 26 patches have a Reviewed-by or Acked-by.
| Patch | Richard Henderson | Laurent Vivier |
|---|---|---|
| 1/26 | R-b | |
| 2/26 | R-b | |
| 3/26 | R-b | |
| 4/26 | R-b | |
| 5/26 | R-b | |
| 6/26 | R-b | |
| 7/26 | R-b | |
| 8/26 | R-b | |
| 9/26 | R-b | |
| 10/26 | R-b | |
| 11/26 | R-b | |
| 12/26 | R-b | |
| 13/26 | R-b | |
| 14/26 | R-b | |
| 15/26 | R-b | |
| 16/26 | R-b | |
| 17/26 | R-b | |
| 18/26 | R-b | |
| 19/26 | R-b | |
| 20/26 | R-b | |
| 21/26 | R-b | |
| 22/26 | R-b | |
| 23/26 | R-b | |
| 24/26 | A-b | |
| 25/26 | R-b | |
| 26/26 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 00/26] s390x/tcg: Implement Vector enhancements facility and switch to z14
@Conny, I think this should be good to go.
This series adds support for the "Vector enhancements facility" and bumps the qemu CPU model to a stripped-down z14.
I tested most vector FP instructions by generating random instructions and vectors, comparing the result with results on actual hardware. I did not test instructions/instruction variants with (partial) undeterministic behavior and exception handling.
Linux' also seems to boot/work fine with it. Howeever, while testing this series I noticed that Linux checks for the wrong facility bit - see [1]. I tested by temporarily faking availability of the "wrong" facility bit.
[1] https://lkml.kernel.org/r/[email protected]
v3 -> v4:
- "s390x/tcg: Implement VECTOR FP (MAXIMUM|MINIMUM)"
-- Move "const bool ..." into respective blocks
- "linux-user: elf: s390x: Prepare for Vector enhancements facility" -- Add all currently defined Linux HWCAP.
v2 -> v3:
- "s390x/tcg: Fix FP CONVERT TO (LOGICAL) FIXED NaN handling" -- Keep proper signal handling in the VECTOR variants
- "s390x/tcg: Simplify vop64_2() handling"
-- uint64_t se -> bool se
- "s390x/tcg: Implement VECTOR FP (MAXIMUM|MINIMUM)" -- Drop special cases when both values are infinity -- Simplify cases when both values are zero
-- Simplify dcmask handling
-- uint64_t se -> bool se
- "linux-user: elf: Prepare for Vector enhancements facility" -- Added to properly indicate the new elf capability
v1 -> v2:
- Too much changed to spell it out explicitly. Mostly addressed feedback from Richard, a couple of bugfixes found while testing, and some simplifications/cleanups.
- Rebased on top of Richard's softfloat rework
David Hildenbrand (26):
s390x/tcg: Fix FP CONVERT TO (LOGICAL) FIXED NaN handling s390x/tcg: Fix instruction name for VECTOR FP LOAD
(LENGTHENED|ROUNDED)
s390x/tcg: Simplify vop64_3() handling
s390x/tcg: Simplify vop64_2() handling
s390x/tcg: Simplify vfc64() handling
s390x/tcg: Simplify vftci64() handling
s390x/tcg: Simplify vfma64() handling
s390x/tcg: Simplify vfll32() handling
s390x/tcg: Simplify vflr64() handling
s390x/tcg: Simplify wfc64() handling
s390x/tcg: Implement VECTOR BIT PERMUTE
s390x/tcg: Implement VECTOR MULTIPLY SUM LOGICAL s390x/tcg: Implement 32/128 bit for VECTOR FP
(ADD|DIVIDE|MULTIPLY|SUBTRACT)
s390x/tcg: Implement 32/128 bit for VECTOR (LOAD FP INTEGER|FP SQUARE
ROOT)
s390x/tcg: Implement 32/128 bit for VECTOR FP COMPARE * s390x/tcg: Implement 32/128 bit for VECTOR FP COMPARE (AND SIGNAL)
SCALAR
s390x/tcg: Implement 64 bit for VECTOR FP LOAD LENGTHENED s390x/tcg: Implement 128 bit for VECTOR FP LOAD ROUNDED s390x/tcg: Implement 32/128 bit for VECTOR FP PERFORM SIGN OPERATION s390x/tcg: Implement 32/128 bit for VECTOR FP TEST DATA CLASS
IMMEDIATE
s390x/tcg: Implement 32/128 bit for VECTOR FP MULTIPLY AND
(ADD|SUBTRACT)
s390x/tcg: Implement VECTOR FP NEGATIVE MULTIPLY AND (ADD|SUBTRACT) s390x/tcg: Implement VECTOR FP (MAXIMUM|MINIMUM)
linux-user: elf: s390x: Prepare for Vector enhancements facility s390x/tcg: We support Vector enhancements facility s390x/cpumodel: Bump up QEMU model to a stripped-down IBM z14 GA2
hw/s390x/s390-virtio-ccw.c | 3 + include/elf.h | 7 + linux-user/elfload.c | 1 + target/s390x/cpu_models.c | 4 +- target/s390x/fpu_helper.c | 41 +- target/s390x/gen-features.c | 14 +- target/s390x/helper.h | 70 +- target/s390x/insn-data.def | 16 +- target/s390x/internal.h | 9 + target/s390x/translate_vx.c.inc | 633 ++++++++++++++---- target/s390x/vec_fpu_helper.c | 1079 ++++++++++++++++++++++--------- target/s390x/vec_helper.c | 22 + 12 files changed, 1428 insertions(+), 471 deletions(-)
Signature · 1 line
2.31.1