Skip to content

s390x/tcg: Implement Vector enhancements facility and switch to z14

David Hildenbrand qemu-devel 4 versions – Applied

Status from this message: Thanks, applied.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest26 patches 1 replyApplied
  2. v326 patches 6 repliesSuperseded
  3. v226 patches 23 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v120 patches25 repliesSuperseded

Changes in v4 from the cover letter

- "s390x/tcg: Implement VECTOR FP (MAXIMUM|MINIMUM)"
-- Move "const bool ..." into respective blocks
- "linux-user: elf: s390x: Prepare for Vector enhancements facility" -- Add all currently defined Linux HWCAP.

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/26s390x/tcg: Fix FP CONVERT TO (LOGICAL) FIXED NaN handlingtarget/s390x/fpu_helper.c target/s390x/vec_fpu_helper.c+43 -60 replies
2/26s390x/tcg: Fix instruction name for VECTOR FP LOAD (LENGTHENED|ROUNDED)target/s390x/insn-data.def+2 -20 replies
3/26s390x/tcg: Simplify vop64_3() handlingtarget/s390x/helper.h target/s390x/translate_vx.c.inc target/s390x/vec_fpu_helper.c+30 -790 replies
4/26s390x/tcg: Simplify vop64_2() handlingtarget/s390x/helper.h target/s390x/translate_vx.c.inc target/s390x/vec_fpu_helper.c+58 -1560 replies
5/26s390x/tcg: Simplify vfc64() handlingtarget/s390x/helper.h target/s390x/translate_vx.c.inc target/s390x/vec_fpu_helper.c+38 -1070 replies
6/26s390x/tcg: Simplify vftci64() handlingtarget/s390x/helper.h target/s390x/translate_vx.c.inc target/s390x/vec_fpu_helper.c+13 -240 replies
7/26s390x/tcg: Simplify vfma64() handlingtarget/s390x/helper.h target/s390x/translate_vx.c.inc target/s390x/vec_fpu_helper.c+20 -320 replies
8/26s390x/tcg: Simplify vfll32() handlingtarget/s390x/helper.h target/s390x/translate_vx.c.inc target/s390x/vec_fpu_helper.c+6 -220 replies
9/26s390x/tcg: Simplify vflr64() handlingtarget/s390x/helper.h target/s390x/translate_vx.c.inc target/s390x/vec_fpu_helper.c+8 -250 replies
10/26s390x/tcg: Simplify wfc64() handlingtarget/s390x/vec_fpu_helper.c+12 -110 replies
11/26s390x/tcg: Implement VECTOR BIT PERMUTEtarget/s390x/helper.h target/s390x/insn-data.def target/s390x/translate_vx.c.inc +1 more+33 -00 replies
12/26s390x/tcg: Implement VECTOR MULTIPLY SUM LOGICALtarget/s390x/insn-data.def target/s390x/translate_vx.c.inc+52 -00 replies
13/26s390x/tcg: Implement 32/128 bit for VECTOR FP (ADD|DIVIDE|MULTIPLY|SUBTRACT)target/s390x/helper.h target/s390x/translate_vx.c.inc target/s390x/vec_fpu_helper.c+153 -140 replies
14/26s390x/tcg: Implement 32/128 bit for VECTOR (LOAD FP INTEGER|FP SQUARE ROOT)target/s390x/helper.h target/s390x/translate_vx.c.inc target/s390x/vec_fpu_helper.c+109 -150 replies
15/26s390x/tcg: Implement 32/128 bit for VECTOR FP COMPARE *target/s390x/helper.h target/s390x/translate_vx.c.inc target/s390x/vec_fpu_helper.c+121 -120 replies
16/26s390x/tcg: Implement 32/128 bit for VECTOR FP COMPARE (AND SIGNAL) SCALARtarget/s390x/helper.h target/s390x/translate_vx.c.inc target/s390x/vec_fpu_helper.c+77 -90 replies
17/26s390x/tcg: Implement 64 bit for VECTOR FP LOAD LENGTHENEDtarget/s390x/helper.h target/s390x/translate_vx.c.inc target/s390x/vec_fpu_helper.c+30 -30 replies
18/26s390x/tcg: Implement 128 bit for VECTOR FP LOAD ROUNDEDtarget/s390x/helper.h target/s390x/translate_vx.c.inc target/s390x/vec_fpu_helper.c+30 -10 replies
19/26s390x/tcg: Implement 32/128 bit for VECTOR FP PERFORM SIGN OPERATIONtarget/s390x/translate_vx.c.inc+73 -330 replies
20/26s390x/tcg: Implement 32/128 bit for VECTOR FP TEST DATA CLASS IMMEDIATEtarget/s390x/helper.h target/s390x/translate_vx.c.inc target/s390x/vec_fpu_helper.c+70 -20 replies
21/26s390x/tcg: Implement 32/128 bit for VECTOR FP MULTIPLY AND (ADD|SUBTRACT)target/s390x/helper.h target/s390x/translate_vx.c.inc target/s390x/vec_fpu_helper.c+87 -80 replies
22/26s390x/tcg: Implement VECTOR FP NEGATIVE MULTIPLY AND (ADD|SUBTRACT)target/s390x/helper.h target/s390x/insn-data.def target/s390x/translate_vx.c.inc +1 more+49 -20 replies
23/26s390x/tcg: Implement VECTOR FP (MAXIMUM|MINIMUM)target/s390x/helper.h target/s390x/insn-data.def target/s390x/internal.h +2 more+391 -00 replies
24/26linux-user: elf: s390x: Prepare for Vector enhancements facilityinclude/elf.h linux-user/elfload.c+8 -00 replies
25/26s390x/tcg: We support Vector enhancements facilitytarget/s390x/gen-features.c+1 -00 replies
26/26s390x/cpumodel: Bump up QEMU model to a stripped-down IBM z14 GA2hw/s390x/s390-virtio-ccw.c target/s390x/cpu_models.c target/s390x/gen-features.c+14 -80 replies

Reviews trailers per patch

All 26 patches have a Reviewed-by or Acked-by.

PatchRichard HendersonLaurent Vivier
1/26R-b
2/26R-b
3/26R-b
4/26R-b
5/26R-b
6/26R-b
7/26R-b
8/26R-b
9/26R-b
10/26R-b
11/26R-b
12/26R-b
13/26R-b
14/26R-b
15/26R-b
16/26R-b
17/26R-b
18/26R-b
19/26R-b
20/26R-b
21/26R-b
22/26R-b
23/26R-b
24/26A-b
25/26R-b
26/26R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 00/26] s390x/tcg: Implement Vector enhancements facility and switch to z14

@Conny, I think this should be good to go.

This series adds support for the "Vector enhancements facility" and bumps the qemu CPU model to a stripped-down z14.

I tested most vector FP instructions by generating random instructions and vectors, comparing the result with results on actual hardware. I did not test instructions/instruction variants with (partial) undeterministic behavior and exception handling.

Linux' also seems to boot/work fine with it. Howeever, while testing this series I noticed that Linux checks for the wrong facility bit - see [1]. I tested by temporarily faking availability of the "wrong" facility bit.

[1] https://lkml.kernel.org/r/[email protected]

v3 -> v4:
- "s390x/tcg: Implement VECTOR FP (MAXIMUM|MINIMUM)"
-- Move "const bool ..." into respective blocks
- "linux-user: elf: s390x: Prepare for Vector enhancements facility" -- Add all currently defined Linux HWCAP.

v2 -> v3:
- "s390x/tcg: Fix FP CONVERT TO (LOGICAL) FIXED NaN handling" -- Keep proper signal handling in the VECTOR variants
- "s390x/tcg: Simplify vop64_2() handling"
-- uint64_t se -> bool se
- "s390x/tcg: Implement VECTOR FP (MAXIMUM|MINIMUM)" -- Drop special cases when both values are infinity -- Simplify cases when both values are zero
-- Simplify dcmask handling
-- uint64_t se -> bool se
- "linux-user: elf: Prepare for Vector enhancements facility" -- Added to properly indicate the new elf capability

v1 -> v2:
- Too much changed to spell it out explicitly. Mostly addressed feedback from Richard, a couple of bugfixes found while testing, and some simplifications/cleanups.
- Rebased on top of Richard's softfloat rework

Cc Cornelia Huck <[email protected]>
Cc Halil Pasic <[email protected]>
Cc Christian Borntraeger <[email protected]>
Cc Thomas Huth <[email protected]>
Cc Richard Henderson <[email protected]>
Cc Laurent Vivier <[email protected]>

David Hildenbrand (26):
s390x/tcg: Fix FP CONVERT TO (LOGICAL) FIXED NaN handling s390x/tcg: Fix instruction name for VECTOR FP LOAD
(LENGTHENED|ROUNDED)
s390x/tcg: Simplify vop64_3() handling
s390x/tcg: Simplify vop64_2() handling
s390x/tcg: Simplify vfc64() handling
s390x/tcg: Simplify vftci64() handling
s390x/tcg: Simplify vfma64() handling
s390x/tcg: Simplify vfll32() handling
s390x/tcg: Simplify vflr64() handling
s390x/tcg: Simplify wfc64() handling
s390x/tcg: Implement VECTOR BIT PERMUTE
s390x/tcg: Implement VECTOR MULTIPLY SUM LOGICAL s390x/tcg: Implement 32/128 bit for VECTOR FP
(ADD|DIVIDE|MULTIPLY|SUBTRACT)
s390x/tcg: Implement 32/128 bit for VECTOR (LOAD FP INTEGER|FP SQUARE
ROOT)
s390x/tcg: Implement 32/128 bit for VECTOR FP COMPARE * s390x/tcg: Implement 32/128 bit for VECTOR FP COMPARE (AND SIGNAL)
SCALAR
s390x/tcg: Implement 64 bit for VECTOR FP LOAD LENGTHENED s390x/tcg: Implement 128 bit for VECTOR FP LOAD ROUNDED s390x/tcg: Implement 32/128 bit for VECTOR FP PERFORM SIGN OPERATION s390x/tcg: Implement 32/128 bit for VECTOR FP TEST DATA CLASS
IMMEDIATE
s390x/tcg: Implement 32/128 bit for VECTOR FP MULTIPLY AND
(ADD|SUBTRACT)
s390x/tcg: Implement VECTOR FP NEGATIVE MULTIPLY AND (ADD|SUBTRACT) s390x/tcg: Implement VECTOR FP (MAXIMUM|MINIMUM)
linux-user: elf: s390x: Prepare for Vector enhancements facility s390x/tcg: We support Vector enhancements facility s390x/cpumodel: Bump up QEMU model to a stripped-down IBM z14 GA2

 hw/s390x/s390-virtio-ccw.c      |    3 +
 include/elf.h                   |    7 +
 linux-user/elfload.c            |    1 +
 target/s390x/cpu_models.c       |    4 +-
 target/s390x/fpu_helper.c       |   41 +-
 target/s390x/gen-features.c     |   14 +-
 target/s390x/helper.h           |   70 +-
 target/s390x/insn-data.def      |   16 +-
 target/s390x/internal.h         |    9 +
 target/s390x/translate_vx.c.inc |  633 ++++++++++++++----
 target/s390x/vec_fpu_helper.c   | 1079 ++++++++++++++++++++++---------
 target/s390x/vec_helper.c       |   22 +
 12 files changed, 1428 insertions(+), 471 deletions(-)
Signature · 1 line
2.31.1