Skip to content

nvme qemu cleanups and fixes

Keith Busch qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 26 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9hw/block/nvme: remove pointless rw indirectionhw/block/nvme.c+29 -625 replies
2/9hw/block/nvme: fix log page offset checkhw/block/nvme.c+10 -123 replies
3/9hw/block/nvme: support per-namespace smart loghw/block/nvme.c include/block/nvme.h+41 -267 replies
4/9hw/block/nvme: validate command set selectedhw/block/nvme.c hw/block/trace-events include/block/nvme.h+10 -11 reply
5/9hw/block/nvme: support for admin-only command sethw/block/nvme.c include/block/nvme.h+3 -12 replies
6/9hw/block/nvme: reject io commands if only admin command set selectedhw/block/nvme.c include/block/nvme.h+9 -01 reply
7/9hw/block/nvme: add nsid to get/setfeat trace eventshw/block/nvme.c hw/block/trace-events+4 -40 replies
8/9hw/block/nvme: add trace event for requests with non-zero status codehw/block/nvme.c hw/block/trace-events+7 -02 replies
9/9hw/block/nvme: report actual LBA data shift in LBAFhw/block/nvme-ns.c+5 -01 reply

Reviews trailers per patch

8 of 9 patches have a Reviewed-by or Acked-by.

PatchKlaus JensenDmitry FomichevPhilippe Mathieu-Daudé
1/9R-b
2/9R-b R-b
3/9R-b
4/9R-b
5/9R-b
6/9R-b
7/9
8/9R-b R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/9] nvme qemu cleanups and fixes

After going through the zns enabling, I notice the controller enabling is not correct. Then I just continued maked more stuff. The series, I think, contains some of the less controversial patches from the two conflicting zns series, preceeded by some cleanups and fixes from me.

If this is all fine, I took the liberty of porting the zns enabling to it and made a public branch for consideration here:

http://git.infradead.org/qemu-nvme.git/shortlog/refs/heads/kb-zns

Dmitry Fomichev (1):
hw/block/nvme: report actual LBA data shift in LBAF

Keith Busch (5):
hw/block/nvme: remove pointless rw indirection hw/block/nvme: fix log page offset check hw/block/nvme: support per-namespace smart log hw/block/nvme: validate command set selected hw/block/nvme: support for admin-only command set

Klaus Jensen (3):
hw/block/nvme: reject io commands if only admin command set selected hw/block/nvme: add nsid to get/setfeat trace events hw/block/nvme: add trace event for requests with non-zero status code

 hw/block/nvme-ns.c    |   5 ++
 hw/block/nvme.c       | 194 ++++++++++++++++++++----------------------
 hw/block/trace-events |   6 +-
 include/block/nvme.h  |  11 +++
 4 files changed, 114 insertions(+), 102 deletions(-)
Signature · 1 line
2.24.1