Skip to content

net: dsa: Improve dsa_untag_bridge_pvid()

Florian Fainelli lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4net: dsa: Call dsa_untag_bridge_pvid() from dsa_switch_rcv()include/net/dsa.h net/dsa/dsa.c+17 -01 reply
2/4net: dsa: b53: Set untag_bridge_pviddrivers/net/dsa/b53/b53_common.c net/dsa/tag_brcm.c+3 -131 reply
3/4net: dsa: Obtain VLAN protocol from skb->protocolnet/dsa/dsa_priv.h+1 -21 reply
4/4net: dsa: Utilize __vlan_find_dev_deep_rcu()net/dsa/dsa_priv.h+3 -81 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchVladimir Oltean
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next 0/4] net: dsa: Improve dsa_untag_bridge_pvid()

Hi David, Jakub,

This patch series is based on the recent discussions with Vladimir:

https://lore.kernel.org/netdev/[email protected]/

the simplest way forward was to call dsa_untag_bridge_pvid() after eth_type_trans() has been set which guarantees that skb->protocol is set to a correct value and this allows us to utilize __vlan_find_dev_deep_rcu() properly without playing or using the bridge master as a net_device reference.

Florian Fainelli (4):
net: dsa: Call dsa_untag_bridge_pvid() from dsa_switch_rcv()
net: dsa: b53: Set untag_bridge_pvid
net: dsa: Obtain VLAN protocol from skb->protocol
net: dsa: Utilize __vlan_find_dev_deep_rcu()

 drivers/net/dsa/b53/b53_common.c |  1 +
 include/net/dsa.h                |  8 ++++++++
 net/dsa/dsa.c                    |  9 +++++++++
 net/dsa/dsa_priv.h               | 14 ++++----------
 net/dsa/tag_brcm.c               | 15 ++-------------
 5 files changed, 24 insertions(+), 23 deletions(-)
Signature · 1 line
2.25.1