drm/msm: de-struct_mutex-ification
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest14 patches 24 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/14 | drm/msm: Use correct drm_gem_object_put() in fail casedrivers/ | +5 | 0 replies | |
| 2/14 | drm/msm: Drop chatty tracedrivers/ | +0 | 1 reply | |
| 3/14 | drm/msm: Move update_fences()drivers/ | +14 | 1 reply | |
| 4/14 | drm/msm: Add priv->mm_lock to protect active/inactive listsdrivers/ drivers/ drivers/ +3 more | +52 | 3 replies | |
| 5/14 | drm/msm: Document and rename preempt_lockdrivers/ drivers/ drivers/ +2 more | +17 | 1 reply | |
| 6/14 | drm/msm: Protect ring->submits with it's own lockdrivers/ drivers/ drivers/ +1 more | +39 | 1 reply | |
| 7/14 | drm/msm: Refcount submitsdrivers/ drivers/ drivers/ +1 more | +35 | 3 replies | |
| 8/14 | drm/msm: Remove obj->gpudrivers/ drivers/ drivers/ | +0 | 1 reply | |
| 9/14 | drm/msm: Drop struct_mutex from the retire pathdrivers/ | +1 | 1 reply | |
| 10/14 | drm/msm: Drop struct_mutex in free_object() pathdrivers/ | +0 | 0 replies | |
| 11/14 | drm/msm: remove msm_gem_free_workdrivers/ drivers/ drivers/ +1 more | +0 | 0 replies | |
| 12/14 | drm/msm: drop struct_mutex in madvise pathdrivers/ drivers/ drivers/ +1 more | +32 | 0 replies | |
| 13/14 | drm/msm: Drop struct_mutex in shrinker pathdrivers/ drivers/ | +0 | 9 replies | |
| 14/14 | drm/msm: Don't implicit-sync if only a single ringdrivers/ | +4 | 0 replies |
Reviews trailers per patch
9 of 14 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Jordan Crouse | Kristian H. Kristensen |
|---|---|---|
| Series | R-b | |
| 1/14 | ||
| 2/14 | R-b | |
| 3/14 | R-b | |
| 4/14 | R-b | |
| 5/14 | R-b | |
| 6/14 | R-b | |
| 7/14 | R-b | |
| 8/14 | R-b | |
| 9/14 | R-b | |
| 10/14 | ||
| 11/14 | ||
| 12/14 | ||
| 13/14 | R-b | |
| 14/14 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 00/14] drm/msm: de-struct_mutex-ification
From: Rob Clark <[email protected]>
This doesn't remove *all* the struct_mutex, but it covers the worst of it, ie. shrinker/madvise/free/retire. The submit path still uses struct_mutex, but it still needs *something* serialize a portion of the submit path, and lock_stat mostly just shows the lock contention there being with other submits. And there are a few other bits of struct_mutex usage in less critical paths (debugfs, etc). But this seems like a reasonable step in the right direction.
Rob Clark (14):
drm/msm: Use correct drm_gem_object_put() in fail case drm/msm: Drop chatty trace
drm/msm: Move update_fences()
drm/msm: Add priv->mm_lock to protect active/inactive lists drm/msm: Document and rename preempt_lock drm/msm: Protect ring->submits with it's own lock drm/msm: Refcount submits
drm/msm: Remove obj->gpu
drm/msm: Drop struct_mutex from the retire path drm/msm: Drop struct_mutex in free_object() path drm/msm: remove msm_gem_free_work
drm/msm: drop struct_mutex in madvise path drm/msm: Drop struct_mutex in shrinker path drm/msm: Don't implicit-sync if only a single ring
drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 4 +- drivers/gpu/drm/msm/adreno/a5xx_preempt.c | 12 +-- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 4 +- drivers/gpu/drm/msm/msm_debugfs.c | 7 ++ drivers/gpu/drm/msm/msm_drv.c | 15 +--- drivers/gpu/drm/msm/msm_drv.h | 19 +++-- drivers/gpu/drm/msm/msm_gem.c | 76 ++++++------------ drivers/gpu/drm/msm/msm_gem.h | 53 +++++++++---- drivers/gpu/drm/msm/msm_gem_shrinker.c | 58 ++------------ drivers/gpu/drm/msm/msm_gem_submit.c | 17 ++-- drivers/gpu/drm/msm/msm_gpu.c | 96 ++++++++++++++--------- drivers/gpu/drm/msm/msm_gpu.h | 5 +- drivers/gpu/drm/msm/msm_ringbuffer.c | 3 +- drivers/gpu/drm/msm/msm_ringbuffer.h | 13 ++- 14 files changed, 188 insertions(+), 194 deletions(-)
Signature · 1 line
2.26.2