Skip to content

drm/msm: de-struct_mutex-ification

Rob Clark dri-devel linux-arm-msm linux-media lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest14 patches 24 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14drm/msm: Use correct drm_gem_object_put() in fail casedrivers/gpu/drm/msm/msm_gem.c+5 -10 replies
2/14drm/msm: Drop chatty tracedrivers/gpu/drm/msm/msm_gpu.c+0 -11 reply
3/14drm/msm: Move update_fences()drivers/gpu/drm/msm/msm_gpu.c+14 -141 reply
4/14drm/msm: Add priv->mm_lock to protect active/inactive listsdrivers/gpu/drm/msm/msm_debugfs.c drivers/gpu/drm/msm/msm_drv.c drivers/gpu/drm/msm/msm_drv.h +3 more+52 -143 replies
5/14drm/msm: Document and rename preempt_lockdrivers/gpu/drm/msm/adreno/a5xx_gpu.c drivers/gpu/drm/msm/adreno/a5xx_preempt.c drivers/gpu/drm/msm/adreno/a6xx_gpu.c +2 more+17 -121 reply
6/14drm/msm: Protect ring->submits with it's own lockdrivers/gpu/drm/msm/msm_gem_submit.c drivers/gpu/drm/msm/msm_gpu.c drivers/gpu/drm/msm/msm_ringbuffer.c +1 more+39 -71 reply
7/14drm/msm: Refcount submitsdrivers/gpu/drm/msm/msm_drv.h drivers/gpu/drm/msm/msm_gem.h drivers/gpu/drm/msm/msm_gem_submit.c +1 more+35 -123 replies
8/14drm/msm: Remove obj->gpudrivers/gpu/drm/msm/msm_gem.c drivers/gpu/drm/msm/msm_gem.h drivers/gpu/drm/msm/msm_gpu.c+0 -81 reply
9/14drm/msm: Drop struct_mutex from the retire pathdrivers/gpu/drm/msm/msm_gpu.c+1 -71 reply
10/14drm/msm: Drop struct_mutex in free_object() pathdrivers/gpu/drm/msm/msm_gem.c+0 -80 replies
11/14drm/msm: remove msm_gem_free_workdrivers/gpu/drm/msm/msm_drv.c drivers/gpu/drm/msm/msm_drv.h drivers/gpu/drm/msm/msm_gem.c +1 more+0 -360 replies
12/14drm/msm: drop struct_mutex in madvise pathdrivers/gpu/drm/msm/msm_drv.c drivers/gpu/drm/msm/msm_gem.c drivers/gpu/drm/msm/msm_gem.h +1 more+32 -270 replies
13/14drm/msm: Drop struct_mutex in shrinker pathdrivers/gpu/drm/msm/msm_gem.c drivers/gpu/drm/msm/msm_gem_shrinker.c+0 -559 replies
14/14drm/msm: Don't implicit-sync if only a single ringdrivers/gpu/drm/msm/msm_gem_submit.c+4 -30 replies

Reviews trailers per patch

9 of 14 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJordan CrouseKristian H. Kristensen
SeriesR-b
1/14
2/14R-b
3/14R-b
4/14R-b
5/14R-b
6/14R-b
7/14R-b
8/14R-b
9/14R-b
10/14
11/14
12/14
13/14R-b
14/14

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/14] drm/msm: de-struct_mutex-ification

From: Rob Clark <[email protected]>

This doesn't remove *all* the struct_mutex, but it covers the worst of it, ie. shrinker/madvise/free/retire. The submit path still uses struct_mutex, but it still needs *something* serialize a portion of the submit path, and lock_stat mostly just shows the lock contention there being with other submits. And there are a few other bits of struct_mutex usage in less critical paths (debugfs, etc). But this seems like a reasonable step in the right direction.

Rob Clark (14):
drm/msm: Use correct drm_gem_object_put() in fail case drm/msm: Drop chatty trace
drm/msm: Move update_fences()
drm/msm: Add priv->mm_lock to protect active/inactive lists drm/msm: Document and rename preempt_lock drm/msm: Protect ring->submits with it's own lock drm/msm: Refcount submits
drm/msm: Remove obj->gpu
drm/msm: Drop struct_mutex from the retire path drm/msm: Drop struct_mutex in free_object() path drm/msm: remove msm_gem_free_work
drm/msm: drop struct_mutex in madvise path drm/msm: Drop struct_mutex in shrinker path drm/msm: Don't implicit-sync if only a single ring

 drivers/gpu/drm/msm/adreno/a5xx_gpu.c     |  4 +-
 drivers/gpu/drm/msm/adreno/a5xx_preempt.c | 12 +--
 drivers/gpu/drm/msm/adreno/a6xx_gpu.c     |  4 +-
 drivers/gpu/drm/msm/msm_debugfs.c         |  7 ++
 drivers/gpu/drm/msm/msm_drv.c             | 15 +---
 drivers/gpu/drm/msm/msm_drv.h             | 19 +++--
 drivers/gpu/drm/msm/msm_gem.c             | 76 ++++++------------
 drivers/gpu/drm/msm/msm_gem.h             | 53 +++++++++----
 drivers/gpu/drm/msm/msm_gem_shrinker.c    | 58 ++------------
 drivers/gpu/drm/msm/msm_gem_submit.c      | 17 ++--
 drivers/gpu/drm/msm/msm_gpu.c             | 96 ++++++++++++++---------
 drivers/gpu/drm/msm/msm_gpu.h             |  5 +-
 drivers/gpu/drm/msm/msm_ringbuffer.c      |  3 +-
 drivers/gpu/drm/msm/msm_ringbuffer.h      | 13 ++-
 14 files changed, 188 insertions(+), 194 deletions(-)
Signature · 1 line
2.26.2