Skip to content

dm: Remove redefinitions of dev_xxx macros

Sean Anderson u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest16 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16clk: sifive: Include device_compat.hdrivers/clk/sifive/fu540-prci.c+9 -91 reply
2/16dm: syscon: Set LOG_CATEGORYdrivers/core/syscon-uclass.c+2 -02 replies
3/16firmware: scmi: Include device_compat.hdrivers/firmware/scmi/mailbox_agent.c drivers/firmware/scmi/scmi_agent-uclass.c drivers/firmware/scmi/smt.c+3 -02 replies
4/16mtd: mxs_nand: Fix not calling dev_xxx with a devicedrivers/mtd/nand/raw/mxs_nand.c+16 -141 reply
5/16net: ldpaa_eth: Include device_compat.hdrivers/net/ldpaa_eth/ldpaa_eth.c+8 -81 reply
6/16phy: Include device_compat.hdrivers/phy/phy-uclass.c+1 -11 reply
7/16ram: imxrt: Include device_compat.hdrivers/ram/imxrt_sdram.c+1 -01 reply
8/16spi: nsp_fspi: Include device_compat.hdrivers/spi/nxp_fspi.c+4 -32 replies
9/16spi: fsl_qspi: Include device_compat.hdrivers/spi/fsl_qspi.c+5 -41 reply
10/16tee: optee: Include device_compat.hdrivers/tee/optee/core.c+1 -03 replies
11/16timer: Include device_compat.hdrivers/timer/timer-uclass.c+3 -22 replies
12/16usb: xhci: Include device_compat.hdrivers/usb/host/xhci-mtk.c drivers/usb/host/xhci.c+7 -51 reply
13/16usb: musb-new: Include device_compat.hdrivers/usb/musb-new/musb_core.c drivers/usb/musb-new/musb_dsps.c drivers/usb/musb-new/musb_gadget.c +2 more+11 -11 reply
14/16usb: musb-new: mt85xx: Fix not calling dev_err with a devicedrivers/usb/musb-new/mt85xx.c+4 -31 reply
15/16linux/compat.h: Remove redefinition of dev_xxx macrosinclude/linux/compat.h+0 -282 replies
16/16dm: Don't undefine dev_xxx macrosinclude/dm/device_compat.h+0 -202 replies

Reviews trailers per patch

6 of 16 patches have a Reviewed-by or Acked-by.

PatchSimon GlassIgor Opaniuk
1/16
2/16R-b
3/16R-b
4/16
5/16
6/16
7/16
8/16
9/16
10/16R-b R-b
11/16R-b
12/16
13/16
14/16
15/16R-b
16/16R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/16] dm: Remove redefinitions of dev_xxx macros

dev_xxx is now defined to something other than debug, so its redefinition in linux/compat.h is problematic. This series mostly adds includes for dm/device_compat.h, if only linux/compat.h had previously been included. Some patches also fix remaining cases where dev_xxx had been called without a device. I have re-ordered includes to conform to [1]. CI is available at [2]. There's one failure, but it appears to be because fetching the docker file timed out. A passing run for that job is available at [3].

[1] https://www.denx.de/wiki/U-Boot/CodingStyle#Include_files
[2] https://dev.azure.com/seanga2/u-boot/_build/results?buildId=47&view=results
[3] https://dev.azure.com/seanga2/u-boot/_build/results?buildId=46&view=logs&j=a6c8f4b8-aab0-5875-641a-f1020f283ec1

Sean Anderson (16):
clk: sifive: Include device_compat.h
dm: syscon: Set LOG_CATEGORY
firmware: scmi: Include device_compat.h
mtd: mxs_nand: Fix not calling dev_xxx with a device
net: ldpaa_eth: Include device_compat.h
phy: Include device_compat.h
ram: imxrt: Include device_compat.h
spi: nsp_fspi: Include device_compat.h
spi: fsl_qspi: Include device_compat.h
tee: optee: Include device_compat.h
timer: Include device_compat.h
usb: xhci: Include device_compat.h
usb: musb-new: Include device_compat.h
usb: musb-new: mt85xx: Fix not calling dev_err with a device linux/compat.h: Remove redefinition of dev_xxx macros
dm: Don't undefine dev_xxx macros

 drivers/clk/sifive/fu540-prci.c           | 18 +++++++-------
 drivers/core/syscon-uclass.c              |  2 ++
 drivers/firmware/scmi/mailbox_agent.c     |  1 +
 drivers/firmware/scmi/scmi_agent-uclass.c |  1 +
 drivers/firmware/scmi/smt.c               |  1 +
 drivers/mtd/nand/raw/mxs_nand.c           | 30 ++++++++++++-----------
 drivers/net/ldpaa_eth/ldpaa_eth.c         | 16 ++++++------
 drivers/phy/phy-uclass.c                  |  2 +-
 drivers/ram/imxrt_sdram.c                 |  1 +
 drivers/spi/fsl_qspi.c                    |  9 ++++---
 drivers/spi/nxp_fspi.c                    |  7 +++---
 drivers/tee/optee/core.c                  |  1 +
 drivers/timer/timer-uclass.c              |  5 ++--
 drivers/usb/host/xhci-mtk.c               |  5 ++--
 drivers/usb/host/xhci.c                   |  7 +++---
 drivers/usb/musb-new/mt85xx.c             |  7 +++---
 drivers/usb/musb-new/musb_core.c          |  2 ++
 drivers/usb/musb-new/musb_dsps.c          |  2 ++
 drivers/usb/musb-new/musb_gadget.c        |  2 ++
 drivers/usb/musb-new/musb_gadget_ep0.c    |  4 ++-
 drivers/usb/musb-new/musb_host.c          |  2 ++
 include/dm/device_compat.h                | 20 ---------------
 include/linux/compat.h                    | 28 ---------------------
 23 files changed, 75 insertions(+), 98 deletions(-)
Signature · 1 line
2.28.0