format check tweaks
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest8 patches 4 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | need to strip SYM_NODE before comparing typesvalidation/ verify-format.c | +14 | 0 replies | |
| 2/8 | add helper get_nth_expression()lib.h verify-format.c | +5 | 0 replies | |
| 3/8 | move the definition of FMT_{PRINTF,SCANF}parse.c symbol.h | +7 | 0 replies | |
| 4/8 | parse format attribute less verboselyparse.c | +12 | 0 replies | |
| 5/8 | call verify_format_attribute() unconditionallyevaluate.c verify-format.c | +3 | 0 replies | |
| 6/8 | s/data/type/ for struct format_typeverify-format.c | +15 | 0 replies | |
| 7/8 | add support for "%ls"verify-format.c | +6 | 0 replies | |
| 8/8 | add support for "%Lx" (and "%Ls")verify-format.c | +3 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/8] format check tweaks
Ben, these are small changes I think should be applied with your series, on top of the patches I send yesterday. I've pushed everything at:
git://github.com/lucvoo/sparse-dev.git format-check
If you're fine with these, I can squeeze them with the series.
There are also a few tests I don't agree with:
const void *ptr = ...
printf("%s", ptr);These tests silently accept this, but they should warn. But this can be fixed at a later step.
Luc Van Oostenryck (8):
need to strip SYM_NODE before comparing types
add helper get_nth_expression()
move the definition of FMT_{PRINTF,SCANF}
parse format attribute less verbosely
call verify_format_attribute() unconditionally
s/data/type/ for struct format_type
add support for "%ls"
add support for "%Lx" (and "%Ls")
evaluate.c | 4 +-- lib.h | 5 +++ parse.c | 30 +++++++---------- symbol.h | 7 ++++ validation/varargs-format-dyn-prec.c | 11 ++++++ verify-format.c | 50 ++++++++++++++++------------ 6 files changed, 65 insertions(+), 42 deletions(-) create mode 100644 validation/varargs-format-dyn-prec.c
Signature · 1 line
2.28.0