Skip to content

format check tweaks

Luc Van Oostenryck linux-sparse 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8need to strip SYM_NODE before comparing typesvalidation/varargs-format-dyn-prec.c verify-format.c+14 -00 replies
2/8add helper get_nth_expression()lib.h verify-format.c+5 -50 replies
3/8move the definition of FMT_{PRINTF,SCANF}parse.c symbol.h+7 -60 replies
4/8parse format attribute less verboselyparse.c+12 -120 replies
5/8call verify_format_attribute() unconditionallyevaluate.c verify-format.c+3 -30 replies
6/8s/data/type/ for struct format_typeverify-format.c+15 -150 replies
7/8add support for "%ls"verify-format.c+6 -10 replies
8/8add support for "%Lx" (and "%Ls")verify-format.c+3 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/8] format check tweaks

Ben, these are small changes I think should be applied with your series, on top of the patches I send yesterday. I've pushed everything at:
git://github.com/lucvoo/sparse-dev.git format-check
If you're fine with these, I can squeeze them with the series.

There are also a few tests I don't agree with:

	const void *ptr = ...
	printf("%s", ptr);

These tests silently accept this, but they should warn. But this can be fixed at a later step.

Luc Van Oostenryck (8):
need to strip SYM_NODE before comparing types
add helper get_nth_expression()
move the definition of FMT_{PRINTF,SCANF}
parse format attribute less verbosely
call verify_format_attribute() unconditionally
s/data/type/ for struct format_type
add support for "%ls"
add support for "%Lx" (and "%Ls")

 evaluate.c                           |  4 +--
 lib.h                                |  5 +++
 parse.c                              | 30 +++++++----------
 symbol.h                             |  7 ++++
 validation/varargs-format-dyn-prec.c | 11 ++++++
 verify-format.c                      | 50 ++++++++++++++++------------
 6 files changed, 65 insertions(+), 42 deletions(-)
 create mode 100644 validation/varargs-format-dyn-prec.c
Signature · 1 line
2.28.0