Skip to content

nft: Fix transaction refreshing

Phil Sutter netfilter-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3nft: Make batch_add_chain() return the added batch objectiptables/nft.c+17 -181 reply
2/3nft: Fix error reporting for refreshed transactionsiptables/nft.c+3 -21 reply
3/3nft: Fix for concurrent noflush restore callsiptables/nft.c iptables/tests/shell/testcases/ipt-restore/0016-concurrent-restores_0+83 -287 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchFlorian Westphal
1/3R-b
2/3R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [iptables PATCH 0/3] nft: Fix transaction refreshing

With iptables-nft-restore in --noflush mode, the created batch job list may need to be adjusted to a changing ruleset in kernel. In particular, an input line like ':FOO - [0:0]' either means "flush chain FOO" or "create chain FOO" depending on whether it exists already or not. Patch 3 contains a test case provoking this peculiar situation and fixes the transaction prepare and refresh logic in that case. Patch 1 is a simple preparation change, patch 2 a somewhat related fix for error reporting with refreshed transactions.

Phil Sutter (3):
nft: Make batch_add_chain() return the added batch object
nft: Fix error reporting for refreshed transactions
nft: Fix for concurrent noflush restore calls

 iptables/nft.c                                | 96 ++++++++++---------
 .../ipt-restore/0016-concurrent-restores_0    | 53 ++++++++++
 2 files changed, 102 insertions(+), 47 deletions(-)
 create mode 100755 iptables/tests/shell/testcases/ipt-restore/0016-concurrent-restores_0
Signature · 1 line
2.28.0