Skip to content

KVM: VMX: x2APIC + APICV MSR fix and cleanup

Sean Christopherson kvm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2KVM: VMX: Fix x2APIC MSR intercept handling on !APICV platformsarch/x86/kvm/vmx/vmx.c+3 -20 replies
2/2KVM: VMX: Ignore userspace MSR filters for x2APIC when APICV is enabledarch/x86/kvm/vmx/vmx.c+30 -163 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

PatchPeter Xu
1/2Not-signed-off-by
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] KVM: VMX: x2APIC + APICV MSR fix and cleanup

Patch 1 is an unofficial patch from Peter to fix x2APIC MSR interception on non-APICV systems. As Peter suggested, it really should be squashed with commit 3eb900173c71 ("KVM: x86: VMX: Prevent MSR passthrough when MSR access is denied"). Without the fix, KVM is completely busted on non-APICV systems.

Patch 2 is a cleanup of sorts to revert back to the pre-filtering approach of initializing the x2APIC MSR bitmaps for APICV.

Note, I haven't tested on an APICV system. My APICV system appears to have crashed over the weekend and I haven't yet journeyed back to the lab to kick it.

Peter Xu (1):
KVM: VMX: Fix x2APIC MSR intercept handling on !APICV platforms

Sean Christopherson (1):
KVM: VMX: Ignore userspace MSR filters for x2APIC when APICV is
enabled

 arch/x86/kvm/vmx/vmx.c | 45 ++++++++++++++++++++++++++++--------------
 1 file changed, 30 insertions(+), 15 deletions(-)
Signature · 1 line
2.28.0