Skip to content

log: Add commands for manipulating filters

Sean Anderson u-boot 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest22 patches 0 repliesNew
  2. v323 patches 0 repliesSuperseded
  3. v222 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v118 patches0 repliesSuperseded

Changes in v4 from the cover letter

- Add a space in between the <= operator and the log level
- Add some more examples to docs
- Rebase onto master
- Remove "log: Add new category names to log_cat_name" since it has been superseded.
- Wrap UCLASS_ literals with log_uc_cat when used as log categories

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22log: Fix missing negation of ENOMEMcommon/log.c+1 -11 reply
2/22log: Fix incorrect documentation of log_filter.cat_listinclude/log.h+2 -21 reply
3/22log: Add additional const qualifier to arrayscommon/log.c+2 -21 reply
4/22log: Use CONFIG_IS_ENABLED() for LOG_TESTcmd/log.c+2 -21 reply
5/22log: Expose some helper functionscommon/log.c include/log.h+34 -201 reply
6/22log: Add function to create a filter with flagscommon/log.c include/log.h+31 -41 reply
7/22log: Add filter flag to deny on matchcommon/log.c include/log.h+20 -31 reply
8/22test: log: Convert log_test from python to Ccmd/log.c include/test/log.h test/log/log_test.c +2 more+260 -3001 reply
9/22test: log: Give tests names instead of numberstest/log/log_test.c+24 -241 reply
10/22test: Add tests for LOGFF_DENYtest/log/log_test.c+67 -01 reply
11/22log: Add filter flag to match greater than a log levelcommon/log.c include/log.h+15 -71 reply
12/22test: Add test for LOGFF_MINtest/log/log_test.c+23 -01 reply
13/22cmd: log: Use sub-commands for logcmd/log.c+4 -271 reply
14/22cmd: log: Split off log level parsingcmd/log.c+23 -61 reply
15/22cmd: log: Add commands to list categories and driverscmd/log.c common/log.c include/log.h+39 -21 reply
16/22cmd: log: Make "log level" print all log levelscmd/log.c+9 -31 reply
17/22lib: Add getoptMAINTAINERS doc/api/getopt.rst doc/api/index.rst +4 more+271 -01 reply
18/22test: Add a test for getopttest/lib/Makefile test/lib/getopt.c+124 -01 reply
19/22cmd: log: Add commands to manipulate filterscmd/Kconfig cmd/log.c+242 -01 reply
20/22test: Add a test for log filter-*include/test/log.h test/log/Makefile test/log/log_filter.c+110 -01 reply
21/22doc: Add log kerneldocs to documentationdoc/develop/logging.rst include/log.h+95 -521 reply
22/22doc: Update logging documentationdoc/develop/logging.rst+110 -1111 reply

Reviews trailers per patch

18 of 22 patches have a Reviewed-by or Acked-by.

PatchHeinrich SchuchardtSimon Glass
1/22R-b
2/22R-b
3/22R-b
4/22R-b
5/22R-b
6/22R-b
7/22R-b
8/22
9/22
10/22R-b
11/22R-b
12/22R-b
13/22R-b
14/22R-b
15/22R-b
16/22R-b
17/22
18/22
19/22R-b
20/22R-b
21/22R-b
22/22R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 00/22] log: Add commands for manipulating filters

This series adds several commands for adding, listing, and removing log filters. It also adds getopt, since the filter-add command needs to have several optional arguments to be complete, and positional specification of those arguments would have been difficult.

Passing CI:
https://dev.azure.com/seanga2/u-boot/_build/results?buildId=58&view=results

Changes in v4:
- Add a space in between the <= operator and the log level
- Add some more examples to docs
- Rebase onto master
- Remove "log: Add new category names to log_cat_name" since it has been superseded.
- Wrap UCLASS_ literals with log_uc_cat when used as log categories

Changes in v3:
- Convert log_test from python to C
- Document assumption that erroneous results from log_get_cat_name begin with '<'
- Fix heading level of Filters section
- Remove a few more already-implemented features from the TODO list
- Update copyright for log_filter.c

Changes in v2:
- Add % before constants in kerneldocs
- Add a few informational commands
- Add const qualifier to log_*_name
- Add option to remove all filters to filter-remove
- Clarify filter-* help text
- Clarify wording of filter documentation
- Converted log filter-* tests to C from python
- Document log_level_t and log_category_t members
- Expand documentation of getopt() to include examples
- Expose log_has_cat and log_has_file for filter tests
- Include enum definitions instead of re-documenting them
- Print an error message if the log level is invalid.
- Remove opt prefix from getopt_state members
- Reorganize log documentation; related sections should now be more proximate

Sean Anderson (22):
log: Fix missing negation of ENOMEM
log: Fix incorrect documentation of log_filter.cat_list
log: Add additional const qualifier to arrays
log: Use CONFIG_IS_ENABLED() for LOG_TEST
log: Expose some helper functions
log: Add function to create a filter with flags
log: Add filter flag to deny on match
test: log: Convert log_test from python to C
test: log: Give tests names instead of numbers
test: Add tests for LOGFF_DENY
log: Add filter flag to match greater than a log level
test: Add test for LOGFF_MIN
cmd: log: Use sub-commands for log
cmd: log: Split off log level parsing
cmd: log: Add commands to list categories and drivers
cmd: log: Make "log level" print all log levels
lib: Add getopt
test: Add a test for getopt
cmd: log: Add commands to manipulate filters
test: Add a test for log filter-*
doc: Add log kerneldocs to documentation
doc: Update logging documentation

 MAINTAINERS               |   1 +
 cmd/Kconfig               |   1 +
 cmd/log.c                 | 354 ++++++++++++++++++++++---
 common/log.c              |  58 ++---
 doc/api/getopt.rst        |   8 +
 doc/api/index.rst         |   1 +
 doc/develop/logging.rst   | 224 ++++++++--------
 include/getopt.h          | 130 +++++++++
 include/log.h             | 212 +++++++++++----
 include/test/log.h        |   3 +
 lib/Kconfig               |   5 +
 lib/Makefile              |   1 +
 lib/getopt.c              | 125 +++++++++
 test/lib/Makefile         |   1 +
 test/lib/getopt.c         | 123 +++++++++
 test/log/Makefile         |   1 +
 test/log/log_filter.c     | 108 ++++++++
 test/log/log_test.c       | 536 +++++++++++++++++++++++++-------------
 test/log/syslog_test.h    |   2 -
 test/py/tests/test_log.py | 104 --------
 20 files changed, 1470 insertions(+), 528 deletions(-)
 create mode 100644 doc/api/getopt.rst
 create mode 100644 include/getopt.h
 create mode 100644 lib/getopt.c
 create mode 100644 test/lib/getopt.c
 create mode 100644 test/log/log_filter.c
Signature · 1 line
2.28.0