log: Add commands for manipulating filters
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest22 patches 0 repliesNew
- v323 patches 0 repliesSuperseded
- v222 patches 0 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 18 patches | 0 replies | Superseded |
Changes in v4 from the cover letter
- Add a space in between the <= operator and the log level
- Add some more examples to docs
- Rebase onto master
- Remove "log: Add new category names to log_cat_name" since it has been superseded.
- Wrap UCLASS_ literals with log_uc_cat when used as log categories
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/22 | log: Fix missing negation of ENOMEMcommon/ | +1 | 1 reply | |
| 2/22 | log: Fix incorrect documentation of log_filter.cat_listinclude/ | +2 | 1 reply | |
| 3/22 | log: Add additional const qualifier to arrayscommon/ | +2 | 1 reply | |
| 4/22 | log: Use CONFIG_IS_ENABLED() for LOG_TESTcmd/ | +2 | 1 reply | |
| 5/22 | log: Expose some helper functionscommon/ include/ | +34 | 1 reply | |
| 6/22 | log: Add function to create a filter with flagscommon/ include/ | +31 | 1 reply | |
| 7/22 | log: Add filter flag to deny on matchcommon/ include/ | +20 | 1 reply | |
| 8/22 | test: log: Convert log_test from python to Ccmd/ include/ test/ +2 more | +260 | 1 reply | |
| 9/22 | test: log: Give tests names instead of numberstest/ | +24 | 1 reply | |
| 10/22 | test: Add tests for LOGFF_DENYtest/ | +67 | 1 reply | |
| 11/22 | log: Add filter flag to match greater than a log levelcommon/ include/ | +15 | 1 reply | |
| 12/22 | test: Add test for LOGFF_MINtest/ | +23 | 1 reply | |
| 13/22 | cmd: log: Use sub-commands for logcmd/ | +4 | 1 reply | |
| 14/22 | cmd: log: Split off log level parsingcmd/ | +23 | 1 reply | |
| 15/22 | cmd: log: Add commands to list categories and driverscmd/ common/ include/ | +39 | 1 reply | |
| 16/22 | cmd: log: Make "log level" print all log levelscmd/ | +9 | 1 reply | |
| 17/22 | lib: Add getoptMAINTAINERS doc/ doc/ +4 more | +271 | 1 reply | |
| 18/22 | test: Add a test for getopttest/ test/ | +124 | 1 reply | |
| 19/22 | cmd: log: Add commands to manipulate filterscmd/ cmd/ | +242 | 1 reply | |
| 20/22 | test: Add a test for log filter-*include/ test/ test/ | +110 | 1 reply | |
| 21/22 | doc: Add log kerneldocs to documentationdoc/ include/ | +95 | 1 reply | |
| 22/22 | doc: Update logging documentationdoc/ | +110 | 1 reply |
Reviews trailers per patch
18 of 22 patches have a Reviewed-by or Acked-by.
| Patch | Heinrich Schuchardt | Simon Glass |
|---|---|---|
| 1/22 | R-b | |
| 2/22 | R-b | |
| 3/22 | R-b | |
| 4/22 | R-b | |
| 5/22 | R-b | |
| 6/22 | R-b | |
| 7/22 | R-b | |
| 8/22 | ||
| 9/22 | ||
| 10/22 | R-b | |
| 11/22 | R-b | |
| 12/22 | R-b | |
| 13/22 | R-b | |
| 14/22 | R-b | |
| 15/22 | R-b | |
| 16/22 | R-b | |
| 17/22 | ||
| 18/22 | ||
| 19/22 | R-b | |
| 20/22 | R-b | |
| 21/22 | R-b | |
| 22/22 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 00/22] log: Add commands for manipulating filters
This series adds several commands for adding, listing, and removing log filters. It also adds getopt, since the filter-add command needs to have several optional arguments to be complete, and positional specification of those arguments would have been difficult.
Passing CI:
https://dev.azure.com/seanga2/u-boot/_build/results?buildId=58&view=results
Changes in v4:
- Add a space in between the <= operator and the log level
- Add some more examples to docs
- Rebase onto master
- Remove "log: Add new category names to log_cat_name" since it has been superseded.
- Wrap UCLASS_ literals with log_uc_cat when used as log categories
Changes in v3:
- Convert log_test from python to C
- Document assumption that erroneous results from log_get_cat_name begin with '<'
- Fix heading level of Filters section
- Remove a few more already-implemented features from the TODO list
- Update copyright for log_filter.c
Changes in v2:
- Add % before constants in kerneldocs
- Add a few informational commands
- Add const qualifier to log_*_name
- Add option to remove all filters to filter-remove
- Clarify filter-* help text
- Clarify wording of filter documentation
- Converted log filter-* tests to C from python
- Document log_level_t and log_category_t members
- Expand documentation of getopt() to include examples
- Expose log_has_cat and log_has_file for filter tests
- Include enum definitions instead of re-documenting them
- Print an error message if the log level is invalid.
- Remove opt prefix from getopt_state members
- Reorganize log documentation; related sections should now be more proximate
Sean Anderson (22):
log: Fix missing negation of ENOMEM
log: Fix incorrect documentation of log_filter.cat_list
log: Add additional const qualifier to arrays
log: Use CONFIG_IS_ENABLED() for LOG_TEST
log: Expose some helper functions
log: Add function to create a filter with flags
log: Add filter flag to deny on match
test: log: Convert log_test from python to C
test: log: Give tests names instead of numbers
test: Add tests for LOGFF_DENY
log: Add filter flag to match greater than a log level
test: Add test for LOGFF_MIN
cmd: log: Use sub-commands for log
cmd: log: Split off log level parsing
cmd: log: Add commands to list categories and drivers
cmd: log: Make "log level" print all log levels
lib: Add getopt
test: Add a test for getopt
cmd: log: Add commands to manipulate filters
test: Add a test for log filter-*
doc: Add log kerneldocs to documentation
doc: Update logging documentation
MAINTAINERS | 1 + cmd/Kconfig | 1 + cmd/log.c | 354 ++++++++++++++++++++++--- common/log.c | 58 ++--- doc/api/getopt.rst | 8 + doc/api/index.rst | 1 + doc/develop/logging.rst | 224 ++++++++-------- include/getopt.h | 130 +++++++++ include/log.h | 212 +++++++++++---- include/test/log.h | 3 + lib/Kconfig | 5 + lib/Makefile | 1 + lib/getopt.c | 125 +++++++++ test/lib/Makefile | 1 + test/lib/getopt.c | 123 +++++++++ test/log/Makefile | 1 + test/log/log_filter.c | 108 ++++++++ test/log/log_test.c | 536 +++++++++++++++++++++++++------------- test/log/syslog_test.h | 2 - test/py/tests/test_log.py | 104 -------- 20 files changed, 1470 insertions(+), 528 deletions(-) create mode 100644 doc/api/getopt.rst create mode 100644 include/getopt.h create mode 100644 lib/getopt.c create mode 100644 test/lib/getopt.c create mode 100644 test/log/log_filter.c
Signature · 1 line
2.28.0