python/qemu: strictly typed mypy conversion, pt2
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest20 patches 32 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/20 | python/qemu: use isort to lay out importspython/ python/ python/ +3 more | +19 | 2 replies | |
| 2/20 | python/machine.py: Fix monitor address typingpython/ | +25 | 0 replies | |
| 3/20 | python/machine.py: reorder __init__python/ | +25 | 3 replies | |
| 4/20 | python/machine.py: Don't modify state in _base_args()python/ python/ | +14 | 0 replies | |
| 5/20 | python/machine.py: Handle None events in events_waitpython/ | +20 | 0 replies | |
| 6/20 | python/machine.py: use qmp.commandpython/ | +20 | 1 reply | |
| 7/20 | python/machine.py: Add _qmp access shimpython/ | +13 | 2 replies | |
| 8/20 | python/machine.py: fix _popen accesspython/ | +11 | 4 replies | |
| 9/20 | python/qemu: make 'args' style arguments immutablepython/ python/ | +34 | 1 reply | |
| 10/20 | iotests.py: Adjust HMP kwargs typingtests/ | +1 | 0 replies | |
| 11/20 | python/qemu: Add mypy type annotationspython/ python/ python/ +1 more | +101 | 2 replies | |
| 12/20 | python/qemu/console_socket.py: Correct type of recv()python/ | +3 | 2 replies | |
| 13/20 | python/qemu/console_socket.py: fix typing of settimeoutpython/ | +6 | 1 reply | |
| 14/20 | python/qemu/console_socket.py: Clarify type of drain_threadpython/ | +1 | 1 reply | |
| 15/20 | python/qemu/console_socket.py: Add type hint annotationspython/ | +9 | 1 reply | |
| 16/20 | python/console_socket: avoid encoding to/from stringpython/ | +5 | 1 reply | |
| 17/20 | python/qemu/qmp.py: Preserve error context on re-raisepython/ | +5 | 3 replies | |
| 18/20 | python/qemu/qmp.py: re-raise OSError when encounteredpython/ | +3 | 4 replies | |
| 19/20 | python/qemu/qmp.py: Straighten out exception hierarchypython/ | +30 | 1 reply | |
| 20/20 | python: add mypy configpython/ | +4 | 2 replies |
Reviews trailers per patch
19 of 20 patches have a Reviewed-by or Acked-by.
| Patch | Kevin Wolf | Philippe Mathieu-Daudé |
|---|---|---|
| 1/20 | R-b | R-b |
| 2/20 | R-b | |
| 3/20 | R-b | R-b |
| 4/20 | R-b | |
| 5/20 | R-b | |
| 6/20 | R-b | R-b |
| 7/20 | R-b | |
| 8/20 | R-b | |
| 9/20 | R-b | R-b |
| 10/20 | R-b | |
| 11/20 | R-b | |
| 12/20 | R-b | |
| 13/20 | R-b | |
| 14/20 | R-b | |
| 15/20 | R-b | |
| 16/20 | R-b | |
| 17/20 | R-b | R-b |
| 18/20 | R-b | |
| 19/20 | R-b | |
| 20/20 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 00/20] python/qemu: strictly typed mypy conversion, pt2
Continuing where I left off prior to the 5.1 release, this series touches up a few odds and ends and introduces mypy hints.
What's new:
- Using isort to solidify import order
- Patches adding small corrections and typing for console_socket
- A few error class changes for qmp.py
Like my QAPI series, this requires:
- pylint >= 2.6.0
- flake8 >= 3.8.0
- mypy >= 0.770
- isort >= 4.3.0 (Presumably...)
What this series doesn't do:
- Create a proper python package
- Establish a CI test to prevent regressions
- Fix the docstring conventions in the library
Those are coming soon! (and in the order mentioned.)
Changes against the last version of this series that was sent prior to 5.1:
001/20:[down] 'python/qemu: use isort to lay out imports' 002/20:[0005] [FC] 'python/machine.py: Fix monitor address typing' 003/20:[0015] [FC] 'python/machine.py: reorder __init__' 004/20:[0009] [FC] 'python/machine.py: Don't modify state in _base_args()' 005/20:[0002] [FC] 'python/machine.py: Handle None events in events_wait' 006/20:[0006] [FC] 'python/machine.py: use qmp.command' 007/20:[----] [-C] 'python/machine.py: Add _qmp access shim' 008/20:[----] [-C] 'python/machine.py: fix _popen access' 009/20:[0006] [FC] 'python/qemu: make 'args' style arguments immutable' 010/20:[----] [--] 'iotests.py: Adjust HMP kwargs typing' 011/20:[0010] [FC] 'python/qemu: Add mypy type annotations' 012/20:[down] 'python/qemu/console_socket.py: Correct type of recv()' 013/20:[down] 'python/qemu/console_socket.py: fix typing of settimeout' 014/20:[down] 'python/qemu/console_socket.py: Clarify type of drain_thread' 015/20:[down] 'python/qemu/console_socket.py: Add type hint annotations' 016/20:[down] 'python/console_socket: avoid encoding to/from string' 017/20:[down] 'python/qemu/qmp.py: Preserve error context on re-raise' 018/20:[down] 'python/qemu/qmp.py: re-raise OSError when encountered' 019/20:[down] 'python/qemu/qmp.py: Straighten out exception hierarchy' 020/20:[down] 'python: add mypy config'
02: import order differences, context changes from console_socket.py 03: (minor) changes for console_socket, RB-s dropped just in case 04: import order differences
05: import order differences
06: import order differences
09: import order differences
11: import order differences, small changes for console_socket
John Snow (20):
python/qemu: use isort to lay out imports python/machine.py: Fix monitor address typing python/machine.py: reorder __init__ python/machine.py: Don't modify state in _base_args() python/machine.py: Handle None events in events_wait python/machine.py: use qmp.command python/machine.py: Add _qmp access shim python/machine.py: fix _popen access
python/qemu: make 'args' style arguments immutable iotests.py: Adjust HMP kwargs typing
python/qemu: Add mypy type annotations python/qemu/console_socket.py: Correct type of recv() python/qemu/console_socket.py: fix typing of settimeout python/qemu/console_socket.py: Clarify type of drain_thread python/qemu/console_socket.py: Add type hint annotations python/console_socket: avoid encoding to/from string python/qemu/qmp.py: Preserve error context on re-raise python/qemu/qmp.py: re-raise OSError when encountered python/qemu/qmp.py: Straighten out exception hierarchy
python: add mypy config
python/mypy.ini | 4 + python/qemu/.isort.cfg | 7 + python/qemu/accel.py | 9 +- python/qemu/console_socket.py | 54 +++--- python/qemu/machine.py | 306 +++++++++++++++++++++------------- python/qemu/qmp.py | 114 ++++++++----- python/qemu/qtest.py | 55 +++--- tests/qemu-iotests/iotests.py | 2 +- 8 files changed, 331 insertions(+), 220 deletions(-) create mode 100644 python/mypy.ini create mode 100644 python/qemu/.isort.cfg
Signature · 1 line
2.26.2