Skip to content

python/qemu: strictly typed mypy conversion, pt2

John Snow qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest20 patches 32 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20python/qemu: use isort to lay out importspython/qemu/.isort.cfg python/qemu/accel.py python/qemu/console_socket.py +3 more+19 -112 replies
2/20python/machine.py: Fix monitor address typingpython/qemu/machine.py+25 -150 replies
3/20python/machine.py: reorder __init__python/qemu/machine.py+25 -193 replies
4/20python/machine.py: Don't modify state in _base_args()python/qemu/machine.py python/qemu/qtest.py+14 -100 replies
5/20python/machine.py: Handle None events in events_waitpython/qemu/machine.py+20 -70 replies
6/20python/machine.py: use qmp.commandpython/qemu/machine.py+20 -121 reply
7/20python/machine.py: Add _qmp access shimpython/qemu/machine.py+13 -112 replies
8/20python/machine.py: fix _popen accesspython/qemu/machine.py+11 -54 replies
9/20python/qemu: make 'args' style arguments immutablepython/qemu/machine.py python/qemu/qtest.py+34 -181 reply
10/20iotests.py: Adjust HMP kwargs typingtests/qemu-iotests/iotests.py+1 -10 replies
11/20python/qemu: Add mypy type annotationspython/qemu/accel.py python/qemu/machine.py python/qemu/qmp.py +1 more+101 -752 replies
12/20python/qemu/console_socket.py: Correct type of recv()python/qemu/console_socket.py+3 -22 replies
13/20python/qemu/console_socket.py: fix typing of settimeoutpython/qemu/console_socket.py+6 -41 reply
14/20python/qemu/console_socket.py: Clarify type of drain_threadpython/qemu/console_socket.py+1 -21 reply
15/20python/qemu/console_socket.py: Add type hint annotationspython/qemu/console_socket.py+9 -91 reply
16/20python/console_socket: avoid encoding to/from stringpython/qemu/console_socket.py+5 -151 reply
17/20python/qemu/qmp.py: Preserve error context on re-raisepython/qemu/qmp.py+5 -43 replies
18/20python/qemu/qmp.py: re-raise OSError when encounteredpython/qemu/qmp.py+3 -34 replies
19/20python/qemu/qmp.py: Straighten out exception hierarchypython/qemu/qmp.py+30 -151 reply
20/20python: add mypy configpython/mypy.ini+4 -02 replies

Reviews trailers per patch

19 of 20 patches have a Reviewed-by or Acked-by.

PatchKevin WolfPhilippe Mathieu-Daudé
1/20R-b R-b
2/20R-b
3/20R-b R-b
4/20R-b
5/20R-b
6/20R-b R-b
7/20R-b
8/20R-b
9/20R-b R-b
10/20R-b
11/20R-b
12/20R-b
13/20R-b
14/20R-b
15/20R-b
16/20R-b
17/20R-b R-b
18/20R-b
19/20R-b
20/20

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/20] python/qemu: strictly typed mypy conversion, pt2

Continuing where I left off prior to the 5.1 release, this series touches up a few odds and ends and introduces mypy hints.

What's new:

- Using isort to solidify import order
- Patches adding small corrections and typing for console_socket
- A few error class changes for qmp.py

Like my QAPI series, this requires:

- pylint >= 2.6.0
- flake8 >= 3.8.0
- mypy >= 0.770
- isort >= 4.3.0 (Presumably...)

What this series doesn't do:

- Create a proper python package
- Establish a CI test to prevent regressions
- Fix the docstring conventions in the library

Those are coming soon! (and in the order mentioned.)

Changes against the last version of this series that was sent prior to 5.1:

001/20:[down] 'python/qemu: use isort to lay out imports' 002/20:[0005] [FC] 'python/machine.py: Fix monitor address typing' 003/20:[0015] [FC] 'python/machine.py: reorder __init__' 004/20:[0009] [FC] 'python/machine.py: Don't modify state in _base_args()' 005/20:[0002] [FC] 'python/machine.py: Handle None events in events_wait' 006/20:[0006] [FC] 'python/machine.py: use qmp.command' 007/20:[----] [-C] 'python/machine.py: Add _qmp access shim' 008/20:[----] [-C] 'python/machine.py: fix _popen access' 009/20:[0006] [FC] 'python/qemu: make 'args' style arguments immutable' 010/20:[----] [--] 'iotests.py: Adjust HMP kwargs typing' 011/20:[0010] [FC] 'python/qemu: Add mypy type annotations' 012/20:[down] 'python/qemu/console_socket.py: Correct type of recv()' 013/20:[down] 'python/qemu/console_socket.py: fix typing of settimeout' 014/20:[down] 'python/qemu/console_socket.py: Clarify type of drain_thread' 015/20:[down] 'python/qemu/console_socket.py: Add type hint annotations' 016/20:[down] 'python/console_socket: avoid encoding to/from string' 017/20:[down] 'python/qemu/qmp.py: Preserve error context on re-raise' 018/20:[down] 'python/qemu/qmp.py: re-raise OSError when encountered' 019/20:[down] 'python/qemu/qmp.py: Straighten out exception hierarchy' 020/20:[down] 'python: add mypy config'

02: import order differences, context changes from console_socket.py 03: (minor) changes for console_socket, RB-s dropped just in case 04: import order differences
05: import order differences
06: import order differences
09: import order differences
11: import order differences, small changes for console_socket

John Snow (20):
python/qemu: use isort to lay out imports python/machine.py: Fix monitor address typing python/machine.py: reorder __init__ python/machine.py: Don't modify state in _base_args() python/machine.py: Handle None events in events_wait python/machine.py: use qmp.command python/machine.py: Add _qmp access shim python/machine.py: fix _popen access
python/qemu: make 'args' style arguments immutable iotests.py: Adjust HMP kwargs typing
python/qemu: Add mypy type annotations python/qemu/console_socket.py: Correct type of recv() python/qemu/console_socket.py: fix typing of settimeout python/qemu/console_socket.py: Clarify type of drain_thread python/qemu/console_socket.py: Add type hint annotations python/console_socket: avoid encoding to/from string python/qemu/qmp.py: Preserve error context on re-raise python/qemu/qmp.py: re-raise OSError when encountered python/qemu/qmp.py: Straighten out exception hierarchy
python: add mypy config

 python/mypy.ini               |   4 +
 python/qemu/.isort.cfg        |   7 +
 python/qemu/accel.py          |   9 +-
 python/qemu/console_socket.py |  54 +++---
 python/qemu/machine.py        | 306 +++++++++++++++++++++-------------
 python/qemu/qmp.py            | 114 ++++++++-----
 python/qemu/qtest.py          |  55 +++---
 tests/qemu-iotests/iotests.py |   2 +-
 8 files changed, 331 insertions(+), 220 deletions(-)
 create mode 100644 python/mypy.ini
 create mode 100644 python/qemu/.isort.cfg
Signature · 1 line
2.26.2