Skip to content

net, mac80211, kernel: enable KCOV remote coverage collection for 802.11 frame handling

Aleksandr Nogikh linux-wireless lkml netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 8 repliesIn review
  2. v12 patches 12 repliesSuperseded

Changes in v2 from the cover letter

* Moved KCOV annotations from ieee80211_tasklet_handler to ieee80211_rx.
* Updated kcov_common_handle() to return 0 if it is called in interrupt context.
* Updated the cover letter.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3kernel: make kcov_common_handle consider the current contextkernel/kcov.c+2 -01 reply
2/3net: store KCOV remote handle in sk_buffinclude/linux/skbuff.h net/core/skbuff.c+22 -00 replies
3/3mac80211: add KCOV remote annotations to incoming frame processinginclude/net/mac80211.h net/mac80211/iface.c+4 -00 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchAndrey Konovalov
1/3R-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] [PATCH v2 0/3] [PATCH v2 0/3] net, mac80211, kernel: enable KCOV remote coverage collection for 802.11 frame handling

From: Aleksandr Nogikh <[email protected]>

This patch series enables remote KCOV coverage collection during 802.11 frames processing. These changes make it possible to perform coverage-guided fuzzing in search of remotely triggerable bugs.

Normally, KCOV collects coverage information for the code that is executed inside the system call context. It is easy to identify where that coverage should go and whether it should be collected at all by looking at the current process. If KCOV was enabled on that process, coverage will be stored in a buffer specific to that process. Howerever, it is not always enough as handling can happen elsewhere (e.g. in separate kernel threads).

When it is impossible to infer KCOV-related info just by looking at the currently running process, one needs to manually pass some information to the code that should be instrumented. The information takes the form of 64 bit integers (KCOV remote handles). Zero is the special value that corresponds to an empty handle. More details on KCOV and remote coverage collection can be found in Documentation/dev-tools/kcov.rst.

The series consists of three commits.
1. Apply a minor fix to kcov_common_handle() so that it returns a valid handle (zero) when called in an interrupt context.
2. Take the remote handle from KCOV and attach it to newly allocated SKBs. If the allocation happens inside a system call context, the SKB will be tied to the process that issued the syscall (if that process is interested in remote coverage collection).
3. Annotate the code that processes incoming 802.11 frames with kcov_remote_start()/kcov_remote_stop()

This patch series conflicts with another proposed patch
http://lkml.kernel.org/r/223901affc7bd759b2d6995c2dbfbdd0a29bc88a.1602248029.git.andreyknvl@google.com
One of these patches needs to be rebased once the other one is merged.

v2:
* Moved KCOV annotations from ieee80211_tasklet_handler to ieee80211_rx.
* Updated kcov_common_handle() to return 0 if it is called in interrupt context.
* Updated the cover letter.

v1: https://lkml.kernel.org/r/[email protected]

Aleksandr Nogikh (3):
kernel: make kcov_common_handle consider the current context
net: store KCOV remote handle in sk_buff
mac80211: add KCOV remote annotations to incoming frame processing

 include/linux/skbuff.h | 21 +++++++++++++++++++++
 include/net/mac80211.h |  2 ++
 kernel/kcov.c          |  2 ++
 net/core/skbuff.c      |  1 +
 net/mac80211/iface.c   |  2 ++
 5 files changed, 28 insertions(+)

base-commit: a804ab086e9de200e2e70600996db7fc14c91959

Signature · 1 line
2.28.0.1011.ga647a8990f-goog