Skip to content

openat2: reject RESOLVE_BENEATH|RESOLVE_IN_ROOT

Aleksa Sarai containers linux-fsdevel linux-kselftest lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 1 replyIn review
  2. v11 patch 3 repliesSuperseded

Changelog from the cover letter

v2: Split patch so as to separate selftest changes. [Shuah Khan]
v1: <https://lore.kernel.org/lkml/[email protected]/>

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2openat2: reject RESOLVE_BENEATH|RESOLVE_IN_ROOTfs/open.c+4 -00 replies
2/2selftests: openat2: add RESOLVE_ conflict testtools/testing/selftests/openat2/openat2_test.c+7 -10 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchChristian Brauner
1/2A-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] openat2: reject RESOLVE_BENEATH|RESOLVE_IN_ROOT

This was an oversight in the original implementation, as it makes no sense to specify both scoping flags to the same openat2(2) invocation (before this patch, the result of such an invocation was equivalent to RESOLVE_IN_ROOT being ignored).

This is a userspace-visible ABI change, but the only user of openat2(2) at the moment is LXC which doesn't specify both flags and so no userspace programs will break as a result.

Changelog:
v2: Split patch so as to separate selftest changes. [Shuah Khan]
v1: <https://lore.kernel.org/lkml/[email protected]/>

Aleksa Sarai (2):
openat2: reject RESOLVE_BENEATH|RESOLVE_IN_ROOT
selftests: openat2: add RESOLVE_ conflict test

 fs/open.c                                      | 4 ++++
 tools/testing/selftests/openat2/openat2_test.c | 8 +++++++-
 2 files changed, 11 insertions(+), 1 deletion(-)
Signature · 6 lines
2.29.0

_______________________________________________
Containers mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/containers