Skip to content

xfsprogs: consolidate stripe validation

Gao Xiang linux-xfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v4 Latest3 patches 8 repliesIn review

Changes in v4 from the cover letter

- mainly follow Eric suggestion mentioned in the reply of v3, e.g directly prints the error using xfs_notice/warn() and return bool;

- with an exception that it doesn't need the unit of sunit/swidth are in bytes if sectorsize is not specified, since the sanity check logic condition only needs these are in the same unit, so it saves calculation for these FSB / sector-based representation.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3xfsprogs: allow i18n to xfs printklibxfs/libxfs_priv.h+4 -42 replies
2/3xfs: introduce xfs_validate_stripe_factors()libxfs/xfs_sb.c libxfs/xfs_sb.h+46 -112 replies
3/3xfsprogs: make use of xfs_validate_stripe_factors()mkfs/xfs_mkfs.c+7 -164 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchDarrick J. Wong
1/3R-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/3] xfsprogs: consolidate stripe validation

From: Gao Xiang <[email protected]>

Hi,

v3: https://lore.kernel.org/r/[email protected]

This is another approach suggested by Eric in the reply of v3 (if I understand correctly), which also attempts to use i18n-enabled xfsprogs xfs_notice() to error out sanity check failure suggested by Dave on IRC.

In addition, I manually ported [PATCH 2/3] to the kernel side as well then fault injection with xfs_db and it seems work as expected.

Thanks,
Gao Xiang

changes since v3:
- mainly follow Eric suggestion mentioned in the reply of v3, e.g directly prints the error using xfs_notice/warn() and return bool;

- with an exception that it doesn't need the unit of sunit/swidth are in bytes if sectorsize is not specified, since the sanity check logic condition only needs these are in the same unit, so it saves calculation for these FSB / sector-based representation.

Gao Xiang (3):
xfsprogs: allow i18n to xfs printk
xfs: introduce xfs_validate_stripe_factors()
xfsprogs: make use of xfs_validate_stripe_factors()

 libxfs/libxfs_priv.h |  8 +++----
 libxfs/xfs_sb.c      | 54 +++++++++++++++++++++++++++++++++++---------
 libxfs/xfs_sb.h      |  3 +++
 mkfs/xfs_mkfs.c      | 23 ++++++-------------
 4 files changed, 57 insertions(+), 31 deletions(-)
Signature · 1 line
2.24.0