Skip to content

misc iomap/xfs writeback fixes

Brian Foster linux-fsdevel linux-xfs 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 12 repliesIn review
  2. v11 patch 2 repliesSuperseded

Changes in v2 from the cover letter

- Repost original XFS truncate down post-EOF zeroing fix.
- Pass file offset to iomap ->discard_page() callback.
- Add patch 3 to fix up iomap writepage error handling.
v1: https://lore.kernel.org/linux-xfs/[email protected]/

[1] https://lore.kernel.org/linux-xfs/[email protected]/

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3xfs: flush new eof page on truncate to avoid post-eof corruptionfs/xfs/xfs_iops.c+10 -03 replies
2/3iomap: support partial page discard on writeback block mapping failurefs/iomap/buffered-io.c fs/xfs/xfs_aops.c include/linux/iomap.h+16 -144 replies
2/3iomap: support partial page discard on writeback block mapping failurefs/iomap/buffered-io.c fs/xfs/xfs_aops.c include/linux/iomap.h+17 -142 replies
3/3iomap: clean up writeback state logic on writepage errorfs/iomap/buffered-io.c+2 -133 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchChristoph HellwigDarrick J. WongAllison Henderson
1/3R-b R-b R-b
2/3R-b R-b R-b R-b
2/3R-b R-b R-b R-b
3/3R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/3] misc iomap/xfs writeback fixes

Hi all,

Patch 1 is actually a repost of the original fix I posted[1] for the truncate down zeroing issue. Patch 2 has some minor tweaks based on feedback on v1 from Christoph. Patch 3 is new and fixes up some of the remaining broken iomap writepage error handling logic (also discussed in the v1 thread). Thoughts, reviews, flames appreciated.

Brian

v2:
- Repost original XFS truncate down post-EOF zeroing fix.
- Pass file offset to iomap ->discard_page() callback.
- Add patch 3 to fix up iomap writepage error handling.
v1: https://lore.kernel.org/linux-xfs/[email protected]/

[1] https://lore.kernel.org/linux-xfs/[email protected]/

Brian Foster (3):
xfs: flush new eof page on truncate to avoid post-eof corruption
iomap: support partial page discard on writeback block mapping failure
iomap: clean up writeback state logic on writepage error

 fs/iomap/buffered-io.c | 30 ++++++++++--------------------
 fs/xfs/xfs_aops.c      | 13 +++++++------
 fs/xfs/xfs_iops.c      | 10 ++++++++++
 include/linux/iomap.h  |  2 +-
 4 files changed, 28 insertions(+), 27 deletions(-)
Signature · 1 line
2.25.4