Skip to content

jt/threaded-inex-pack leftovers

Jeff King git lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3index-pack: restore "resolving deltas" progress meterbuiltin/index-pack.c t/t5302-pack-index.sh+11 -01 reply
2/3index-pack: drop type_cas mutexbuiltin/index-pack.c+0 -61 reply
3/3index-pack: stop mentioning find_unresolved_deltas()builtin/index-pack.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] jt/threaded-inex-pack leftovers
Quoted 6 lines · Junio C Hamano
Quoted 3 lines

That _seems_ to work fine, but I'm not sure why it was removed in the first place (for a good reason, or simply as an accident when rewriting the variable declarations at the top of the loop?).

The above looks like an obvious and trivial fix to go back closer to the original.

Yeah. I'd still like to get an ack from Jonathan, but having looked at it more deeply, I'm pretty sure it's the right thing.

Quoted 6 lines

We seem to have removed find_unresolved_deltas() helper function in that series, but there remains a mention to it in a comment, which we would probably should rethink (it just may be the matter of removing the mention, or if "just like in ..." may have been the last example of doing what the comment suggests all code to do, it may reveal a need for larger clean-up---I dunno).

I think the code just moved around and we can update the reference, though I admit I haven't fully thought through whether there are any other subtleties.

I also noticed one other small cleanup related to the series. So here are a few patches on top of jt/threaded-index-pack.

[1/3]: index-pack: restore "resolving deltas" progress meter [2/3]: index-pack: drop type_cas mutex
[3/3]: index-pack: stop mentioning find_unresolved_deltas()

 builtin/index-pack.c  | 12 +++++-------
 t/t5302-pack-index.sh |  7 +++++++
 2 files changed, 12 insertions(+), 7 deletions(-)

-Peff