Skip to content

docs: Clarify formatting for 'fmode' and 'dmode'

Brian Turek qemu-trivial 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1docs: Clarify formatting for 'fmode' and 'dmode'qemu-options.hx+6 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/1] docs: Clarify formatting for 'fmode' and 'dmode'

I sent the below patch to the dev mailing list on 6 Oct but then later discovered the trivial patch process. Hopefully it's OK that I'm mailing this separately as opposed to a CC on the original email.

The current documentation for the 'fmode' and 'dmode' options for fsdev/virtfs is ambiguous for the expected format of the values. The code itself parses the value using a call to strtoull with base=0 which causes values like "644" and "755" to be parsed as base-10 rather than base-8. This can cause unexpected behavior.

This patch changes the docmentation to be explicit on the expected format and mentions the fact that the setuid, setgid, and sticky bit are dropped.

Brian Turek (1):
docs: Clarify formatting for 'fmode' and 'dmode'

 qemu-options.hx | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
Signature · 1 line
2.25.1