Skip to content

Clean up legacy clock tick users

Arnd Bergmann linux-arm-kernel linux-ia64 linux-m68k linux-parisc lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest13 patches 29 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13timekeeping: add CONFIG_LEGACY_TIMER_TICKinclude/linux/timekeeping.h kernel/time/Kconfig kernel/time/Makefile +1 more+28 -03 replies
2/13ia64: convert to legacy_timer_tickarch/ia64/Kconfig arch/ia64/kernel/time.c+14 -230 replies
3/13ARM: rpc: use legacy_timer_tickarch/arm/Kconfig arch/arm/include/asm/mach/time.h arch/arm/kernel/time.c +1 more+2 -170 replies
4/13parisc: use legacy_timer_tickDocumentation/features/time/clockevents/arch-support.txt arch/parisc/Kconfig arch/parisc/kernel/time.c+5 -80 replies
5/13m68k: coldfire: use legacy_timer_tick()arch/m68k/Kconfig.cpu arch/m68k/coldfire/Makefile arch/m68k/coldfire/sltimers.c +1 more+51 -282 replies
6/13m68k: split heartbeat out of timer functionarch/m68k/amiga/config.c arch/m68k/apollo/config.c arch/m68k/atari/time.c +4 more+19 -21 reply
7/13m68k: sun3/sun3c: use legacy_timer_tickarch/m68k/Kconfig.machine arch/m68k/sun3/sun3ints.c arch/m68k/sun3x/time.c+4 -41 reply
8/13m68k: m68328: use legacy_timer_tick()arch/m68k/68000/timers.c arch/m68k/Kconfig.machine+6 -33 replies
9/13m68k: change remaining timers to legacy_timer_tickarch/m68k/Kconfig.machine arch/m68k/amiga/config.c arch/m68k/apollo/config.c +7 more+27 -311 reply
10/13m68k: remove timer_interrupt() functionarch/m68k/68000/timers.c arch/m68k/amiga/config.c arch/m68k/apollo/config.c +21 more+33 -471 reply
11/13timekeeping: remove xtime_updateinclude/linux/timekeeping.h kernel/time/tick-legacy.c kernel/time/timekeeping.c +1 more+22 -213 replies
12/13timekeeping: default GENERIC_CLOCKEVENTS to enabledDocumentation/features/time/clockevents/arch-support.txt arch/alpha/Kconfig arch/arc/Kconfig +22 more+4 -381 reply
13/13m68k: mac: convert to generic clockeventarch/m68k/Kconfig.machine arch/m68k/mac/via.c+37 -912 replies

Reviews trailers per patch

8 of 13 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchGreg UngererGeert UytterhoevenLinus Walleij
SeriesR-b
1/13R-b
2/13
3/13
4/13
5/13T-b
6/13R-b A-b T-b
7/13R-b A-b
8/13R-b
9/13R-b A-b T-b
10/13R-b A-b T-b
11/13R-b T-b
12/13R-b A-b T-b
13/13

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 00/13] Clean up legacy clock tick users

When I created the patch removing CONFIG_ARCH_GETTIMEOFFSET, I also had a look at CONFIG_GENERIC_CLOCKEVENTS, which is selected by most, but not all, platforms today, each of the ones that lack it doing the timer tick slightly differently.

The cleanups here make the old platforms a bit more consistent, in multiple ways:

- rather than selecting GENERIC_CLOCKEVENTS on modern platforms, select LEGACY_TIMER_TICK on the old ones.

- Hide some more of the internal implementation and only provide a single common entry point for the timer tick, which also makes the behavior more consistent.

- Remove the m68k and arm specific infrastructure pieces and call the common helper directly from each timer interrupt function.

I tested the series on m68k with the qemu q800 target platform, both with the legacy_timer_tick() implementation and after converting that to a periodic clockevent driver.

Arnd

Arnd Bergmann (13):
timekeeping: add CONFIG_LEGACY_TIMER_TICK
ia64: convert to legacy_timer_tick
ARM: rpc: use legacy_timer_tick
parisc: use legacy_timer_tick
m68k: coldfire: use legacy_timer_tick()
m68k: split heartbeat out of timer function
m68k: sun3/sun3c: use legacy_timer_tick
m68k: m68328: use legacy_timer_tick()
m68k: change remaining timers to legacy_timer_tick
m68k: remove timer_interrupt() function
timekeeping: remove xtime_update
timekeeping: default GENERIC_CLOCKEVENTS to enabled [RFC] m68k: mac: convert to generic clockevent

 .../time/clockevents/arch-support.txt         |  8 ++--
 arch/alpha/Kconfig                            |  1 -
 arch/arc/Kconfig                              |  1 -
 arch/arm/Kconfig                              | 13 +-----
 arch/arm/include/asm/mach/time.h              |  2 -
 arch/arm/kernel/time.c                        | 14 ------
 arch/arm/mach-rpc/time.c                      |  2 +-
 arch/arm64/Kconfig                            |  1 -
 arch/arm64/Kconfig.platforms                  |  1 -
 arch/c6x/Kconfig                              |  1 -
 arch/csky/Kconfig                             |  1 -
 arch/h8300/Kconfig                            |  1 -
 arch/hexagon/Kconfig                          |  1 -
 arch/ia64/Kconfig                             |  1 +
 arch/ia64/kernel/time.c                       | 36 ++++++---------
 arch/m68k/68000/timers.c                      |  7 ++-
 arch/m68k/Kconfig.cpu                         | 34 +++++++++++---
 arch/m68k/Kconfig.machine                     | 15 +++++++
 arch/m68k/amiga/config.c                      | 11 +++--
 arch/m68k/apollo/config.c                     | 11 +++--
 arch/m68k/atari/config.c                      |  2 +-
 arch/m68k/atari/time.c                        |  9 ++--
 arch/m68k/bvme6000/config.c                   |  9 ++--
 arch/m68k/coldfire/Makefile                   | 32 ++++++++------
 arch/m68k/coldfire/pit.c                      |  2 +-
 arch/m68k/coldfire/sltimers.c                 |  8 ++--
 arch/m68k/coldfire/timers.c                   |  8 ++--
 arch/m68k/hp300/time.c                        |  8 ++--
 arch/m68k/hp300/time.h                        |  2 +-
 arch/m68k/include/asm/machdep.h               | 12 +++--
 arch/m68k/kernel/setup_mm.c                   |  2 +-
 arch/m68k/kernel/setup_no.c                   |  2 +-
 arch/m68k/kernel/time.c                       | 18 ++------
 arch/m68k/mac/config.c                        |  6 +--
 arch/m68k/mac/via.c                           | 44 +++++++++++++++----
 arch/m68k/mvme147/config.c                    |  9 ++--
 arch/m68k/mvme16x/config.c                    |  9 ++--
 arch/m68k/q40/config.c                        |  2 +-
 arch/m68k/q40/q40ints.c                       | 10 ++---
 arch/m68k/sun3/config.c                       |  4 +-
 arch/m68k/sun3/sun3ints.c                     |  3 +-
 arch/m68k/sun3x/time.c                        |  5 +--
 arch/m68k/sun3x/time.h                        |  2 +-
 arch/microblaze/Kconfig                       |  1 -
 arch/mips/Kconfig                             |  1 -
 arch/nds32/Kconfig                            |  1 -
 arch/nios2/Kconfig                            |  1 -
 arch/openrisc/Kconfig                         |  1 -
 arch/parisc/Kconfig                           |  2 +-
 arch/parisc/kernel/time.c                     |  9 ++--
 arch/powerpc/Kconfig                          |  1 -
 arch/riscv/Kconfig                            |  1 -
 arch/s390/Kconfig                             |  1 -
 arch/sh/Kconfig                               |  1 -
 arch/sparc/Kconfig                            |  1 -
 arch/um/Kconfig                               |  1 -
 arch/x86/Kconfig                              |  1 -
 arch/xtensa/Kconfig                           |  1 -
 include/linux/timekeeping.h                   |  5 +--
 kernel/time/Kconfig                           |  9 +++-
 kernel/time/Makefile                          |  1 +
 kernel/time/tick-legacy.c                     | 37 ++++++++++++++++
 kernel/time/timekeeping.c                     | 16 -------
 kernel/time/timekeeping.h                     |  1 +
 64 files changed, 242 insertions(+), 221 deletions(-)
 create mode 100644 kernel/time/tick-legacy.c
Cc Russell King <[email protected]>
Cc Tony Luck <[email protected]>
Cc Fenghua Yu <[email protected]>
Cc Greg Ungerer <[email protected]>
Cc Geert Uytterhoeven <[email protected]>
Cc Finn Thain <[email protected]>
Cc Philip Blundell <[email protected]>
Cc Joshua Thompson <[email protected]>
Cc Sam Creasey <[email protected]>
Cc "James E.J. Bottomley" <[email protected]>
Cc Helge Deller <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Daniel Lezcano <[email protected]>
Cc John Stultz <[email protected]>
Cc Stephen Boyd <[email protected]>
Cc Linus Walleij <[email protected]>
Signature · 1 line
2.27.0