migration: Make save/load_snapshot() return boolean
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest3 patches 4 repliesIn review
- v13 patches 7 repliesSuperseded
Changes in v2 from the cover letter
- Initialize variables in first patch (Max)
- Added Pavel's A-b tag
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | block: push error reporting into bdrv_all_*_snapshot functionsblock/ block/ include/ +4 more | +67 | 1 reply | |
| 2/3 | migration: Make save_snapshot() return bool, not 0/-1include/ migration/ replay/ +1 more | +18 | 2 replies | |
| 3/3 | migration: stop returning errno from load_snapshot()include/ migration/ monitor/ +2 more | +20 | 1 reply |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Pavel Dovgalyuk | Dr. David Alan Gilbert | Max Reitz |
|---|---|---|---|
| 1/3 | R-b | ||
| 2/3 | A-b | ||
| 3/3 | A-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v2 0/3] migration: Make save/load_snapshot() return boolean
Since v1:
- Initialize variables in first patch (Max)
- Added Pavel's A-b tag
I had a pair of patches making save_snapshot/load_snapshot() return a boolean (like Markus recent qdev/QOM cleanup), then realized Daniel already has series changing migration/, so I rebased my patches in the first part of his v6 series:
"migration: bring improved savevm/loadvm/delvm to QMP"
https://lists.gnu.org/archive/html/qemu-devel/2020-10/msg02158.html
I included patch #1/#3 from Daniel, #2 is my first patch, and my second patch is squashed with Daniel's #3.
Daniel if you find these patches worthwhile, please consider them while merging your series (or respining).
Regards,
Phil.
Daniel P. Berrangé (2):
block: push error reporting into bdrv_all_*_snapshot functions
migration: stop returning errno from load_snapshot()
Philippe Mathieu-Daudé (1):
migration: Make save_snapshot() return bool, not 0/-1
include/block/snapshot.h | 14 +++---- include/migration/snapshot.h | 18 +++++++- block/monitor/block-hmp-cmds.c | 7 ++-- block/snapshot.c | 77 +++++++++++++++++----------------- migration/savevm.c | 72 ++++++++++++------------------- monitor/hmp-cmds.c | 9 +--- replay/replay-debugging.c | 6 +-- replay/replay-snapshot.c | 4 +- softmmu/vl.c | 2 +- tests/qemu-iotests/267.out | 10 ++--- 10 files changed, 105 insertions(+), 114 deletions(-)
Signature · 1 line
2.26.2