Skip to content

migration: Make save/load_snapshot() return boolean

Philippe Mathieu-Daudé qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 4 repliesIn review
  2. v13 patches 7 repliesSuperseded

Changes in v2 from the cover letter

- Initialize variables in first patch (Max)
- Added Pavel's A-b tag

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3block: push error reporting into bdrv_all_*_snapshot functionsblock/monitor/block-hmp-cmds.c block/snapshot.c include/block/snapshot.h +4 more+67 -891 reply
2/3migration: Make save_snapshot() return bool, not 0/-1include/migration/snapshot.h migration/savevm.c replay/replay-debugging.c +1 more+18 -112 replies
3/3migration: stop returning errno from load_snapshot()include/migration/snapshot.h migration/savevm.c monitor/hmp-cmds.c +2 more+20 -141 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchPavel DovgalyukDr. David Alan GilbertMax Reitz
1/3R-b
2/3A-b
3/3A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/3] migration: Make save/load_snapshot() return boolean

Since v1:
- Initialize variables in first patch (Max)
- Added Pavel's A-b tag

I had a pair of patches making save_snapshot/load_snapshot() return a boolean (like Markus recent qdev/QOM cleanup), then realized Daniel already has series changing migration/, so I rebased my patches in the first part of his v6 series:
"migration: bring improved savevm/loadvm/delvm to QMP"
https://lists.gnu.org/archive/html/qemu-devel/2020-10/msg02158.html

I included patch #1/#3 from Daniel, #2 is my first patch, and my second patch is squashed with Daniel's #3.

Daniel if you find these patches worthwhile, please consider them while merging your series (or respining).

Regards,

Phil.

Daniel P. Berrangé (2):
block: push error reporting into bdrv_all_*_snapshot functions
migration: stop returning errno from load_snapshot()

Philippe Mathieu-Daudé (1):
migration: Make save_snapshot() return bool, not 0/-1

 include/block/snapshot.h       | 14 +++----
 include/migration/snapshot.h   | 18 +++++++-
 block/monitor/block-hmp-cmds.c |  7 ++--
 block/snapshot.c               | 77 +++++++++++++++++-----------------
 migration/savevm.c             | 72 ++++++++++++-------------------
 monitor/hmp-cmds.c             |  9 +---
 replay/replay-debugging.c      |  6 +--
 replay/replay-snapshot.c       |  4 +-
 softmmu/vl.c                   |  2 +-
 tests/qemu-iotests/267.out     | 10 ++---
 10 files changed, 105 insertions(+), 114 deletions(-)
Signature · 1 line
2.26.2