UCSI race condition resulting in wrong port state
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 12 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | usb: typec: ucsi: acpi: Always decode connector change informationdrivers/ | +3 | 0 replies | |
| 2/2 | usb: typec: ucsi: Work around PPM losing change informationdrivers/ drivers/ | +107 | 0 replies |
Reviews trailers per patch
None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Heikki Krogerus |
|---|---|
| Series | A-b |
| 1/2 | |
| 2/2 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/2] UCSI race condition resulting in wrong port state
From: Benjamin Berg <[email protected]>
Hi all,
so, I kept running in an issue where the UCSI port information was saying that power was being delivered (online: 1), while no cable was attached.
The core of the problem is that there are scenarios where UCSI change notifications are lost. This happens because querying the changes that happened is done using the GET_CONNECTOR_STATUS command while clearing the bitfield happens from the separate ACK command. Any change in between will be lost.
Note that the problem may be almost invisible in the UI as e.g. GNOME will still show the battery as discharging. But some policies like automatic suspend may be applied incorrectly.
Benjamin Berg (2):
usb: typec: ucsi: acpi: Always decode connector change information
usb: typec: ucsi: Work around PPM losing change information
drivers/usb/typec/ucsi/ucsi.c | 125 ++++++++++++++++++++++++----- drivers/usb/typec/ucsi/ucsi.h | 2 + drivers/usb/typec/ucsi/ucsi_acpi.c | 5 +- 3 files changed, 110 insertions(+), 22 deletions(-)
Signature · 1 line
2.26.2